Added more information to script/plugin's doings to ease debugging #3755 [Rick Olson]

git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3657 5ecf4fe2-1ee6-0310-87b1-e25e094e27de

railties/CHANGELOG

@@ -1,5 +1,7 @@
 *SVN*
 
+* Added more information to script/plugin's doings to ease debugging #3755 [Rick Olson]
+
 * Changed the default configuration for lighttpd to use tmp/sockets instead of log/ for the FastCGI sockets [DHH]
 
 * Added a default configuration of the FileStore for fragment caching if tmp/cache is available, which makes action/fragment caching ready to use out of the box with no additional configuration [DHH]
@@ -20,8 +22,6 @@
 
 * Added SIGTRAP signal handler to RailsFCGIHandler that'll force the process into a breakpoint after the next request. This breakpoint can then be caught with script/breakpointer and give you access to the Ruby image inside that process. Useful for debugging memory leaks among other things [DHH]
 
-* Update script.aculo.us to V1.5.2 [Thomas Fuchs]
-
 * Changed default lighttpd.conf to use CWD from lighttpd 1.4.10 that allows the same configuration to be used for both detach and not. Also ensured that auto-repeaping of FCGIs only happens when lighttpd is not detached. [DHH]
 
 * Added Configuration#after_initialize for registering a block which gets called after the framework is fully initialized.  Useful for things like per-environment configuration of plugins. [Michael Koziarski]
@@ -48,16 +48,8 @@
 
 * Reap FCGI processes after lighttpd exits. [Sam Stephenson]
 
-* Update to script.aculo.us to 1.5.0 rev. 3343 [Thomas Fuchs]
-
 * Honor ActiveRecord::Base.pluralize_table_names when creating and destroying session store table. #3204. [rails@bencurtis.com, Marcel Molina Jr.]
 
-* Update to script.aculo.us 1.5.0 final (equals 1.5.0_rc6) [Thomas Fuchs]
-
-* Update to Prototype 1.4.0 final [Sam Stephenson]
-
-* Update to script.aculo.us 1.5.0_rc6
-
 * Update instructions on how to find and install generators. #3172. [Chad Fowler]
 
 * Generator looks in vendor/generators also.  [Chad Fowler]
@@ -90,20 +82,14 @@
 
 * Introducing the session_migration generator.  Creates an add_session_table migration.  Allows generator to specify migrations directory.  #2958, #2960 [Rick Olson]
 
-* Update to Prototype 1.4.0_rc4. Closes #2943 (old Array.prototype.reverse behavior can be obtained by passing false as an argument). [Sam Stephenson]
-
 * script/console uses RAILS_ENV environment variable if present.  #2932 [Blair Zajac <blair@orcaware.com>
 
 * Windows: eliminate the socket option in database.yml.  #2924 [Wayne Vucenic <waynev@gmail.com>]
 
 * Eliminate nil from newly generated logfiles.  #2927 [Blair Zajac <blair@orcaware.com>]
 
-* Update to Prototype 1.4.0_rc3. Closes #1893, #2505, #2550, #2748, #2783. [Sam Stephenson]
-
 * Rename Version constant to VERSION. #2802 [Marcel Molina Jr.]
 
-* Update to latest script.aculo.us version (as of [3031])
-
 * Eliminate Subversion dependencies in scripts/plugin.  Correct install options.  Introduce --force option to reinstall a plugin.  Remove useless --long option for list.  Use --quiet to quiet the download output and --revision to update to a specific svn revision.  #2842 [Chad Fowler, Rick Olson]
 
 * SQLite: the clone_structure_to_test and purge_test_database Rake tasks should always use the test environment.  #2846 [Rick Olson]
@@ -126,6 +112,7 @@
 
 * Added an omnipresent RailsInfoController with a properties action that delivers an HTML rendering of Rails::Info (but only when local_request? is true). Added a new default index.html which fetches this with Ajax. [Sam Stephenson]
 
+
 *0.14.3 (RC4)* (November 7th, 2005)
 
 * Add 'add_new_scripts' rake task for adding new rails scripts to script/* [Jamis Buck]

railties/lib/commands/plugin.rb

@@ -175,6 +175,7 @@ class Plugin
   def uninstall
     path = "#{rails_env.root}/vendor/plugins/#{name}"
     if File.directory?(path)
+      puts "Removing 'vendor/plugins/#{name}'" if $verbose
       rm_r path
     else
       puts "Plugin doesn't exist: #{path}"
@@ -211,6 +212,7 @@ class Plugin
       root = rails_env.root
       mkdir_p "#{root}/vendor/plugins"
       Dir.chdir "#{root}/vendor/plugins"
+      puts "fetching from '#{uri}'" if $verbose
       fetcher = RecursiveHTTPFetcher.new(uri)
       fetcher.quiet = true if options[:quiet]
       fetcher.fetch
@@ -222,6 +224,7 @@ class Plugin
       base_cmd = "svn #{cmd} #{uri} \"#{root}/vendor/plugins/#{name}\""
       base_cmd += ' -q' if options[:quiet] and not $verbose
       base_cmd += " -r #{options[:revision]}" if options[:revision]
+      puts base_cmd if $verbose
       system(base_cmd)
     end
 
@@ -331,8 +334,7 @@ class Repository
   attr_reader :uri, :plugins
   
   def initialize(uri)
-    uri << "/" unless uri =~ /\/$/
-    @uri = uri
+    @uri = uri.chomp('/') << "/"
     @plugins = nil
   end