github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-01-14 17:18:04 -05:00
Code Issues Packages Projects Releases Wiki Activity
24,493 Commits 34 Branches 105 Tags
3-1-github
Commit Graph

211 Commits

Author SHA1 Message Date
Arun Agrawal
1ca38c6681 Warnings removed unused variables. Please don't add them 2011-09-10 13:03:46 +05:30
Lachlan Sylvester
8dade4985b fix some types in schema_test.rb 2011-07-27 01:18:20 -07:00
Josh Kalderimis
00958696d8 corrected some further tests and docs for the ARes change to json change 2011-05-18 00:34:10 -04:00
Josh Kalderimis
6b4bbb4274 updated all the tests in ARes to work with json 2011-05-18 00:34:09 -04:00
Josh Kalderimis
4a9365ee18 move the ARes conn test to the correct location 2011-05-18 00:34:09 -04:00
Josh Kalderimis
6062017382 remove a circular dependency 2011-05-18 00:34:09 -04:00
Sebastian Martinez
21b61a8ac4 Follow code conventions on some tests 2011-05-10 20:58:36 -03:00
Paolo "Nusco" Perrotta
24e4ea582b Fixed minor typo in comment 2011-04-26 16:15:20 -07:00
Prem Sichanugrist
733bfa63f5 Remove #among? from Active Support 
After a long list of discussion about the performance problem from using varargs and the reason that we can't find a great pair for it, it would be best to remove support for it for now.

It will come back if we can find a good pair for it. For now, Bon Voyage, `#among?`.
 2011-04-13 20:25:28 +08:00
David Heinemeier Hansson
d1575ae1b9 Change Object#either? to Object#among? -- thanks to @jamesarosen for the suggestion! 2011-04-12 00:23:07 +02:00
Prem Sichanugrist
a9f3c9da01 Using Object#in? and Object#either? in various places 
There're a lot of places in Rails source code which make a lot of sense to switching to Object#in? or Object#either? instead of using [].include?.
 2011-04-11 03:17:09 +08:00
R.T. Lechow
48841dd6ae Active Resource typos. 2011-03-05 11:56:34 +01:00
Ken Mazaika
1bedee5631 ActiveResource validation tests did not test ActiveModel validations. Adjust the test to be done the Rails3 way. 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2011-02-15 12:04:42 -02:00
Josh Bassett
056be15212 Fixed a bug where ActiveResource::HttpMock would not replace an existing response when passing a block to the respond_to method. 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2011-02-09 19:25:53 -02:00
Santiago Pastorino
d891ad4e92 Make ARes tests unescape [ and ] 2010-11-18 23:52:17 -02:00
Gaston Ramos
aee043de5a - ActiveResource::HttpMock.respond_to 
do not replace the response with the same path but different method
- Fix typo

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-10-07 16:50:41 +02:00
Gaston Ramos
b9f8501f82 - Fix ActiveResource::HttpMock.respond_to replace the response 
if it has the same request

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-10-07 16:50:34 +02:00
Aaron Patterson
ef8ce78ba1 changing map and include to find 2010-09-30 11:00:14 -07:00
Neeraj Singh
0495736339 assert on empty array is always true. fixing test. 2010-09-30 23:57:55 +08:00
Matthijs Langenberg
67a838574b Fix broken module namespacing in ActiveResource with Ruby 1.9 [#5699 state:resolved] 
Following namespace use case was broken with Ruby 1.9:

  class Author < ActiveRecord::Base
    ...
  end

  module Api
    class Book < ActiveResouce::Base
    end
  end

Let's say XML contains <book><author><name>John</name></author>....

  Api::Book.first.author.class.to_s #=>
    Ruby 1.8.7: "Api::Book::Author" (namespaced, correct),
    Ruby 1.9: "Author" (toplevel, broken)

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-09-27 23:10:55 +02:00
Gaston Ramos
f85b38a36b - added mock to test ActiveResource::MissingPrefixParam in finder_test 2010-09-27 15:25:44 -03:00
Gaston Ramos
823a8e6e66 - check prefix options in collection_path 2010-09-27 15:25:33 -03:00
Gaston Ramos
9363931f34 - better name for prefix param test case 2010-09-27 15:25:28 -03:00
Gaston Ramos
a71e07d61e - elmenth_path raise an ActiveResource::MissingPrefixParam exception when prefix_options does not has all required prefix_options ex: class StreetAddress < ActiveResource::Base self.site = "http://37s.sunrise.i:3000/people/:person_id/" end 
StreetAddress.element_path(1)
    # => ActiveResource::MissingPrefixParam
 2010-09-27 15:25:16 -03:00
José Valim
e0c344dc49 Fix active_resource assertions. 2010-09-25 17:56:56 +02:00
Jacques Crocker
51f1f550da Allow per Resource format settings 
Previously, ActiveResource was using the connection level formatter for get requests. This made it impossible to use custom formatters per resource.

Additionally this commit makes the Connection request methods more consistent. It always returns a Response. The base will then decode it each the response using its format setting.

Merging this commit will allow users to add custom formatters on a per Resource basis. This enables handling pagination responses from the server side, a very common use case that was previously impossible without monkeypatching XmlFormat.

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-09-25 13:54:09 +02:00
Jacques Crocker
ee5ef67c44 Allow ActiveResource to work with non-generated ids [#5660 state:resolved] 
This commit updates new? so that it knows whether or not the record was actually new or not, and doesn't rely solely on the presence of id. This enables the ability to set a custom primary_key that is not autogenerated by the server.

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-09-25 11:15:40 +02:00
Xavier Noria
8c0c815ba7 resolves rdoc conflict 2010-09-23 22:35:08 +02:00
Neeraj Singh
39debfc854 test for #5038 2010-09-18 20:49:41 +02:00
Emilio Tagua
f2765a1cb3 Refactor setup methods by extracting them in abstract_unit, remove TODO. 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-09-17 17:03:58 +02:00
Emilio Tagua
a521a3c05a Remove TODO and support all expected attributes. 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-09-17 17:03:51 +02:00
Alexey Mahotkin
dfebdb1b03 Tiny fixes to rdoc 2010-09-16 17:10:36 +04:00
Carlos Antonio da Silva
a18b73b43c Remove all deprecation warnings in activeresource 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-09-06 13:38:38 +02:00
José Valim
599e46bf24 Revert "Setup explicit requires for files with exceptions. Removed them from autoloading." 
Booting a new Rails application does not work after this commit [#5359 state:open]

This reverts commit 38a421b34d.
 2010-09-02 21:11:03 +02:00
Andreas Garnæs
1503e45e2e ActiveModel#to_xml fix (renamed parameter). 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-09-02 12:55:45 +02:00
Łukasz Strzałkowski
38a421b34d Setup explicit requires for files with exceptions. Removed them from autoloading. 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-09-02 11:54:04 +02:00
Mikel Lindsaar
58d0e2c23c Adding option to ActiveResource to allow you to not reset the previously stored requests and responses by passing false to respond_to 2010-08-29 22:54:19 -07:00
Mikel Lindsaar
a299642293 Updating documentation on ActiveResource HTTP Mock and also adding test coverage 2010-08-29 22:54:19 -07:00
Mikel Lindsaar
c1b49f1e18 Make ActiveResource::InvalidRequestError more user friendly 
Signed-off-by: Xavier Noria <fxn@hashref.com>
 2010-08-25 10:00:37 +02:00
Santiago Pastorino
b451de0d6d Deletes trailing whitespaces (over text files only find * -type f -exec sed 's/[ \t]*$//' -i {} \;) 2010-08-14 04:12:33 -03:00
Josef Reidinger
59693c4c49 fix loading of different elements in array then int and string [#5036 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-02 17:06:09 +02:00
Josef Reidinger
0e969bdaf8 fix escaping id and parameters in path [#5137 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-26 16:59:47 +02:00
Santiago Pastorino
30df88ae06 These tests are trusting in the order of the elements so use OrderedHash instead of Hash 2010-07-21 17:34:43 -07:00
David Trasbo
df083b482d Make sure ActiveResource::Errors#from_json doesn't pass nil to #from_array [#3650 state:commited] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-26 19:23:10 +02:00
Elomar França
176c386409 Fix bug where ActiveResource::HttpMock would overwrite Accept/Content-Type header to application/xml [#4939 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-24 13:25:10 +02:00
José Valim
6788db824a Move Rails::LogSubscriber to ActiveSupport::LogSubscriber, allowing frameworks like ActiveRecord and ActiveResource to log outsude Rails::Application [#4816 state:resolved] 2010-06-24 13:23:43 +02:00
Xavier Noria
f17159b029 edit pass: the names of Rails components have a space, ie, "Active Record", not "ActiveRecord" 2010-06-14 23:22:04 +02:00
Elomar França
7bd30b9585 Adding to_key to ActiveResource objects using ActiveModel::Conversion [#4685 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-05-26 15:57:27 +02:00
Neeraj Singh
1bc6b43f53 Replace assert with assert_equal in some test cases 
[#4654 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-05-21 16:00:49 +02:00
Neeraj Singh
39a246f545 Final iteration of use better testing methods 
[#4652 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-05-19 21:31:51 +02:00