github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-01-30 08:48:06 -05:00
Code Issues Packages Projects Releases Wiki Activity
4,453 Commits 34 Branches 105 Tags
01452feff1ab4e06ed41cd093bb8a140cd6b2cb6
Commit Graph

4453 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jeremy Kemper
01452feff1 DeprecatedInstanceVariable#inspect doesn't warn since test/unit, error logs, and others use it for diagnostics. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5763 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-20 21:28:31 +00:00
Jeremy Kemper
a8b53f1dbb Oracle: fix connection reset failure. Closes #6846. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5761 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-20 21:14:41 +00:00
Jeremy Kemper
7f32a85464 Fix date helper :include_blank regression. Closes #3811. [mhw] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5759 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-20 18:39:41 +00:00
Jeremy Kemper
9a27b29755 Silence log_error deprecation warnings from inspecting deprecated instance variables. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5757 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-19 23:16:10 +00:00
Jeremy Kemper
e56bd3a121 Only cache GET requests with a 200 OK response. Closes #6514, #6743. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5755 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-19 20:25:52 +00:00
Jeremy Kemper
7277c51891 Partially revert [5660] - makes more trouble than it resolves. References #5704, closes #6766. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5753 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-19 19:47:21 +00:00
Jeremy Kemper
8732ce291b Subclass instantiation doesn't try to explicitly require the corresponding subclass. Closes #6840. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5751 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-19 19:23:56 +00:00
Jeremy Kemper
55d248ba72 use RAILS_DEFAULT_LOGGER in debug mode so we can log Dependencies activity 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5750 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-19 18:44:04 +00:00
Jeremy Kemper
5f18fd93de utf8 mysql topics table 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5749 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-19 18:04:42 +00:00
Jamis Buck
33e48d5f97 Add a 'referer' attribute to TestRequest 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5748 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-19 17:11:26 +00:00
Rick Olson
32bc10d7df fix Rakefile so that the rdoc can be generated 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5747 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-19 14:59:30 +00:00
Rick Olson
e7c2c7982f Ensure render :json => ... skips the layout. Closes #6808 [Josh Peek] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5746 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-19 04:41:57 +00:00
Rick Olson
41466a4c83 fix faulty inheritance tests and that eager loading grabs the wrong inheritance column when the class of your association is an STI subclass. Closes #6859 [protocool] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5744 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-19 03:10:39 +00:00
Jeremy Kemper
d68f559640 Don't require test/unit since it tries to turn everything into a test run. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5740 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-18 20:59:40 +00:00
Michael Koziarski
507445862e Reapply plugin load path changes from [5720] 
Closes #6842
Closes #6851


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5738 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-18 20:27:05 +00:00
Jeremy Kemper
7d49da95a9 Another test that the deprecation spout is plugged. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5730 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-17 08:29:21 +00:00
Jeremy Kemper
8a73d4fe6f Deprecation: silence warnings when reporting test errors. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5728 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-17 08:21:45 +00:00
Jeremy Kemper
2570f408f0 Work around a cross-platform number_to_precision inconsistency in unit tests. Closes #6315. [jesperron] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5727 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-17 01:00:29 +00:00
Jeremy Kemper
86deb27095 Hash#slice(*keys) returns a new hash with only the given keys. #slice! replaces the hash with only the given keys. Works with HashWithIndifferentAccess also. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5726 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-17 00:49:41 +00:00
Jeremy Kemper
05a5209f82 HashWithIndifferentAccess#to_hash converts to a Hash with String keys and the same default value. Fix Hash#reverse_update to be an alias for reverse_merge./script/console More thoroughly test the reverse_* methods. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5725 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-16 23:48:24 +00:00
Jeremy Kemper
0fc8056975 Silence warnings; use more precise assertions. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5724 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-16 23:45:44 +00:00
Michael Koziarski
23c2768421 Revert [5720] 
Reopens #6581
Reopens #6842


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5722 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-16 02:22:23 +00:00
Michael Koziarski
39686e5370 Make config.plugins affect $LOAD_PATH and remove duplication from $LOAD_PATH [James Adam] 
Closes #6581
Closes #6842



git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5720 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-15 23:41:58 +00:00
Rick Olson
d833645cd8 Fix HTML::Node to output double quotes instead of single quotes. Closes #6845 [mitreandy] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5718 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-14 20:56:03 +00:00
Rick Olson
011f4e7413 Allow subclassed resources to share the site info [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5717 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-13 02:15:27 +00:00
Jeremy Kemper
2f184c338b Correctly report which filter halted the chain. References #6699. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5715 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-12 22:26:37 +00:00
Rick Olson
55d4dbb8df Fix issues with ActiveResource collection handling. Closes #6291. [bmilekic] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5714 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-12 15:29:54 +00:00
Kent Sibilev
2f5ee5a812 Ensure that DispatcherError is being thrown correctly when a malformed request is received. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5713 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-11 21:09:47 +00:00
Nicholas Seckar
6a485c3100 Fix remove_constant to correctly handle constant names of the form "::A::...". References #6720. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5710 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-09 05:21:33 +00:00
Nicholas Seckar
d1a2449220 Fix a bug in Routing where a parameter taken from the path of the current request could not be used as a query parameter for the next. Closes #6752. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5709 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-09 04:42:32 +00:00
Jeremy Kemper
a50fc11583 Rewrap scaffold_resource USAGE so it displays nicely on most terminals. Closes #6801 [Paul Smith] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5707 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-08 22:47:46 +00:00
Jeremy Kemper
a454dcf012 Unrescued ActiveRecord::RecordNotFound responds with 404 instead of 500. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5706 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-08 22:19:00 +00:00
Tobias Lütke
906bd93f4f Remove side effects of [5684] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5705 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-08 21:41:15 +00:00
Tobias Lütke
2f9d44e50b Improved auto_link to match more valid urls correctly 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5704 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-07 22:12:48 +00:00
Rick Olson
90179a9ba5 added tests checking for nested singleton resources 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5703 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-07 16:31:41 +00:00
Rick Olson
c49cd7f18a fix docs for singleton resources 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5702 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-07 15:42:01 +00:00
Rick Olson
d0fa4d3e33 Add singleton resources. [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5701 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-07 15:36:08 +00:00
Jeremy Kemper
e44f7fb07a Remove support for json in X-Post-Data-Format header since it's for backward compatibility only. References #4185. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5698 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-06 23:20:24 +00:00
Jeremy Kemper
953214bd23 Remove unrelated render :yaml changes. References #4185. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5697 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-06 23:16:25 +00:00
Jeremy Kemper
189ecafa53 Update changelog to reflect application/json content type. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5696 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-06 23:10:58 +00:00
Jeremy Kemper
91d99e2f53 More thorough JSON tests. Use application/json by default, per rfc4627. References #4185. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5695 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-06 23:06:38 +00:00
Jeremy Kemper
42596543dc respond_to recognizes JSON. render :json => @person.to_json automatically sets the content type and takes a :callback option to specify a client-side function to call using the rendered JSON as an argument. References #4185. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5694 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-06 22:27:08 +00:00
Jeremy Kemper
4c9000d51d Changelog for bungled commit. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5692 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-06 22:10:09 +00:00
Jeremy Kemper
ee384b8981 Missed commit from [5686]. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5691 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-06 22:08:59 +00:00
Jeremy Kemper
50c98942a5 Don't do introspection queries during locking tests [Michael Schoen] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5689 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-06 20:28:26 +00:00
Jeremy Kemper
07423bed4b Bob's raining patches: fixes date_helper bugs and usability issues. References #3811. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5685 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-06 19:15:24 +00:00
Tobias Lütke
cdad2d41e1 Consolidated different create and create! versions to call through to the base class with scope. This fixes inconsistencies, especially related to protected attribtues. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5684 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-06 00:13:31 +00:00
Jeremy Kemper
8dea60b0c3 find supports :lock with :include. Check whether your database allows SELECT ... FOR UPDATE with outer joins before using. Closes #6764. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5682 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-05 22:07:55 +00:00
Jeremy Kemper
eb300f8428 AssociationCollection#any? takes a block [Michael Schoen] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5681 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-05 21:49:36 +00:00
Jeremy Kemper
7370e54cc4 *_path instance methods. Check for missing/invalid site uri. http_mock response takes message arg, extracts numeric code. Tests log to test/debug.log 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5680 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-05 19:12:51 +00:00