github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-01-30 16:58:15 -05:00
Code Issues Packages Projects Releases Wiki Activity
4,453 Commits 34 Branches 105 Tags
01452feff1ab4e06ed41cd093bb8a140cd6b2cb6
Commit Graph

957 Commits

Author SHA1 Message Date
Jeremy Kemper
9a27b29755 Silence log_error deprecation warnings from inspecting deprecated instance variables. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5757 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-19 23:16:10 +00:00
Jeremy Kemper
e56bd3a121 Only cache GET requests with a 200 OK response. Closes #6514, #6743. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5755 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-19 20:25:52 +00:00
Jamis Buck
33e48d5f97 Add a 'referer' attribute to TestRequest 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5748 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-19 17:11:26 +00:00
Rick Olson
e7c2c7982f Ensure render :json => ... skips the layout. Closes #6808 [Josh Peek] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5746 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-19 04:41:57 +00:00
Rick Olson
d833645cd8 Fix HTML::Node to output double quotes instead of single quotes. Closes #6845 [mitreandy] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5718 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-14 20:56:03 +00:00
Jeremy Kemper
2f184c338b Correctly report which filter halted the chain. References #6699. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5715 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-12 22:26:37 +00:00
Nicholas Seckar
d1a2449220 Fix a bug in Routing where a parameter taken from the path of the current request could not be used as a query parameter for the next. Closes #6752. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5709 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-09 04:42:32 +00:00
Jeremy Kemper
a454dcf012 Unrescued ActiveRecord::RecordNotFound responds with 404 instead of 500. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5706 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-08 22:19:00 +00:00
Rick Olson
c49cd7f18a fix docs for singleton resources 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5702 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-07 15:42:01 +00:00
Rick Olson
d0fa4d3e33 Add singleton resources. [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5701 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-07 15:36:08 +00:00
Jeremy Kemper
e44f7fb07a Remove support for json in X-Post-Data-Format header since it's for backward compatibility only. References #4185. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5698 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-06 23:20:24 +00:00
Jeremy Kemper
953214bd23 Remove unrelated render :yaml changes. References #4185. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5697 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-06 23:16:25 +00:00
Jeremy Kemper
91d99e2f53 More thorough JSON tests. Use application/json by default, per rfc4627. References #4185. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5695 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-06 23:06:38 +00:00
Jeremy Kemper
42596543dc respond_to recognizes JSON. render :json => @person.to_json automatically sets the content type and takes a :callback option to specify a client-side function to call using the rendered JSON as an argument. References #4185. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5694 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-06 22:27:08 +00:00
David Heinemeier Hansson
2794f4164f Dropped the idea of automatically routing :format for the vanilla routes -- that will be a treat for map.resources. Deprecated the name route root as it'll be used as a shortcut for map.connect '' in Rails 2.0 (Rails 1.2). Added map.root as an alias for map.connect '' (Rails 2.0) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5671 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-04 00:12:00 +00:00
David Heinemeier Hansson
7611fa6d46 Added Request#format to return the format used for the request as a mime type. If no format is specified, the first Request#accepts type is used. This means you can stop using respond_to for anything else than responses [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5664 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-02 23:07:04 +00:00
David Heinemeier Hansson
5410f2cb74 Added the option for extension aliases to mime type registration [DHH] Refactored default mime types to use the extension framework instead of just declaring themselves verbosely 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5663 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-02 22:48:20 +00:00
Jeremy Kemper
13e1d295d6 @response.redirect_url works with 201 Created responses: just return headers['Location'] rather than checking the response status. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5643 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-28 23:25:00 +00:00
Michael Koziarski
f6e85e4ec6 Merge [5641] to Trunk 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5642 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-27 23:56:27 +00:00
Jeremy Kemper
4887e53bf9 Use Location rather than location header. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5635 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-26 05:35:53 +00:00
David Heinemeier Hansson
093c725732 Fix that redirects should set "Location" header, not "location", and remove dead CGI.redirect 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5634 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-26 05:04:57 +00:00
Jeremy Kemper
ba1db2de63 uses_component_template_root looks at caller[0] which turns up the deprecation method rather than the controller. Use caller[1] instead. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5631 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-26 01:24:10 +00:00
David Heinemeier Hansson
396b3f2bef Dont set default charset if the response is sending a file. Closes #6689 [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5626 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-25 19:29:10 +00:00
Tobias Lütke
ad62d461e8 Added CSV to Mime::SET so that respond_to csv will work 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5623 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-24 16:35:00 +00:00
David Heinemeier Hansson
7c7d58937b Fixed that HEAD should return the proper Content-Length header (that is, actually use @body.size, not just 0) [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5622 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-23 23:52:25 +00:00
David Heinemeier Hansson
efd0bdd9ea * Added GET-masquarading for HEAD, so request.method will return :get even for HEADs. This will help anyone relying on case request.method to automatically work with HEAD and map.resources will also allow HEADs to all GET actions. Rails automatically throws away the response content in a reply to HEAD, so you dont even need to worry about that. If you, for whatever reason, still need to distinguish between GET and HEAD in some edge case, you can use Request#head? and even Request.headers["REQUEST_METHOD"] for get the "real" answer. Closes #6694 [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5621 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-23 23:24:47 +00:00
David Heinemeier Hansson
f15d52fc4a Added text/csv as a default mime type and included example on how to make your own in config/environment.rb [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5620 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-23 17:25:52 +00:00
Nicholas Seckar
d1529a71d1 Update Routing to complain when :controller is not specified by a route. Closes #6669. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5607 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-22 16:31:00 +00:00
Jeremy Kemper
6fc8e143c6 Ensure render_to_string cleans up after itself when an exception is raised. Closes #6658. Great tests! 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5591 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-20 11:03:21 +00:00
Nicholas Seckar
f92d6a07d0 Reuse named route helper module between Routing reloads to prevent memory leaks. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5548 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-17 22:29:02 +00:00
Jeremy Kemper
96cca7db6d ActionView::Base.erb_variable accessor names the buffer variable used to render templates. Defaults to _erbout; use _buf for erubis. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5544 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-17 13:10:23 +00:00
Jeremy Kemper
0100a79913 Deprecate standalone components. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5536 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-16 06:40:37 +00:00
Jeremy Kemper
65ca37b7b7 ARStore needs a data reader method. Closes #4795. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5531 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-15 20:08:43 +00:00
Jeremy Kemper
c9e0002d36 assert_select_rjs :remove 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5525 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-15 12:45:52 +00:00
Jeremy Kemper
56e3e2fde5 Always clear model associations from session. Closes #4795. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5512 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-13 18:59:01 +00:00
Jeremy Kemper
f0753992ab test controller rescues 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5504 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-13 02:03:50 +00:00
Jeremy Kemper
73cc10305e Sync ActionController::StatusCodes::STATUS_CODES with http://www.iana.org/assignments/http-status-codes. Closes #6586. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5482 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-11 01:44:37 +00:00
Jeremy Kemper
0342393b30 Multipart form values may have a content type without being treated as uploaded files if they do not provide a filename. Closes #6401. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5473 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-09 18:52:19 +00:00
Jeremy Kemper
57313c54bf assert_response supports symbolic status codes. Closes #6569. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5466 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-07 21:45:10 +00:00
Jeremy Kemper
5c2e9a5e48 Cache parsed query parameters. Closes #6559. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5442 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-06 21:43:21 +00:00
Jeremy Kemper
a8bb66ace8 Deprecate expire_matched_fragments. Use expire_fragment instead. Closes #6535. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5412 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-02 19:29:40 +00:00
Jeremy Kemper
eb7964865a Document that expire_fragment with regexp arg fails on memcached and other caches which don't support iteration over all keys. Closes #6291. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5399 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-11-02 08:48:44 +00:00
David Heinemeier Hansson
b9ffbd3166 Fix scaffolding from using deprecated :post => true (closes #6499) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5366 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-26 15:56:48 +00:00
Jamis Buck
897ffd63d2 Use new deprecate syntax so that alternatives are given with the warning 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5358 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-24 17:14:50 +00:00
Jamis Buck
da18193d5f More consistent implementation of filter replacement (thanks Martin! closes #5949) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5331 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-21 16:55:14 +00:00
Rick Olson
1d7196b552 Force *_url named routes to show the host in ActionView [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5325 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-20 18:00:20 +00:00
David Heinemeier Hansson
f366eb4b2d GET parameter keys can be escaped too [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5318 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-17 22:06:54 +00:00
Jamis Buck
2d33676691 Fix deprecation warnings when rendering the template error template. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5315 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-16 19:59:46 +00:00
Nicholas Seckar
03b383853d Fix routing to correctly determine when generation fails. Closes #6300. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5314 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-16 19:52:21 +00:00
Jamis Buck
b5ec0fe313 Fix broken assert_generates when extra keys are being checked. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5309 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-16 14:32:11 +00:00