Commit Graph

140 Commits

Author SHA1 Message Date
Jeremy Kemper
86deb27095 Hash#slice(*keys) returns a new hash with only the given keys. #slice! replaces the hash with only the given keys. Works with HashWithIndifferentAccess also.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5726 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-12-17 00:49:41 +00:00
Jeremy Kemper
05a5209f82 HashWithIndifferentAccess#to_hash converts to a Hash with String keys and the same default value. Fix Hash#reverse_update to be an alias for reverse_merge./script/console More thoroughly test the reverse_* methods.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5725 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-12-16 23:48:24 +00:00
Jeremy Kemper
0fc8056975 Silence warnings; use more precise assertions.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5724 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-12-16 23:45:44 +00:00
Nicholas Seckar
6a485c3100 Fix remove_constant to correctly handle constant names of the form "::A::...". References #6720.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5710 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-12-09 05:21:33 +00:00
David Heinemeier Hansson
0297b31b82 Fixed Array#to_xml when it contains a series of hashes (each piece would get its own XML declaration) (closes #6610) [thkarcher/cyu]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5668 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-12-03 16:47:53 +00:00
David Heinemeier Hansson
eacca8d7e6 Added Time#to_s(:time) which will just return H:M, like 17:44 [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5628 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-25 23:56:28 +00:00
Marcel Molina
309a6bd550 Add Module#attr_accessor_with_default to initialize value of attribute before setting it. Closes #6538. [Stuart Halloway, Marcel Molina Jr.]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5539 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-16 19:35:13 +00:00
Jeremy Kemper
b97ffa2a4f Hash#to_xml handles keys with the same name as Kernel methods. Closes #6613.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5521 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-14 09:08:40 +00:00
Jeremy Kemper
9a39a86f65 Test multiple timezones' DST. Closes #5617.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5420 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-03 00:40:34 +00:00
Jeremy Kemper
6770c8d7fa Use US timezone for DST tests. Closes #5617.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5418 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-02 20:36:06 +00:00
Jeremy Kemper
5ba85d84fb next_week respects DST changes. Closes #5617, closes #2353, closes #2509, references #4551.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5388 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-11-02 01:52:11 +00:00
Jeremy Kemper
0f5f05b51e next_week respects DST changes. Closes #6483.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5363 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-10-24 23:35:27 +00:00
Jamis Buck
d73f32ce00 make sure the String::Access methods return strings, and not multibyte Char instances
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5299 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-10-13 20:27:46 +00:00
Michael Koziarski
48cef84150 Make core_ext/string/access.rb multibyte safe. Closes #6388 [Manfred Stienstra]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5287 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-10-12 21:03:32 +00:00
Jeremy Kemper
cb978baafa Hash#to_xml supports Bignum and BigDecimal. Closes #6313.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5209 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-29 22:23:16 +00:00
David Heinemeier Hansson
54c393f5fa Hash.create_from_xml has been renamed to Hash.from_xml, alias will exist until Rails 2.0 [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5149 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-20 09:34:29 +00:00
Jeremy Kemper
643571ca25 alias_method_chain yields method target and punctuation to simplify wrapper method definition. Used by the deprecate module method.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5113 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-15 03:42:54 +00:00
Jeremy Kemper
74f60c032e alias_method_chain works with accessor= methods also. Closes #6153.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5091 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-12 07:10:43 +00:00
Jeremy Kemper
5dfec7b217 More tests for alias_method_chain with feature and method punctuation. Closes #4954.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4920 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-03 18:39:35 +00:00
Marcel Molina
9db407f578 Don't pad remaining places with in_groups_of if specified padding value is false. [Marcel Molina Jr.]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4900 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-02 18:02:36 +00:00
Rick Olson
e4a4287c97 Fix cases where empty xml nodes weren't being translated to nil in Hash.create_from_xml [Rick Olson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4895 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-09-01 16:09:18 +00:00
Jeremy Kemper
12ff554cd4 Tighten rescue clauses. Closes #5985.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4885 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-31 03:16:28 +00:00
Jeremy Kemper
965ae90bc6 Eliminate Active Support warnings.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4839 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-29 08:24:04 +00:00
Jeremy Kemper
52c9ad4c98 DateTime#to_time gives hour/minute/second resolution. Closes #5747.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4718 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-07 22:07:33 +00:00
Jeremy Kemper
cfd9e05a2e attr_internal to support namespacing and deprecation
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4692 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-07 01:16:37 +00:00
Nicholas Seckar
52d4166947 Raise fully qualified names upon name errors. Closes #5533.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4681 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-05 22:52:15 +00:00
Nicholas Seckar
196fab9b0d Add extention to obtain the missing constant from NameError instances
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4679 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-05 22:23:58 +00:00
David Heinemeier Hansson
9d00b0ce85 Added Module#alias_attribute [Jamis/DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4653 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-08-03 18:47:43 +00:00
Rick Olson
3a0159dd1e Strip boolean XML content before checking for 'true' [Rick Olson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4616 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-21 05:52:30 +00:00
Rick Olson
1ec9f8d049 Correctly convert <foo nil=true> to nil when using Hash.create_from_xml. [Rick]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4607 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-13 00:44:09 +00:00
Jeremy Kemper
5241b97709 Optional identity for Enumerable#sum defaults to zero. Closes #5657.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4599 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-09 20:48:31 +00:00
Jeremy Kemper
71234daef1 r4487@asus: jeremy | 2006-04-29 12:21:39 -0700
Check whether @flash is defined? for warnings-safety.
 r4488@asus:  jeremy | 2006-04-29 12:23:15 -0700
 Check whether @flash is defined? for warnings-safety. Obviates nil? check.
 r4489@asus:  jeremy | 2006-04-29 12:45:18 -0700
 Check whether @session is defined? for warnings-safety.
 r4490@asus:  jeremy | 2006-04-29 12:50:41 -0700
 Check whether @rendering_runtime is defined? for warnings-safety.
 r4491@asus:  jeremy | 2006-04-29 12:55:01 -0700
 Check whether @_cycles is defined? for warnings-safety.
 r4492@asus:  jeremy | 2006-04-29 12:59:19 -0700
 Check whether instance variables are defined? for warnings-safety.
 r4493@asus:  jeremy | 2006-04-29 13:14:09 -0700
 Add nil @template to PrototypeHelperTest to suppress unitialized instance variable warning.
 r4494@asus:  jeremy | 2006-04-29 13:31:34 -0700
 Check whether @auto_index defined? for warnings-safety.
 r4495@asus:  jeremy | 2006-04-29 13:32:24 -0700
 Wrap content_columns redefinitions with silence_warnings.
 r4496@asus:  jeremy | 2006-04-29 13:35:28 -0700
 Wrap more redefinitions with silence_warnings.
 r4829@asus:  jeremy | 2006-07-08 10:59:20 -0700
 abstract unit, fix warnings
 r4830@asus:  jeremy | 2006-07-08 11:06:12 -0700
 Use parens to silence warning.
 r4831@asus:  jeremy | 2006-07-08 11:06:48 -0700
 Use parens to silence warning.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4595 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-08 18:14:49 +00:00
Jeremy Kemper
12600d77dd HashWithIndifferentAccess shouldn't confuse false and nil. Closes #5601. Nor should it mistreat legitimate nil values.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4555 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-05 17:32:16 +00:00
David Heinemeier Hansson
760bcc6ea9 Fixed HashWithIndifferentAccess#default (closes #5586) [chris@seagul.co.uk]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4539 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-07-05 01:09:40 +00:00
Jeremy Kemper
4defe1ac8a More compatible Hash.create_from_xml. Closes #5523.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4510 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-06-29 02:00:44 +00:00
Jeremy Kemper
236c7325df Enumerable#sum without blocks. Closes #5505. Don't assume 0 identity for sum.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4495 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-06-25 19:11:09 +00:00
Nicholas Seckar
a55265132b Add Enumerable#index_by
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4491 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-06-24 16:42:48 +00:00
David Heinemeier Hansson
fd0eaaa407 Added Enumerable#sum for calculating a sum from the elements [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4489 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-06-24 16:14:59 +00:00
Rick Olson
ae0e1a0682 Enhance Symbol#to_proc so it works with list objects, such as multi-dimensional arrays. Closes #5295 [nov@yo.rim.or.jp]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4455 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-06-17 03:01:57 +00:00
David Heinemeier Hansson
36dc94a6a1 Added Hash.create_from_xml(string) which will create a hash from a XML string and even typecast if possible [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4453 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-06-16 10:07:13 +00:00
David Heinemeier Hansson
e72ff355c3 Fixed that Module#alias_method_chain should work with both foo? foo! and foo at the same time (closes #4954) [anna@wota.jp]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4429 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-06-03 22:43:13 +00:00
Jeremy Kemper
48052d70ec to_xml fixes, features, and speedup. Closes #4989.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4413 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-06-03 00:01:08 +00:00
David Heinemeier Hansson
408fe5facc Added Array#to_s(:db) that'll produce a comma-separated list of ids [DHH] Split Grouping into its own file
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4387 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-05-31 23:25:36 +00:00
Jeremy Kemper
d31830cf9c fix test warnings
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4386 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-05-31 22:43:53 +00:00
Nicholas Seckar
04fb7c30e3 Remove Enumerable#first_match in favor of using break(result_for_each)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4349 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-05-21 01:42:36 +00:00
Marcel Molina
36d1a2f302 Make Array#in_groups_of just return the grouped collection if a block isn't given. [Marcel Molina Jr.]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4345 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-05-17 05:12:53 +00:00
Marcel Molina
f2b3deb85c Don't destroy a HashWithIndifferentAccess if symbolize_keys! or stringify_keys! is called on it. Closes #5076. [Marcel Molina Jr., guy.naor@famundo.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4339 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-05-14 18:17:30 +00:00
Marcel Molina
995167ec2e Strip out punctuation on predicates or bang methods being aliased with alias_method_chain since target?_without_feature is not a valid method name. Add tests for Module#alias_method_chain. [Marcel Molina Jr.]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4311 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-29 20:13:27 +00:00
Sam Stephenson
c71607e29c Add Array#split for dividing arrays into one or more subarrays by value or block
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4208 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-13 05:12:43 +00:00
Nicholas Seckar
f4382af543 fsking svn...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4160 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-04-04 19:41:38 +00:00