Commit Graph

17940 Commits

Author SHA1 Message Date
Santiago Pastorino
04ee54f3fc Bump up rack-mount to 0.6.12 2010-08-22 20:28:37 -03:00
Xavier Noria
b587bfd589 Merge remote branch 'rails/master' 2010-08-23 01:21:43 +02:00
Santiago Pastorino
9992a1a4bf type fixed 2010-08-22 19:59:36 -03:00
Santiago Pastorino
8d1ee434da Silence warnings for Encoding.default_external= and Encoding.default_internal= 2010-08-22 18:43:31 -03:00
Andrew White
ae2c60734a Cache the symbolized path parameters using a instance variable in the request object rather than the environment hash. This it to prevent stale parameters in later routing constraints/redirects as only the normal path parameters are set by Rack::Mount.
Also if a constraint proc arity is more than one, pass the symbolized path parameters
as the first argument to match redirect proc args and provide easier access.

[#5157 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
2010-08-22 16:17:26 -03:00
Santiago Pastorino
d79a010976 Set default_internal and default_external on AS for testing purposes 2010-08-22 02:23:41 -03:00
Santiago Pastorino
3c0158955a Set default_internal and default_external on AM for testing purposes 2010-08-21 22:53:04 -03:00
Santiago Pastorino
1d888d465b Move encoding settings for testing purposes to abstract_unit file 2010-08-21 22:37:53 -03:00
Raphomet
7a090b0216 Trifling typos
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2010-08-21 19:20:42 -03:00
Evgeniy Dolzhenko
c0549ed2e5 Fix docs to reference ActiveRecord::LogSubscriber
since Rails::LogSubscriber doesn't seem to be defined anymore
2010-08-21 09:39:37 +04:00
Brian Lopez
82e389ed30 reload bob after his journy to a new timezone 2010-08-20 20:00:03 -07:00
Jeremy Kemper
c211d904ba Revert "Just add connection management middleware if running in a concurrent environment."
This reverts commit 6b29dc876f.
2010-08-20 18:55:02 -07:00
Xavier Noria
3cd9627bd8 prevent RDoc from autolinking "Rails" in the API home page 2010-08-21 02:25:45 +02:00
Xavier Noria
63bb639036 requires horo 1.0.2 2010-08-21 02:25:45 +02:00
Nick Sieger
2277c51555 Fix hash modification during iteration in Mapper [#5420]
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2010-08-20 18:27:02 -03:00
Andrew White
7c9bf45b0d Support routing constraints in functional tests
Extend assert_recognizes and assert_generates to support passing
full urls as the path argument. This allows testing of routing
constraints such as subdomain and host within functional tests.

[#5005 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
2010-08-20 14:51:25 -03:00
Aaron Patterson
0420fb5647 adding FOUND_ROWS to the connect flags for mysql2 2010-08-20 10:16:22 -07:00
Xavier Noria
0c75ec51a9 Merge remote branch 'rails/master' 2010-08-20 17:18:57 +02:00
Neeraj Singh
87398e531d Patch for Lighthouse ticket #5419 has been been applied. So reverting this one.
Revert "documentation regarding after_validation"

This reverts commit c24aa2f2dc.
2010-08-20 11:08:25 -04:00
Neeraj Singh
2ffa50f5a9 after_validation should be called irrespective of the result of validation.
I confirmed that this is the behavior on 2.3.x .

[5419 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
2010-08-20 11:24:43 -03:00
Neeraj Singh
c24aa2f2dc documentation regarding after_validation 2010-08-20 09:48:07 -04:00
Andrew White
0d0fbf1e64 Don't add the standard https port when using redirect in routes.rb and ensure that request.scheme returns https when using a reverse proxy.
[#5408 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
2010-08-20 10:40:34 -03:00
Andrew White
771d2f918f Allow symbols for :path resource(s) option [#5306 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-08-20 09:32:48 -03:00
Xavier Noria
43291469cb deletes the rdoc task of each component, they are no longer published separately 2010-08-20 13:30:31 +02:00
Xavier Noria
f6222ead47 the pdoc task is no longer needed 2010-08-20 13:14:57 +02:00
Aaron Patterson
949c7e2d0e fisting after_rollback and after commit callbacks 2010-08-20 00:06:49 -07:00
Santiago Pastorino
b91dcb63d0 Bump up tzinfo to 0.3.23 2010-08-20 02:39:09 -03:00
Aaron Patterson
bfd8be7fab updates return number of rows matched rather than number of rows affected 2010-08-19 19:13:50 -07:00
Andrew White
0b73f2af0e Optimize find_sti_class when store_full_sti_class is true
[#5403]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2010-08-19 16:03:15 -05:00
Trevor Turk
99c092d4e8 Note about validates_presence_of and nested attributes 2010-08-19 14:49:10 -05:00
Trevor Turk
e6b6d3adad Note about using attr_accessible with nested attributes 2010-08-19 14:25:15 -05:00
José Valim
de0f47afb2 Use attribute readers as they are faster in general. 2010-08-19 15:16:11 -03:00
Andrew White
c019db8ca1 Move regexps in options hash to :constraints hash so that they are pushed into the scope [#5208 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-08-19 15:05:57 -03:00
Andrew White
0cc483aa14 Move edit route before show route so that it will have precedence if the :id parameter allows slashes [#5409 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-08-19 15:05:33 -03:00
Neeraj Singh
2e45542942 While creating a new record using has_many create method default scope of child should be respected.
author.posts.create should take into account default_scope
defined on post.

[#3939: state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
2010-08-19 14:52:15 -03:00
Santiago Pastorino
43f44c1a03 Bump up rack-mount to 0.6.10 2010-08-19 14:49:16 -03:00
Aaron Patterson
a4458f5d21 removing useless ternary 2010-08-19 10:46:10 -07:00
Aaron Patterson
a70248c3d8 we should wrap strings as sql literals 2010-08-19 10:35:09 -07:00
Santiago Pastorino
57d5cd258e We need bundle update only here 2010-08-19 14:04:29 -03:00
Jeremy Kemper
d3e30a18b2 Memoize STI class lookups for the duration of a request 2010-08-19 11:07:09 -05:00
Aaron Patterson
072cd60379 refactor if / else to ||= 2010-08-18 23:37:37 -07:00
Xavier Noria
5a1d957dce avoids warnings about mismatched indentations in Ruby 1.9.2 2010-08-19 03:44:55 +02:00
Xavier Noria
5914875e77 now for real, the suite loads everything and these went unpatched 2010-08-19 02:57:10 +02:00
Xavier Noria
eab4860e9b avoids a ton o warnings activesupport/lib/active_support/dependencies.rb:239: warning: loading in progress, circular require considered harmful ... activesupport/lib/active_support/core_ext/hash/indifferent_access.rb while running the suite in Ruby 1.9.2 2010-08-19 02:46:42 +02:00
Xavier Noria
c510f05967 get rid of the warning "+ after local variable is interpreted as binary operator even though it seems like unary operator" in Ruby 1.9.2 2010-08-19 02:08:28 +02:00
wycats
483b60b9ff Revert "It's snowing!"
This reverts commit e4283007d6.
2010-08-18 16:49:06 -07:00
Aaron Patterson
e4f424d577 refactoring to remove duplicate logic 2010-08-18 12:10:48 -07:00
Aaron Patterson
93f335b6fb call to present? is not necessary 2010-08-18 11:51:59 -07:00
Javier Martín
3e871eee80 Don't pluralize resource methods [#4704 state:resolved]
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2010-08-18 13:56:46 -03:00
Santiago Pastorino
cad8bef5ea Bump up rdoc to 2.5.10 2010-08-18 11:44:12 -03:00