github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-02-06 04:05:17 -05:00
Code Issues Packages Projects Releases Wiki Activity
2,492 Commits 34 Branches 105 Tags
068d9ef0effb8bfbcaf23f990335c0c867e5a1d7
Commit Graph

2492 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jeremy Kemper
068d9ef0ef Much faster Oracle column reflection. References #2848. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2996 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-13 07:24:50 +00:00
Jeremy Kemper
077ae340e8 r4331@asus: jeremy | 2005-11-12 17:03:45 -0800 
PostgreSQL: default_sequence_name falls back to 'id' pk if both the given pk and discovered pk are nil.
 r4336@asus:  jeremy | 2005-11-12 22:31:39 -0800
 PostgreSQL: correct the sequence discovery fallback query.  References #2594.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2994 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-13 06:32:54 +00:00
Jeremy Kemper
d685e2cf18 SQLite: the clone_structure_to_test and purge_test_database Rake tasks should always use the test environment. Reference #2846. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2992 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-13 02:50:42 +00:00
Jeremy Kemper
91853b8a0d SQLite: the clone_structure_to_test Rake task should always use the test environment. References #2846. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2990 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-13 01:12:48 +00:00
Jeremy Kemper
54dfb29151 PostgreSQL: min_messages = warning for AR tests. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2989 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-12 22:28:38 +00:00
David Heinemeier Hansson
9e0642a4ac Pulled auto-starting browser: More pain than gain 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2987 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-12 16:26:23 +00:00
Jeremy Kemper
7c8f3edc99 r4325@asus: jeremy | 2005-11-12 03:57:46 -0800 
PostgreSQL: correctly discover custom primary key sequences.  PostgreSQL: smarter sequence name defaults, stricter last_insert_id, warn on pk without sequence.  Base.reset_sequence_name analogous to reset_table_name (mostly useful for testing).  Base.define_attr_method allows nil values.  References #2594.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2985 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-12 11:59:54 +00:00
Jamis Buck
7321a41e1b Make Validations#create! use the current scope 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2984 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-12 05:09:05 +00:00
Jeremy Kemper
047c75fa06 SQLServer: don't report limits for unsupported field types. Closes #2835. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2982 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-11 23:45:02 +00:00
Jeremy Kemper
ae6a513bd1 Include the Enumerable module in ActiveRecord::Errors. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2981 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-11 18:49:01 +00:00
David Heinemeier Hansson
0c048e7c6f Changelogging 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2979 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-11 10:02:44 +00:00
David Heinemeier Hansson
8e9484d3c1 Make sure that legacy db tasks also reference :database for SQLite (closes #2830) [kazuhiko@fdiary.net] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2978 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-11 09:50:42 +00:00
Jeremy Kemper
b81c46e6bd options_for_select allows any objects which respond_to? :first and :last rather than restricting to Array and Range. Closes #2824. References [2126]. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2977 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-10 22:08:20 +00:00
Nicholas Seckar
41e4173fd6 Fix const_missing handler to ignore the trailing '.rb' on files when comparing paths. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2976 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-10 20:32:13 +00:00
Jeremy Kemper
80b8b76091 Update docs for AR::Base#clone. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2975 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-10 18:53:31 +00:00
Jeremy Kemper
3309268120 Add :group option, correspond to GROUP BY, to the find method and to the has_many association. Closes #2818. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2974 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-10 16:36:01 +00:00
Jeremy Kemper
3488ff6fc6 Pass __FILE__ when evaluating plugins' init.rb. Closes #2817. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2973 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-10 16:25:06 +00:00
Jeremy Kemper
dfda57af85 Better svn status matching for generators. Closes #2814. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2972 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-10 16:14:25 +00:00
Jamis Buck
df5c74cc7c Make sure the acts_as_list_class is resolved relative to the global namespace 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2971 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-10 15:59:00 +00:00
Scott Barron
339fff7950 This does not need to be thread local (thanks skaes). 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2970 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-10 12:59:22 +00:00
David Heinemeier Hansson
7afaa6ed55 Disabled stderr suppressing until activesupport is available also in non-gem mode 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2969 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-10 11:23:20 +00:00
David Heinemeier Hansson
bc223236a6 Don't reload routes until plugins have been loaded so they have a chance to extend the routing capabilities [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2967 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-10 10:45:39 +00:00
Jeremy Kemper
df7a087c76 Don't cast nil or empty strings to a dummy date. Closes #2789. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2966 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-10 06:56:01 +00:00
Jeremy Kemper
c91088cd13 Expand tabs and strip trailing whitespace. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2965 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-10 06:24:33 +00:00
Jeremy Kemper
b84a7beb98 acts_as_list plays nicely with inheritance by remembering the class which declared it. Closes #2811. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2964 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-10 06:19:50 +00:00
Jeremy Kemper
adba181060 The auto_link text helper accepts an optional block to format the link text for each url and email address. References #2628. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2963 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-10 06:04:50 +00:00
Nicholas Seckar
c955f378de Fix sqlite adaptor's detection of missing dbfile or database declaration 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2962 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-10 00:16:23 +00:00
Nicholas Seckar
73a697c38a Don't detach or fork for script/server tailing 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2961 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-09 22:57:05 +00:00
David Heinemeier Hansson
c7e5c27b51 Added automatic browser launching on OS X when starting script/server [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2960 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-09 22:15:01 +00:00
David Heinemeier Hansson
5879a2e919 Changed all script/* to use /usr/bin/env ruby instead of hard-coded Ruby path. public/dispatcher.* still uses the hard-coded path for compatibility with web servers that dont have Ruby in path [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2959 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-09 21:15:41 +00:00
Jeremy Kemper
3661eacfbd Include all of session creation in stale_session_check 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2958 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-09 20:34:44 +00:00
David Heinemeier Hansson
773b869088 Another word on precedence (closes #2790) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2956 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-09 15:35:37 +00:00
David Heinemeier Hansson
5c48a89a7f Force RAILS_ENV to be "test" when running tests, so that ENV["RAILS_ENV"] = "production" in config/environment.rb doesnt wreck havok [DHH] (closes #2660) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2955 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-09 15:11:55 +00:00
David Heinemeier Hansson
6422f8b463 Increase criticality in comment for ENV["RAILS_ENV"] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2953 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-09 14:03:54 +00:00
Jamis Buck
b7ce9c5a87 assert_tag uses exact matches for string conditions, instead of partial matches. Use regex to do partial matches. #2799 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2952 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-09 13:42:05 +00:00
David Heinemeier Hansson
bc7ec23f4e Fixed acts_as_list for definitions without an explicit :order #2803 [jonathan@bluewire.net.nz] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2951 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-09 12:50:35 +00:00
Florian Weber
e6f412def3 Allow capital letters in the email address in the the validates_format_of example 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2950 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-09 10:38:48 +00:00
David Heinemeier Hansson
70521c8f59 Added note about precedence (closes #2790) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2949 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-09 08:37:17 +00:00
Jeremy Kemper
44591ffb71 r3886@sedna: jeremy | 2005-11-07 03:09:59 -0800 
r3944@sedna:  jeremy | 2005-11-09 01:29:56 -0800
 Upgrade bundled ruby-mysql 0.2.4 with mysql411 shim (see #440) to ruby-mysql0.2.6 with a patchset for 4.1 protocol support.  Local change [301] is now apart of the main driver; reapplied local change [2182].  Removed GC.start fromResult.free.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2947 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-09 06:43:40 +00:00
Jeremy Kemper
bb4c32e2b5 Delete existing sessions with the same session id before creating a new session. Prevents duplication and hijacking. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2946 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-09 06:00:46 +00:00
Leon Breedt
98ae24b967 Fix that XML-RPC date/time values did not have well-defined behaviour (#2516, #2534). This fix has one caveat, in that we can't support pre-1970 dates from XML-RPC clients. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2945 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-09 05:29:08 +00:00
Jeremy Kemper
0abaf3a2d8 CGI::Session::ActiveRecordStore.data_column_name = 'foobar' to use a different session data column than the 'data' default. References #2731. Remove error-prone method_missing passthrough to session model. Cleanup. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2944 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-09 01:03:24 +00:00
Jeremy Kemper
97f418ce02 Correct handling of complex order clauses with SQL Server limit emulation. Closes #2770. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2943 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-08 21:39:13 +00:00
Jeremy Kemper
86aaa6e988 Correct whitespace problem in Oracle default column value parsing. Closes #2788. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2942 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-08 19:11:25 +00:00
Jeremy Kemper
917189b076 Correct versioning in :freeze_gems Rake task. Closes #2778. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2941 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-08 10:43:40 +00:00
Jeremy Kemper
35b4bdcff0 Destroy associated has_and_belongs_to_many records after all before_destroy callbacks but before destroy. This allows you to act on the habtm association as you please while preserving referential integrity. Closes #2065. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2940 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-08 10:19:09 +00:00
Jeremy Kemper
c54b51fa7e Deprecate the old, confusing :exclusively_dependent option in favor of :dependent => :delete_all. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2939 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-08 08:41:34 +00:00
Jeremy Kemper
85baf07be8 Controllers with acronyms in their names (e.g. PDFController) require the correct default helper (PDFHelper in file pdf_helper.rb). Closes #2262. Do not raise an exception when default helper is missing; log a debug message instead. It's nice to delete empty helpers. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2938 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-08 08:23:13 +00:00
Jeremy Kemper
a90fdec031 More compatible Oracle column reflection. Closes #2771. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2935 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-08 04:37:22 +00:00
Jeremy Kemper
5298f730bb Add :order option to Author.posts_with_comments_and_categories so that tests which assume implicit id order pass with database which do not provide it. Scrubbed whitespace. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2934 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-08 04:36:37 +00:00