github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-02-19 02:14:20 -05:00
Code Issues Packages Projects Releases Wiki Activity
5,502 Commits 34 Branches 105 Tags
06dd4b3166d3b30264ac2f14f48e385e404d8ceb
Commit Graph

5502 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
David Heinemeier Hansson
06dd4b3166 Better failing tests 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7630 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-25 15:09:21 +00:00
David Heinemeier Hansson
55a9c86e62 Added failing tests for iphone 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7629 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-25 14:57:15 +00:00
Jeremy Kemper
3b98b68516 Doof. Don't call it with false if it doesn't respond. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7628 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-25 08:51:06 +00:00
Jeremy Kemper
14c1cb4bcb Skip test runner workaround only if Test::Unit is loaded. Closes #9671 [tomafro] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7627 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-25 08:44:26 +00:00
David Heinemeier Hansson
79a9c7a702 Added ActiveSupport::BufferedLogger as a duck-typing alternative (albeit with no formatter) to the Ruby Logger, which provides a very nice speed bump (inspired by Ezra's buffered logger) [DHH] Changed the default logger from Ruby's own Logger with the clean_logger extensions to ActiveSupport::BufferedLogger for performance reasons [DHH]. (You can change it back with config.logger = Logger.new(/path/to/log, level).) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7626 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-25 03:47:37 +00:00
David Heinemeier Hansson
501244fee4 Updated iphone_with_html_response_type to fail as it uses the new register_alias approach 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7625 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-24 23:44:36 +00:00
David Heinemeier Hansson
89235ba0bb Include the new 422 in the app generation 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7624 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-24 23:31:59 +00:00
David Heinemeier Hansson
bdf5672077 Change from InvalidToken to InvalidAuthenticityToken to be more specific 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7623 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-24 23:12:25 +00:00
David Heinemeier Hansson
e70bb8031f Stop rdoc from whining 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7622 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-24 23:01:50 +00:00
Jeremy Kemper
8e78a4542e Object#instance_exec produces fewer garbage methods. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7621 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-24 23:00:42 +00:00
David Heinemeier Hansson
eca3b790b5 Give a pointer on where to look for more 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7620 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-24 22:52:35 +00:00
David Heinemeier Hansson
959a1fc22d Added a default 422.html page to be rendered when ActiveRecord::RecordInvalid, ActiveRecord::RecordNotSaved, or ActionController::InvalidToken is raised [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7619 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-24 22:50:43 +00:00
Jeremy Kemper
dfcb5af2dc Move rescue_action_with_handler from rescue_action to perform_action so it isn't clobbered by test overrides. References #9449, closes #9645. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7618 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-24 19:56:11 +00:00
Jeremy Kemper
40f9fd39f6 Include asset host in public path cache key. Clear cache between asset tag tests. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7617 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-24 19:47:45 +00:00
Rick Olson
605aadb3cd protect new rails apps from csrf by default. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7616 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-24 18:11:59 +00:00
Michael Koziarski
fc042435a6 Fix ARes tests under jruby. [tom.enebo@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7615 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-24 18:01:09 +00:00
Rick Olson
2c73115b2f port over some of the csrf_killer README docs 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7614 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-24 17:59:17 +00:00
Rick Olson
2a60093fa3 Decode json strings as Dates/Times if they're using a YAML-compatible format. Closes #9614 [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7613 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-24 17:41:55 +00:00
David Heinemeier Hansson
911ea2f26f Beefed up docs a bit 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7612 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-24 17:02:02 +00:00
Jeremy Kemper
7f9a6c0d92 Cache computed public asset paths. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7611 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-24 09:18:30 +00:00
Jeremy Kemper
8db51ee3c0 Cache more file existence checks. Flip-flop escaping. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7610 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-24 08:26:04 +00:00
Jeremy Kemper
871b87a323 Cache file existence checks and the list of all stylesheet sources. Manually escape tag attributes. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7609 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-24 08:15:56 +00:00
Jeremy Kemper
4b33306c70 The tag helper may bypass escaping. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7608 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-24 08:13:55 +00:00
Jeremy Kemper
38454983b4 Cache asset ids. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7607 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-24 06:25:13 +00:00
Jeremy Kemper
e711d8fade escape_once uses negative lookahead to avoid double-escaping instead of a second gsub 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7606 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-24 05:43:59 +00:00
Jeremy Kemper
cb5b8a7f05 Optimized named routes respect AbstractRequest.relative_url_root. Closes #9612. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7605 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-23 22:52:57 +00:00
David Heinemeier Hansson
ab09984d4a Fix docs (closes #9570) [anshkakashi] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7604 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-23 22:42:19 +00:00
David Heinemeier Hansson
f0055871a3 Follow our own conventions (closes #6506) [packagethief] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7603 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-23 22:16:09 +00:00
David Heinemeier Hansson
2cfe118305 Dont need all of test/unit (closes #6673) [zenspider/josh] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7602 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-23 22:12:45 +00:00
David Heinemeier Hansson
906c49d0f3 Added --skip-fixture option to script/generate model (closes #6862) [sandofsky] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7601 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-23 22:08:02 +00:00
Jeremy Kemper
6580b3ab00 Remove , and ; (comma and semicolon) from routing separators again. References #8558. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7599 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-23 21:58:02 +00:00
David Heinemeier Hansson
7d9fe04b1d Fixed cache_page to use the request url instead of the routing options when picking a save path (closes #8614) [josh] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7598 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-23 21:56:52 +00:00
Jeremy Kemper
a6f49d9b78 Introduce ActionController::Base.rescue_from to declare exception-handling methods. Cleaner style than the case-heavy rescue_action_in_public. Closes #9449. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7597 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-23 21:56:22 +00:00
Rick Olson
c619003854 Rename some RequestForgeryProtection methods. The class method is now #protect_from_forgery, and the default parameter is now 'authenticity_token'. [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7596 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-23 18:14:44 +00:00
Rick Olson
da0725aae3 move TextHelper#sanitize config options to the TextHelper module so it can be included and used with any class, not just ActionView::Base 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7595 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-23 18:09:46 +00:00
Jeremy Kemper
ccc9549436 Revert [7574]. Closes #7521. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7594 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-23 11:31:37 +00:00
Jeremy Kemper
547447ad2a RailsFCGIHandler tests. Closes #9630. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7593 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-23 11:20:25 +00:00
Rick Olson
4e3ed5bc44 Merge csrf_killer plugin into rails. Adds RequestForgeryProtection model that verifies session-specific _tokens for non-GET requests. [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7592 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-23 02:32:55 +00:00
Jeremy Kemper
3dea8b580b Dispatcher tests. References #9630. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7591 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-23 02:11:44 +00:00
Jeremy Kemper
ea45680118 Object.subclasses_of includes anonymous subclasses. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7590 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-23 01:09:20 +00:00
Rick Olson
2d02199e15 Secure #sanitize, #strip_tags, and #strip_links helpers against xss attacks. Closes #8877. [Rick, lifofifo, Jacques Distler] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7589 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-23 00:11:08 +00:00
Jeremy Kemper
4965b1b961 Correctly quote id list for limited eager loading. Closes #7482. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7588 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-22 23:51:03 +00:00
David Heinemeier Hansson
f3bf372630 Test fix (closes #6911) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7587 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-22 23:26:22 +00:00
David Heinemeier Hansson
32b31a2d0d More tests (closes #7066) [sethladd] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7586 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-22 23:21:35 +00:00
David Heinemeier Hansson
82a85e8592 Skip svnindex.xsl files when installing plugins (closes #7070) [davidjrice] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7585 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-22 23:20:48 +00:00
David Heinemeier Hansson
5757fb61d8 self.fixture_class_names is defined twice in fixtures.rb (closes #7135) [jarkko] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7584 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-22 23:17:01 +00:00
David Heinemeier Hansson
0b2e059f0a Removed unnecessary or statement (closes #7158) [richcollins] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7583 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-22 23:15:54 +00:00
David Heinemeier Hansson
953de118db Improve tests (closes #7166) [zackchandler] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7582 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-22 23:12:24 +00:00
David Heinemeier Hansson
f0dc2774e8 Improve tests (closes #7240) [josh] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7581 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-22 23:11:45 +00:00
David Heinemeier Hansson
ee45d76df8 Roll back #7578, tests failed 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7580 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-09-22 23:10:41 +00:00