github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
17,897 Commits 34 Branches 105 Tags
072cd60379dfee830845f32cb81019584d619331
Commit Graph

17897 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Aaron Patterson
072cd60379 refactor if / else to ||= 2010-08-18 23:37:37 -07:00
Xavier Noria
5a1d957dce avoids warnings about mismatched indentations in Ruby 1.9.2 2010-08-19 03:44:55 +02:00
Xavier Noria
5914875e77 now for real, the suite loads everything and these went unpatched 2010-08-19 02:57:10 +02:00
Xavier Noria
eab4860e9b avoids a ton o warnings activesupport/lib/active_support/dependencies.rb:239: warning: loading in progress, circular require considered harmful ... activesupport/lib/active_support/core_ext/hash/indifferent_access.rb while running the suite in Ruby 1.9.2 2010-08-19 02:46:42 +02:00
Xavier Noria
c510f05967 get rid of the warning "+ after local variable is interpreted as binary operator even though it seems like unary operator" in Ruby 1.9.2 2010-08-19 02:08:28 +02:00
wycats
483b60b9ff Revert "It's snowing!" 
This reverts commit e4283007d6.
 2010-08-18 16:49:06 -07:00
Aaron Patterson
e4f424d577 refactoring to remove duplicate logic 2010-08-18 12:10:48 -07:00
Aaron Patterson
93f335b6fb call to present? is not necessary 2010-08-18 11:51:59 -07:00
Javier Martín
3e871eee80 Don't pluralize resource methods [#4704 state:resolved] 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-08-18 13:56:46 -03:00
Santiago Pastorino
cad8bef5ea Bump up rdoc to 2.5.10 2010-08-18 11:44:12 -03:00
Aaron Patterson
a197d1c874 run the AS tests in verbose mode 2010-08-17 17:21:52 -07:00
wycats
c6db3486c3 1.8 block variable shadowing strikes again 2010-08-17 16:51:35 -07:00
wycats
dbe08026e1 Sadly, this segv's in 1.8 :( 2010-08-17 16:51:35 -07:00
Andre Arko
fca617af14 Allow member actions (get, etc) to accept strings, with test 2010-08-17 20:41:13 -03:00
Xavier Noria
a0ca3d1067 Merge remote branch 'docrails/master' 2010-08-18 00:25:32 +02:00
Xavier Noria
23f6e51b69 commit review: now that there are two supported, just mention them 2010-08-18 00:16:39 +02:00
Xavier Noria
ea2ad26a8d you rarely want ^ or $ in validations, use \A when you mean \A 2010-08-18 00:15:01 +02:00
Matthew Mongeau
dd55830bb2 to_sentence should return a duplicate 2010-08-17 13:52:37 -07:00
Jeff Lawson
c017041e68 Bug Fix -- clean up connection after stored procedure [#3151 state:resolved] 2010-08-17 13:16:03 -07:00
Jeff Lawson
7ce1539934 Bug Fix -- clean up connection after stored procedure [#3151 state:resolved] 2010-08-17 13:15:58 -07:00
Sunny Ripert
c924068714 Testing Guide: rake test:uncommitted now supports git 2010-08-17 21:49:40 +02:00
Trey Bean
bee414748c Missing object for comparison in ActiveModel::EachValidator example code. 2010-08-17 12:51:13 -06:00
Xavier Noria
137e4e759a Merge remote branch 'docrails/master' 2010-08-17 13:28:33 +02:00
Xavier Noria
285690143e debugging guide: revises the section on debugging RJS 2010-08-17 13:19:00 +02:00
Luke Brown
95ecc08a30 Added an example and explaination for using an optional path scope for the locale 2010-08-17 09:48:12 +01:00
Josiah Ivey
9a665aa6d2 Debugging Guide: Highlight using config over ActionView::Base 2010-08-16 21:32:08 -05:00
Santiago Pastorino
f1b33f7f22 Restore pet -> owner relationship to the previous state 
[#5365]
 2010-08-16 22:46:55 -03:00
Mark Turner
6177a0be96 added testcase for belongs_to with a counter_cache and touch 
[#5365 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-08-16 22:41:12 -03:00
Peter Wagenet
ad53b68457 Class Attribute setter returns set value 
Signed-off-by: wycats <wycats@gmail.com>
 2010-08-16 18:36:12 -07:00
Xavier Noria
fb6b805620 code gardening: we have assert_(nil|blank|present), more concise, with better default failure messages - let's use them 2010-08-17 03:32:11 +02:00
Xavier Noria
d14e2987b5 the (public) routing DSL does not accept symbols for get|post|put|delete|match 2010-08-17 02:37:28 +02:00
Raimonds Simanovskis
c7dd49eb2a Replaced hardcoded SessionStore table creation SQL with calls to ActiveRecord adapter migration methods 
Otherwise hardcoded table creation SQL was failing on Oracle database
 2010-08-16 15:21:58 -07:00
Raimonds Simanovskis
4e3d220da3 added dependencies in Gemfile for running ActiveRecord tests with Oracle database 2010-08-16 15:21:54 -07:00
Santiago Pastorino
8010e4f476 assert_equal here 2010-08-16 19:09:23 -03:00
José Valim
6e41cfb4e9 annoted_source_code may return nil if an error happens during template compiling. 2010-08-16 14:11:42 -03:00
Josiah Ivey
2a55edc725 Debugging Guide: Improve grammar for the RJS section 2010-08-16 05:25:40 -05:00
wycats
aaec007292 Make sure apps upgrading from 2.3 get defaulted to UTF-8 (ht: parndt) 2010-08-15 16:31:24 -07:00
Xavier Noria
a1fdf402c0 routing guide: wildcard segments are quite flexible, go beyond the simple use case 2010-08-16 01:14:09 +02:00
Subba Rao Pasupuleti
54477c9848 select tags coerce the :selected option, options to strings before comparison [#5056 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-15 16:46:32 -03:00
Bryce Thornton
fd78bb7270 Allow for any possible TLD when using the :all option with the cookie session store. This works for subdomain.mysite.local, google.co.uk, google.com.au, etc. [#5147 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-15 16:42:02 -03:00
José Valim
ada8c66ba0 Improve routes task code and print the application as :to => RackApp. [#5338 state:resolved] 2010-08-15 16:36:12 -03:00
Mark Turner
99f3997520 make rake routes print the name of a Rack endpoint app [#5338 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-15 16:22:57 -03:00
Santiago Pastorino
2f9f0829c6 Object#returning has gone, it's already deprecated on 3-0-stable 2010-08-15 12:08:17 -03:00
Santiago Pastorino
3c8b50020a Revert "Makes AR use AMo to_key implementation" 
This reverts commit 36a84a4f15.
 2010-08-15 11:33:21 -03:00
José Valim
d0cf212cb5 to_key should return all exists keys (if any exists), regardless if the object is persisted or not. If you need it to reflect persistance, you should use to_param. 2010-08-15 11:29:15 -03:00
Mikel Lindsaar
fd9f3ad36b Making time_zone_options_for_select return a html_safe string 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-08-15 09:58:40 -03:00
Santiago Pastorino
1607a8b08c This is not needed anymore 2010-08-15 09:18:08 -03:00
Santiago Pastorino
2ad3d96cb0 recommended is the right word here 2010-08-15 08:44:14 -03:00
Santiago Pastorino
f939fb5e31 Makes use of class << self instead of def self. 2010-08-15 08:41:39 -03:00
Xavier Noria
331c5da7f0 getting started guide: typos reported by Abder-Rahman Ali 2010-08-15 13:03:05 +02:00