github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-02-08 05:05:04 -05:00
Code Issues Packages Projects Releases Wiki Activity
6,403 Commits 34 Branches 105 Tags
081eed352fb7c16cbe1a18e13d032aa3512b04cd
Commit Graph

422 Commits

Author SHA1 Message Date
Michael Koziarski
692dbbf793 Introduce a Template class to ActionView. Closes #11024 [lifofifo] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8805 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-06 04:26:40 +00:00
Jeremy Kemper
0da2aa6d11 Introduce the :index option for form_for and fields_for to simplify multi-model forms (see http://railscasts.com/episodes/75). Closes #9883. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8786 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-02 06:16:04 +00:00
Jeremy Kemper
9d79e0668d Fix number_to_human_size incorrectly removing trailing zeros. Closes #10099 [libc, developingchris] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8774 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-02 02:59:10 +00:00
Michael Koziarski
10aa728e8b Don't repeatedly add relative_url_root to asset sources. Closes #10767 [tomtoday, Koz] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8740 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-27 01:10:48 +00:00
Michael Koziarski
9f1fdcc27d Handle corner case with image_tag when passed 'messed up' image names. Closes #9018 [duncanbeevers, mpalmer] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8717 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-25 04:13:50 +00:00
Michael Koziarski
c0110a9faa Refactor template compilation from AV::Base into the template handlers. Closes #10888 [lifofifo] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8689 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-22 01:46:34 +00:00
Michael Koziarski
7701e6466d Add label_tag helper for generating elements. Closes #10802 [DefV] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8685 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-21 21:08:28 +00:00
Michael Koziarski
61c90a4ad6 Reapply the TemplateFinder first applied in [8669] then reverted in [8676]. Closes #10800 [lifofifo] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8683 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-21 20:45:04 +00:00
Jeremy Kemper
88bc014acc Revert r8669 for now, breaks Action Mailer. Reopens #10800. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8676 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-19 06:01:57 +00:00
Jeremy Kemper
84b0f9c739 Introduce TemplateFinder to handle view paths and lookups. Closes #10800. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8669 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-19 03:20:39 +00:00
Michael Koziarski
7e1c04d866 Allow users to declare other namespaces when using the atom feed helpers. Closes #10304 [david.calavera] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8637 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-13 00:11:39 +00:00
David Heinemeier Hansson
5d1a305f06 Fixed ActionView::Helpers::ActiveRecordHelper::form for when protect_from_forgery is used (closes #10739) [jeremyevans] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8626 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-11 16:25:23 +00:00
Michael Koziarski
e6de95889d * Pass around handler instances, not their classes [Koz] 
* Move compilation, rendering and 'compilable?' checks into the Handlers [Koz]
 * Remove delegate_* methods as the handler is now an instance [Koz]


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8624 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-11 04:45:06 +00:00
Jeremy Kemper
3600536b04 Ruby 1.9 compat: account for hash ordering 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8588 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-07 08:10:23 +00:00
Jeremy Kemper
a1b0349362 The asset_host block takes the controller request as an optional second argument. Example: use a single asset host for SSL requests. Closes #10549. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8578 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-06 20:53:23 +00:00
Jeremy Kemper
9d755f1983 require abstract_unit directly since test is in load path 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8564 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-05 13:32:06 +00:00
Rick Olson
744b1d7f4d Fix atom_feed_helper to comply with the atom spec. Closes #10672 [xaviershay] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8529 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-02 19:45:53 +00:00
Jeremy Kemper
001fe6a435 Fix failing date helper test. Closes #10664 [Wesley Moxam] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8526 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-02 18:09:52 +00:00
Rick Olson
58cf6df41a Fix that auto_link looks for ='s in url paths (Amazon urls have them). Closes #10640 [bgreenlee] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8506 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-28 20:59:30 +00:00
Jeremy Kemper
a81333f115 Add :default option to time_zone_select. Closes #10590. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8473 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-21 22:18:07 +00:00
Jeremy Kemper
0333190d1a Rails 1.9 compat: asset tag helper tests 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8470 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-21 12:26:51 +00:00
Jeremy Kemper
7630b38e22 Ruby 1.9 compat: compiled templates test 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8468 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-21 12:26:27 +00:00
Jeremy Kemper
79790df40c Ruby 1.9 compat: note failing form options helper test, probably in html-scanner 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8465 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-21 12:25:55 +00:00
Jeremy Kemper
a4c77f9bc4 Ruby 1.9 compat: text helper 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8464 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-21 11:51:17 +00:00
Jeremy Kemper
f16cd7220f Ruby 1.9 compat: ENV.delete rather than assigning nil 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8452 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-20 22:27:37 +00:00
David Heinemeier Hansson
d6859a7216 Add tests for html_escape, and remove an unneeded backslash (closes #10511) [fxn] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8422 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-16 23:53:45 +00:00
David Heinemeier Hansson
56e646296a Added option to pass proc to ActionController::Base.asset_host for maximum configurability (closes #10521) [chuyeow] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8421 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-16 23:50:02 +00:00
Jeremy Kemper
9aca06fbee More Action View refactoring. Knock :erb default down a notch. Closes #10455. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8374 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-10 23:14:47 +00:00
Jeremy Kemper
b1ce7e4d4a Ruby 1.9 compat: File.exists\? -> File.exist\? en masse. References #1689 [Pratik Naik] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8365 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-10 05:54:46 +00:00
Michael Koziarski
2eaa8e67c0 Remove Great Britain from the Country select helper to ensure consistency with iso 3166's long_names. Closes #6872 [Koz] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8277 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-05 05:55:26 +00:00
Rick Olson
112ed30316 Add 'disabled' attribute to <OPTION> separators used in time zone and country selects. Closes #10354 [hasmanyjosh] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8267 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-04 05:30:28 +00:00
Michael Koziarski
92f02adf40 Don't escape forward slashes with String#to_json, our unicode encoding of < and > prevent the XSS problems. [tpope] Closes #10273 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8255 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-02 08:45:35 +00:00
David Heinemeier Hansson
84ca7e6ef7 Deal with nested fields_for too [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8253 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-02 01:10:50 +00:00
David Heinemeier Hansson
d0ce7cd4c7 Added the same record identification guessing rules to fields_for as form_for has [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8252 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-02 00:46:43 +00:00
Rick Olson
1af084ecda Refactor sanitizer helpers into HTML classes and make it easy to swap them out with custom implementations. Closes #10129. [rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8213 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-26 03:45:54 +00:00
David Heinemeier Hansson
6b018e3d08 Added :mouseover short-cut to AssetTagHelper#image_tag for doing easy image swaps (closes #6893) [joost] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8110 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-11-07 15:37:06 +00:00
Rick Olson
c708346688 Change JSON to encode %w(< > &) as 4 digit hex codes to be in compliance with the JSON spec. Closes #9975 [josh, chuyeow, tpope] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8050 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-29 00:18:43 +00:00
Jeremy Kemper
a55caf666c Tested FormHelper#label. Closes #9850 [jarkko] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8045 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-27 20:30:05 +00:00
Rick Olson
d7aa32d5d0 Update tests for ActiveSupport's JSON escaping change. [rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8034 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-26 05:32:30 +00:00
Rick Olson
d5a93b6241 FormHelper's auto_index should use #to_param instead of #id_before_type_cast. Closes #9994 [mattly] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8033 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-26 04:48:19 +00:00
Jeremy Kemper
8091ed5420 Disabled checkboxes don't submit a form value. Closes #9301. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8007 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-23 19:25:28 +00:00
Marcel Molina
6f559f871e Added tests for options to ActiveRecordHelper#form. Closes #7213 [richcollins, mikong, mislav] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8005 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-23 17:57:47 +00:00
Jeremy Kemper
3334609ecb Expand form helper test coverage. Closes #9950 [robinjfisher] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7993 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-22 21:17:20 +00:00
Michael Koziarski
62fd6532e5 Remove more potential clashes with asset methods and resource routes. Closes #9928 [gbuesing] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7976 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-19 02:46:41 +00:00
Michael Koziarski
b1c3fc22c9 Rename image_path path_to_image to avoid conflicting with named routes. Closes #9924 [gbuesing] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7970 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-19 00:52:55 +00:00
Jeremy Kemper
cfe36d1609 Test link_to 'back', :back 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7933 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-16 05:06:55 +00:00
Michael Koziarski
3353b85b0e Sync country_select with ISO 3166 long names. Closes #6872 [abhay, mikong, ruben] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7904 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-15 06:52:00 +00:00
Jeremy Kemper
01cfda7cf2 error_messages_for also takes :message and :header_message options which defaults to the old "There were problems with the following fields:" and "<count> errors prohibited this <object_name> from being saved". Closes #8270. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7870 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-14 02:59:32 +00:00
David Heinemeier Hansson
6637f9069c Extracted sanitization methods from TextHelper to SanitizeHelper [DHH] Changed SanitizeHelper#sanitize to only allow the custom attributes and tags when specified in the call [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7825 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-10 17:35:10 +00:00
Michael Koziarski
074fe35b8a Add link_to :back which uses your referrer with a fallback to a javascript link. #7366 [eventualbuddha, tarmo] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7791 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-10-08 03:30:29 +00:00