github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
25,700 Commits 34 Branches 105 Tags
17bf04ff0dbb2f11dd7bc1a87df035a96f9432ef
Commit Graph

5234 Commits

Author SHA1 Message Date
Xavier Noria
b064614ffb Merge pull request #2419 from dmitriy-kiriyenko/drop_test_database_in_development_when_running_rake_db_drop 
When running "rake db:drop" also drop test database in development environment
 2011-10-24 05:35:06 -07:00
Vijay Dev
8698debcc2 Merge branch 'master' of github.com:lifo/docrails 2011-10-23 01:38:37 +05:30
Vijay Dev
1c1c3fc2c0 minor fixes in the composed_of doc 2011-10-22 23:53:52 +05:30
Greg Reinacker
f092be821d preserve decimal column attributes after migration 2011-10-21 17:30:39 -06:00
Prem Sichanugrist
f0be2cb192 Add some note on adding index to HABTM table 2011-10-20 17:15:28 -04:00
Prem Sichanugrist
d64e0955d0 Use new migration style in HABTM join table 
Yes, we're on Rails 3.1 now.
 2011-10-20 17:13:01 -04:00
Aaron Patterson
ee9d9fb5fa Merge pull request #3258 from ileitch/3-1-stable 
Postgres: Do not attempt to deallocate a statement if the connection is no longer active.
 2011-10-20 08:45:22 -07:00
Aaron Patterson
6a28c512e3 reset prepared statement when schema changes imapact statement results. fixes #3335 2011-10-18 11:20:13 -07:00
José Valim
7511f9794d Merge pull request #3340 from surfacedamage/exclude_destroy_in_all_blank_check 
Exclude _destroy parameter in :all_blank check (issue #2937)
 2011-10-17 11:15:58 -07:00
Aaron Christy
8510a0bb5a Exclude _destroy parameter in :all_blank check (issue #2937) 2011-10-17 13:29:11 -04:00
Mike Perham
3dbedd2823 Default timestamps to non-null 2011-10-14 21:09:53 -07:00
Vijay Dev
e759c8882a Merge branch 'master' of github.com:lifo/docrails 2011-10-14 22:21:40 +05:30
Christian Bäuerlein
c6f0461e89 Consider attempted action in exception message of ActiveRecord::StaleObjectError 2011-10-14 18:20:41 +02:00
Christian Bäuerlein
410fa4cf7c Includes stale record in StaleObjectError 2011-10-14 16:28:02 +02:00
David Heinemeier Hansson
85b64f98d1 Added ActiveRecord::Base.store for declaring simple single-column key/value stores [DHH] 2011-10-13 16:24:22 -05:00
Steve Bourne
e552fe16d4 change activerecord query conditions example to avoid 'type' as column name 
'Type' is a reserved column for STI.  Changed conditions example to
avoid using that column name as an example.  The example isn't
STI-related (and mentioning STI here is needless clutter), so changing
to avoid accidentally encouraging users to use 'type' as a column name
for other purposes.
 2011-10-12 10:46:08 -07:00
Joseph Palermo
c90e5ce779 Only use LOWER for mysql case insensitive uniqueness check when column has a case sensitive collation. 2011-10-09 13:14:07 -07:00
Jeremy Kemper
bedd6dcd43 Merge pull request #500 from cyril/patch-1 
Use quotes for command substitution
 2011-10-08 20:29:56 -07:00
Mark J. Titorenko
f41b58d3b2 use thread locals and an instance variable within QueryCache#BodyProxy to maintain appropriate linkage with AR database connection across threads 2011-10-07 10:05:51 +01:00
Aaron Patterson
3088d23647 Merge pull request #3232 from Juanmcuello/pg_prepared_statements 
Use the schema_search_path in prepared statements.
 2011-10-06 20:08:05 -07:00
Vijay Dev
33799c8fc3 Merge pull request #3203 from jrmehle/fix_clone_structure 
db:test:clone_structure if path to .sql file contains spaces or dashes
 2011-10-06 02:13:36 -07:00
Jeremy Kemper
999b7ed94d Transactional fixtures enlist all active database connections. 
You can use multiple databases in your tests without disabling transactional fixtures.
 2011-10-05 19:10:18 -07:00
Jon Leighton
2e9e647fee Raise an exception on unknown primary key inside AssociationReflection. 
An association between two models cannot be made if a relevant key is
unknown, so fail fast rather than generating invalid SQL. Fixes #3207.
 2011-10-05 20:21:21 +01:00
Jon Leighton
64747654ca Revert "Raise error on unknown primary key." 
This reverts commit ee2be435b1.
 2011-10-05 20:21:21 +01:00
Juan M. Cuello
cfc95d89ae Use the schema_search_path in prepared statements. 
To allow the use of prepared statements when changing schemas in
postgres, the schema search path is added to the sql key.
 2011-10-05 11:43:03 -03:00
Jon Leighton
ee2be435b1 Raise error on unknown primary key. 
If we don't have a primary key when we ask for it, it's better to fail
fast. Fixes GH #2307.
 2011-10-05 01:11:40 +01:00
Ben Woosley
88f60fd1a7 Changing rake db:schema:dump to run :environment as well as :load_config, as running :load_config alone will lead to the dumper being run without including extensions such as those included in foreigner and spatial_adapter. 
This reverses a change made here: 5df72a238e (L0L324)

I'm assuming here that :load_config needs to be invoked separately from :environment, as it is elsewhere in the file for db operations, if not the alternative is to go back to "task :dump => :environment do".

Signed-off-by: José Valim <jose.valim@gmail.com>
 2011-10-04 11:25:20 +02:00
Jared Mehle
80e0cd3290 Quoted path to <Rails.env>_structure.sql file in db:test:clone_structure task. 
Leaving the path unquoted causes errors in paths containing spaces or dashes.
 2011-10-03 14:50:40 -05:00
Jon Leighton
adb8ac153f Don't call self.class unless necessary. Closes #3171. 2011-09-29 18:00:30 +01:00
Dmitriy Kiriyenko
78de4fcd05 When running "rake db:drop" also drop test database in development environment. 2011-09-29 15:07:09 +03:00
Vijay Dev
33b55cfbdb Merge branch 'master' of github.com:lifo/docrails 2011-09-28 00:04:45 +05:30
Diego Plentz
aafd4c0452 fixing docs for delete_sql where quotes should be used in this example. 2011-09-26 20:06:17 -03:00
Jon Leighton
b3407c86cf Don't require a DB connection when setting primary key. 
Closes #2807.
 2011-09-26 18:15:09 +01:00
Jon Leighton
89e98e278a Merge pull request #3030 from htanata/fix_habtm_select_query_method 
Fix: habtm doesn't respect select query method
 2011-09-26 16:52:23 +01:00
Jon Leighton
3b87c38d02 Fix belongs_to polymorphic with custom primary key on target. 
Closes #3104.
 2011-09-26 15:42:34 +01:00
Jon Leighton
b838059817 CollectionProxy#replace should change the DB records rather than just mutating the array. Fixes #3020. 2011-09-26 10:41:58 +01:00
Vijay Dev
caa95ab6d8 Merge branch 'master' of github.com:lifo/docrails 2011-09-21 19:35:09 +05:30
Vijay Dev
ed1ada84ac copy edits 908f2616 2011-09-20 19:46:59 +05:30
José Valim
51bef9d8fb to_xml should also rely on serializable hash. 2011-09-18 09:09:01 -07:00
Ryan Bigg
908f2616d5 Document ActiveRecord::QueryMethods#select 2011-09-17 16:08:58 -07:00
Vijay Dev
49476eee78 Merge branch 'master' of github.com:lifo/docrails 2011-09-15 00:32:52 +05:30
Vijay Dev
dcd70773fc minor edit 2011-09-14 23:15:18 +05:30
Ryan Bigg
681c4dbb02 Add documentation for the extending method in ActiveRecord:QueryMethods 2011-09-14 09:43:31 +10:00
Jon Leighton
3b8a7cf2a7 Stop trying to be clever about when to define attribute methods. 
There is no meaningful performance penalty in defining attribute
methods, since it only happens once.

There is also no reason *not* to define them, since they get thrown in
an included module, so they will not 'overwrite' anything. In fact, this
is desirable, since it allows us to call super.
 2011-09-14 00:00:37 +01:00
Jon Leighton
55da28dd2f We don't need to build a set for DangerousAttributeError. 
We can just use method_defined? and private_method_defined?
 2011-09-14 00:00:37 +01:00
Erik Behrends
3777d4217b [:class_name] option in belongs_to should mention belongs_to and not has_one 2011-09-13 22:42:39 +03:00
Jon Leighton
11870117c6 Rename first_or_new to first_or_initialize. 
For consistency with find_or_initialize_by. Also remove first_or_build
alias.
 2011-09-13 19:09:01 +01:00
Jon Leighton
1a421ceccb Deprecate using method_missing for attributes that are columns. 
This shouldn't ever happen unless people are doing something
particularly weird, but adding a deprecation in case there are bugs not
caught by our tests.
 2011-09-13 00:03:09 +01:00
Jon Leighton
ac687ed651 Let Ruby deal with method visibility. 
Check respond_to_without_attributes? in method_missing. If there is any
method that responds (even private), let super handle it and raise
NoMethodError if necessary.
 2011-09-13 00:01:58 +01:00
Jon Leighton
eecfa84a90 Always generate attribute methods on the base class. 
This fixes a situation I encountered where a subclass would cache the
name of a generated attribute method in @_defined_class_methods. Then,
when the superclass has it's attribute methods undefined, the subclass
would always have to dispatch through method_missing, because the
presence of the attribute in @_defined_class_methods would mean that it
is never generated again, even if undefine_attribute_methods is called
on the subclass.

There various other confusing edge cases like this. STI classes share
columns, so let's just keep all the attribute method generation state
isolated to the base class.
 2011-09-13 00:01:58 +01:00