Łukasz Strzałkowski
18bcc548bf
Typo in class name
2010-08-05 05:28:39 +08:00
Aaron Patterson
ba9602b9e7
call to_a since we are not passing anything to all()
2010-08-04 14:22:20 -07:00
Aaron Patterson
906ef233e4
fisting indentation
2010-08-04 14:11:20 -07:00
Piotr Sarnacki
4da32babdf
Reload action_methods in AbstractController after defining new method.
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-08-04 14:45:55 -03:00
José Valim
87365272e9
Revert "If a file is in the load path, require it without its full path (in more places)"
...
Caused failures in ActionMailer test suite.
This reverts commit 963638aac8
2010-08-04 14:45:55 -03:00
Aaron Patterson
f316a851dd
do not pass AR objects to ARel
2010-08-04 08:44:35 -07:00
José Valim
19c77a0d2b
Revert "Put lib back on the autoload path"
...
This was causing engines/gems to eager load everything in lib. Another fix is comming soon.
This reverts commit 02a5842cd0
2010-08-04 14:16:18 +02:00
wycats
2498cdaf14
I'm unsure how cloning was working in Rails 3 before
2010-08-04 04:05:28 -07:00
wycats
963638aac8
If a file is in the load path, require it without its full path (in more places)
2010-08-04 03:21:37 -07:00
wycats
fbc40a4d94
Fix a subtle bug involving RAILS_ROOT
2010-08-04 03:20:56 -07:00
wycats
32d840d98a
Concernify SanitizeHelper and TextHelper so including TextHelper correctly include SanitizeHelper and extends its ClassMethods
2010-08-04 03:20:44 -07:00
wycats
bd1cf94a29
Add a fake UrlRewriter, since instantiating it in tests happens, but is basically crazysauce
2010-08-04 03:20:08 -07:00
wycats
d599e94e45
require_dependency should require using the normal mechanism if possible to avoid double-requires
2010-08-04 02:16:48 -07:00
wycats
91e4249c02
Provide a bit more information in the deprecation for config.gem
2010-08-04 02:15:15 -07:00
wycats
07c5e5416b
Shim Initializer.run
2010-08-04 01:07:23 -07:00
rohit
8158afa47e
Give extracted options back to args in AMo callbacks. Fixes two failing tests in AR.
...
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com >
2010-08-04 00:33:23 -03:00
Aaron Patterson
9269e55b1f
avoid passing AR::Base objects to Arel when we can
2010-08-03 17:57:59 -07:00
wycats
b46b5a6d54
Fix up constant deprecation to be less dependent on load order
2010-08-03 16:03:35 -07:00
wycats
46a1da7c79
Put lib back on the autoload path
2010-08-03 15:00:17 -07:00
RainerBlessing
8b7219b9d6
query value is converted to_s instead of to_yaml
2010-08-03 14:55:15 -07:00
wycats
109dc3c39c
Deprecate the @controller instance variable
2010-08-03 14:23:46 -07:00
wycats
af8e085190
Move the deprecations before the load hooks
2010-08-03 12:50:41 -07:00
wycats
146a013c42
Fix a couple of mistaken deprecation solutions
2010-08-03 12:50:13 -07:00
wycats
84703be5ff
Deprecate ActionController::UrlWriter properly
2010-08-03 12:41:18 -07:00
wycats
43cc69cb65
Fix the session= deprecation to include the secret key
2010-08-03 12:31:39 -07:00
wycats
01186652cc
Even though exempt_from_layout is no longer needed, some people are still using it. Deprecate it instead of removing.
2010-08-03 12:29:03 -07:00
wycats
7a1bba4799
Allow :name to be a Symbol (was this removed by accident?)
2010-08-03 12:22:10 -07:00
wycats
4474470ffd
update this for a change in the core method
2010-08-03 11:49:44 -07:00
wycats
9ae7f04cd6
properly deprecate #{type}_validation_on_#{on}
2010-08-03 11:48:06 -07:00
wycats
1318bf6e33
Properly deprecate validate_on_#{on}
2010-08-03 11:48:06 -07:00
Subba Rao Pasupuleti
5987fd4c79
Tidy up error.rb code
...
[#5288 state:committed]
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com >
2010-08-03 14:58:53 -03:00
Santiago Pastorino
677e1e58b6
Stub is_a? not instance_of? here
2010-08-03 12:20:11 -03:00
José Valim
3b170b2e14
Freeze options so we raise an error when people modify it in place.
2010-08-03 15:37:35 +02:00
José Valim
79583ca9b1
validates_length_of should not change the options hash in place. [ #5283 state:resolved]
2010-08-03 15:37:26 +02:00
rohit
257e9c4ec4
Failing test for validates_length_of, when both too_short and too_long messages are set [ #5283 state:open]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-08-03 15:37:17 +02:00
Samuel Lebeau
a44779e9bb
Avoid potentially expensive inspect call in router. [ #4491 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-08-03 12:03:45 +02:00
José Valim
503931df05
Merge branch 'master' into 3-0-stable
2010-08-03 10:55:09 +02:00
Curtis Cablegram
e1142dfcae
Refactor log-tailer to depend on File#eof? rather than File#mtime
...
[#5220 state:resolved]
Eliminate 1 instance variable and 1 local variable.
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-08-03 10:50:25 +02:00
Curtis Cablegram
1466f312ba
Change log-tailer to properly track multi-byte characters.
...
When end-of-line is represented within a file as "\r\n",
it is represented in memory as a single "\n". This patch eliminates
the discrepancy between size on disk and size in memory.
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-08-03 10:50:21 +02:00
Tore Darell
2c8a4a53a8
Remove or fix non-working examples and add a few tests to Dirty [ #5185 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-08-03 10:47:30 +02:00
Neeraj Singh
fb2b8fec24
adding test cases for ActiveModel::Errors
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-08-03 10:46:16 +02:00
Neeraj Singh
db1c484c55
Dynamic finder method like scoped_by_* create methods so that
...
method_missing is not hit next time. Adding a test for this
scenario.
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-08-03 10:46:09 +02:00
Neeraj Singh
807239f5a1
Making Active Record base_test.rb thinner by moving tests
...
to relevant files.
Number of assertions before refactoring:
2391 tests, 7579 assertions, 0 failures, 0 errors
Number of assertions after refactoring:
2391 tests, 7579 assertions, 0 failures, 0 errors
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-08-03 10:45:54 +02:00
wycats
f73e9d2df8
Properly deprecate config.load_paths and config.gem
2010-08-02 23:39:33 -07:00
Xavier Noria
4dc2521028
Merge remote branch 'docrails/master' into 3-0-stable
2010-08-03 02:15:12 +02:00
Neeraj Singh
db0e3e5ad1
Correcting the documentation which wrongly states that each dynamic finder creates
...
method on the class. Only dynamic finders using <tt>scoped_by_*</tt> creates new
methods.
2010-08-02 13:10:32 -04:00
Neeraj Singh
d3eacf9352
Adding to AR::Base documentation about dynamically scopeded_by query
...
User.scoped_by_user_name('David')
2010-08-02 13:07:18 -04:00
José Valim
88b5f938cf
Bring returning back to ease migration.
2010-08-02 18:40:20 +02:00
Neeraj Singh
1ce40ca562
ensuring that description does not exceed 100 columns
2010-08-02 12:25:26 -04:00
José Valim
9effe3cc18
Remove duplicated logic.
2010-08-02 17:20:17 +02:00
