github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
26,648 Commits 34 Branches 105 Tags
18bf30982bb2ec013dc65a7e7e65ff45fcd4d73b
Commit Graph

26648 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jon Leighton
18bf30982b Cache column defaults on model. ~30% on Model.new due to avoiding repeatedly fetching connection. 2011-12-14 16:14:47 +00:00
Jon Leighton
7b0edbb9f2 Avoid super; speeds up Model.new by about 12% 2011-12-14 16:14:47 +00:00
José Valim
e3a4eb4b40 Close the response body on cascade pass, closes #3975. 2011-12-14 17:03:35 +01:00
Jon Leighton
19bea9f1bd Stop the build asploding on 1.8.7 2011-12-14 15:31:12 +00:00
Jeremy Kemper
384a60a16c Merge pull request #3981 from choonkeat/master 
Fix url_for options[:subdomain] to allow objects as values
 2011-12-14 07:07:05 -08:00
Jon Leighton
bb44e5a80a Use a separate module for 'external' attribute methods. 2011-12-14 14:51:57 +00:00
choonkeat
5f67cfeda1 Fix url_for options[:subdomain] to allow objects as values 
* e.g. blog_url(subdomain: current_user) instead of blog_url(subdomain: current_user.to_param)
 2011-12-14 22:43:42 +08:00
Piotr Sarnacki
a5589db063 Merge pull request #3979 from kommen/dbconsole_db_config 
dbconsole: Use the app's database_configuration instead of duplicating loading code.
 2011-12-14 05:48:04 -08:00
Dieter Komendera
6cbe2709d6 dbconsole: Use the app's database_configuration instead of duplicating code. 2011-12-14 14:08:41 +01:00
Jon Leighton
665ef116ac Add return for 1.8.7 2011-12-14 11:11:12 +00:00
Jon Leighton
3ab49f87e4 Unfluff the CI. 
With transactional fixtures enabled, the session records would end up in
@_current_transaction_records, and at the end of the transaction,
methods would be called on them that would trigger method_missing and
trigger attribute methods to be generated.

However, at this point the sessions table would not exist, and the
columns were not cached, so an exception would be raised because we
can't find the columns to generate attribute methods for.

Not sure exactly why this didn't crop up before but there have been
changes to the schema cache code and perhaps that means that column data
that was cached previously at that point is now uncached.
 2011-12-14 11:05:00 +00:00
José Valim
f3531a8fc9 Clean up details keys before some tests to expire the cache. 2011-12-14 09:23:34 +01:00
Jon Leighton
38703ac897 Revert naive O(1) table_exists? implementation. 
It was a bad idea to rescue exceptions here. This can interfere with
transaction rollbacks which seems to be the cause of current CI
failure.

Instead, each adapter should implement its own DB-specific O(1)
implementation, and we fall back on the generic, slower, implementation
otherwise.
 2011-12-13 23:46:26 +00:00
Aaron Patterson
c7552d988e dup the details hash if a key has already been set for this object 2011-12-13 15:26:29 -08:00
Vijay Dev
74e46e5156 Merge branch 'master' of github.com:lifo/docrails 2011-12-14 02:13:23 +05:30
Vijay Dev
23bd340a48 copy edits 2011-12-14 02:08:40 +05:30
José Valim
5dc4868962 Merge pull request #3970 from lest/backtrace-when-silenced 
log exception backtrace when all backtrace lines silenced
 2011-12-13 11:43:13 -08:00
Sergey Nartimov
081431fdf1 log exception backtrace when all backtrace lines silenced 2011-12-13 22:32:39 +03:00
Aaron Patterson
ab802e72dc locale and default_locale may be the same, so uniq the array 2011-12-13 11:28:30 -08:00
Aaron Patterson
9d87a67590 stop freezing the details hash 2011-12-13 11:25:03 -08:00
Aaron Patterson
8b85e4a4a1 stop freezing hash value 2011-12-13 11:13:14 -08:00
Mikhail Dieterle
485e0249d2 typo in textile markup 2011-12-14 02:28:42 +08:00
José Valim
0f4da5b393 Fix failing AP tests. 2011-12-13 15:45:16 +01:00
José Valim
1668b900b5 Merge pull request #3963 from lest/logger-missing-require 
missing require in buffered logger
 2011-12-13 02:33:05 -08:00
José Valim
80256abb39 FileUpdateChecker should be able to handle deleted files. 2011-12-13 11:23:21 +01:00
lest
d060d6d131 missing require in buffered logger 2011-12-13 12:36:32 +03:00
José Valim
1f5b9bbdb3 Clean up FileUpdateChecker API. 2011-12-13 10:07:02 +01:00
José Valim
693d2be827 Move hooks back to initializers (we need an API that allows hooks to be replaced). 2011-12-13 09:29:18 +01:00
José Valim
cd3033eb62 Add config.file_watcher so developers can provide their own watchers (for instance, hooking on fsevents). 2011-12-13 09:29:18 +01:00
José Valim
148d15d824 Merge pull request #3958 from lest/comment-on-whitelist 
commented whitelist mode enforcement for mass assignment
 2011-12-12 23:57:02 -08:00
José Valim
f9df3ef845 Merge pull request #3960 from lest/activesupport-test-missing-require 
missing require in activesupport test
 2011-12-12 23:56:00 -08:00
José Valim
11aa167e23 Revert "Provide a unique point for running initializers." 
This reverts commit c2e3ce8d1e.

Conflicts:

	railties/lib/rails/application/configuration.rb
	railties/lib/rails/application/finisher.rb
	railties/lib/rails/engine.rb
 2011-12-13 08:52:52 +01:00
lest
8a9cf790db missing require in activesupport test 2011-12-13 10:33:58 +03:00
lest
f2fa4837a8 commented whitelist mode enforcement for mass assignment 2011-12-13 10:14:38 +03:00
Aaron Patterson
810837dda8 use Array#join so that file encoding doesn't impact returned string. 
Fixes #3957
 2011-12-12 19:45:16 -08:00
Piotr Sarnacki
3d4f913f77 Merge pull request #3950 from guilleiguaran/use-https-for-rubygems-in-apps 
Use rubygems https endpoint for the Gemfile on new apps
 2011-12-12 17:45:18 -08:00
Aaron Patterson
676092f761 logger adds a newline for us 2011-12-12 16:02:59 -08:00
Aaron Patterson
d12e6d0e2f use the schema cache when asking for the primary key 2011-12-12 15:59:44 -08:00
José Valim
400929fb44 Merge pull request #3943 from sferik/add_explicit_requires 
Include TagHelper but don't explicitly require it
 2011-12-12 14:11:16 -08:00
Erik Michaels-Ober
196407c54f Include TagHelper but don't explicitly require it 
Allow autoloading to work as intended and avoid multiple requires.
 2011-12-12 14:05:25 -08:00
José Valim
ffa8bfeed9 Merge pull request #3954 from bdurand/null_store_2 
Add ActiveSupport::Cache::NullStore for testing and development
 2011-12-12 14:03:50 -08:00
José Valim
fa1d9a884c Speed up development by only reloading classes if dependencies files changed. 
This can be turned off by setting `config.reload_classes_only_on_change` to false.

Extensions like Active Record should add their respective files like db/schema.rb and db/structure.sql to `config.watchable_files` if they want their changes to affect classes reloading.

Thanks to https://github.com/paneq/active_reload and Pastorino for the inspiration. <3
 2011-12-12 22:54:04 +01:00
José Valim
62cda03fa8 Provide a dir => extension API to file update checker. 2011-12-12 22:54:04 +01:00
Aaron Patterson
b04e2d86df strip whitespace errors from the generated Gemfile 2011-12-12 13:46:16 -08:00
Brian Durand
04d5eae4e8 Add ActiveSupport::Cache::NullStore to expose caching interface without actually caching for development and test environments. 2011-12-12 13:40:29 -06:00
José Valim
ede647a505 Allow reloader to be configured. 2011-12-12 19:41:17 +01:00
José Valim
9a51053c1d Update checker returns a boolean if callback was executed or not. 2011-12-12 19:41:17 +01:00
Guillermo Iguaran
f8fa383531 Use rubygems https endpoint for the Gemfile on new apps 2011-12-12 12:37:37 -05:00
Santiago Pastorino
2fdc3ab0f1 Merge pull request #3948 from sferik/use_https_rubygems_source 
Use HTTPS rubygems source
 2011-12-12 09:31:19 -08:00
clst
2be6df693a changed :finder_sql example to select * 
because with select p.* you can no longer use count(). Using count will result in an SQL error message.
 2011-12-12 18:27:51 +01:00