Commit Graph

1375 Commits

Author SHA1 Message Date
David Heinemeier Hansson
1bb676b6c0 Fixed problem with eager loading when using a has_and_belongs_to_many association using :association_foreign_key #1504 [flash@vanklinkenbergsoftware.nl]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1516 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-26 04:49:52 +00:00
David Heinemeier Hansson
e15207f497 Added help text for WEBrick #1508 [courtney]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1515 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-26 04:45:30 +00:00
Jamis Buck
c6ea1d360c RoutingError should show 404.html when in public #1503 [Ulysses]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1513 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-25 19:05:44 +00:00
Leon Breedt
1b07366c2f add RDoc for base signature types
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1512 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-25 18:57:33 +00:00
Leon Breedt
07f237bdae clean up cases where we override #inherited
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1511 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-25 18:06:52 +00:00
David Heinemeier Hansson
302c23d5a6 Fixed Base#find to honor the documentation on how :joins work and make them consistent with Base#count #1405 [pritchie@gmail.com] Improved dynamic finder docs #1495 [laurel@gorgorg.org]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1510 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-25 11:47:37 +00:00
David Heinemeier Hansson
3eed3272d7 Fixed that validations didn't respecting custom setting for too_short, too_long messages #1437 [Marcel Molina]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1509 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-25 11:24:43 +00:00
David Heinemeier Hansson
55850818e3 Fixed rakefile actions against PostgreSQL when the password is all numeric #1462 [michael@schubert.cx]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1508 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-25 11:19:47 +00:00
David Heinemeier Hansson
a995f42be0 Added tests for whiny nil #1476 [court3nay/marcel]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1507 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-25 11:15:38 +00:00
David Heinemeier Hansson
f16e0ec3eb Fixed ActionMailer generated tests to work properly after quoted refactoring #1481 [patrick@lenz.sh]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1506 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-25 11:02:17 +00:00
David Heinemeier Hansson
6f6c6b8bcb Updated assert_generates/routing to the new Routes code #1498 [Rick Olson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1505 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-25 10:58:44 +00:00
David Heinemeier Hansson
deda0ee4a8 Fixed that clear_association_cache doesn't delete new associations on new records (so you can safely place new records in the session with Action Pack without having new associations wiped) #1494 [cluon]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1504 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-25 10:56:20 +00:00
David Heinemeier Hansson
e4ccbf28c8 Fixed prototype to consider all fields it doesn't know as text (such as Safari's search) just like the browser in its serialization #1497 [Sean Treadway]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1503 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-25 10:48:28 +00:00
Jamis Buck
17928b7347 Eliminate a "string literal in condition" warning from some routes
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1502 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-25 09:20:38 +00:00
Leon Breedt
ebb6fb0928 fix WSDL generation, change the way protocols are instantiated, and add
the ability to override the namespace used in WSDL instead of always forcing
'urn:ActionWebService'


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1501 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-25 06:27:39 +00:00
Jamis Buck
af33a6a6b1 Fix problem with symbol/string mismatch on some routes
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1500 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-24 22:15:45 +00:00
Jeremy Kemper
bb6b14b04f Increased accuracy of 1.year by accounting for leap years. The time extensions are not meant to be super-precise but this seems worth it since otherwise you lose a lot of days doing 40.years.ago. Closes #1488 [tuxie@dekadance.se]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1499 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-24 20:42:16 +00:00
Jeremy Kemper
c8e2cf3ed0 Pass association finder arguments through to the association class exactly as we received them. Fixes case where parent.children.find() is interpreted as Child.find([]) instead of Child.find().
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1498 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-24 20:23:38 +00:00
Jeremy Kemper
28012e68fe Fix routes generation for unit tests. #1434
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1497 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-24 17:48:14 +00:00
David Heinemeier Hansson
8e56f5ea3e Improved performance of Routes generation by a factor of 5 #1434 [Nicholas Seckar] Added named routes (NEEDS BETTER DESCRIPTION) #1434 [Nicholas Seckar]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1496 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-24 16:40:01 +00:00
Jeremy Kemper
540d005ca5 Improved AbstractRequest documentation. Closes #1483.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1494 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-24 14:43:15 +00:00
Jamis Buck
3b4eb7aece Allow specific "multipart/xxx" content-type to be set on multipart messages #1412 [Flurin Egger]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1493 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-24 12:15:45 +00:00
Jamis Buck
0d8455c1a2 ActionMailer::Base subclasses are reloaded with other rails components #1262
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1492 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-24 11:57:40 +00:00
David Heinemeier Hansson
0c3298f2f2 Added ActionController::Base.allow_concurrency to control whether the application is thread-safe, so multi-threaded servers like WEBrick knows whether to apply a mutex around the performance of each action. Action Pack and Active Record are by default thread-safe, but many applications may not be. Turned off by default.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1487 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-23 06:56:12 +00:00
David Heinemeier Hansson
413d10ceec Fixed new WEBrick handling to actually pass parameters
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1483 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-22 15:03:29 +00:00
David Heinemeier Hansson
4e0ffab8b0 Removed the mutex from the WEBrick adapter under the production environment so concurrent requests can be served
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1482 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-22 12:59:36 +00:00
Jamis Buck
ce44079818 Missing parameter for trap_handler in dispatch.fcgi
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1481 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-22 11:26:00 +00:00
Jamis Buck
64e61348e5 Updated changelog for [1479]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1480 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-22 11:20:39 +00:00
Jamis Buck
f69f384872 Refactored dispatch.fcgi. Added unit tests for dispatch.fcgi. Added trap to recognize HUP as a graceful termination command.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1479 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-22 11:18:01 +00:00
Jamis Buck
053cb22c17 Use the real charset for parts generated by a template, instead of the string "charset".
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1478 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-22 10:12:06 +00:00
David Heinemeier Hansson
2694b8cf27 Added a migration generator
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1477 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-22 10:09:01 +00:00
Jamis Buck
996fa1526d Unquoted @ chars in received email headers are parsed properly in spite of RFC 822 (#1206)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1476 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-22 09:59:14 +00:00
David Heinemeier Hansson
1d4d721782 Fixed docs #856
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1475 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-21 17:11:01 +00:00
David Heinemeier Hansson
8e56e09018 Updated documentation for partials #1171
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1474 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-21 16:59:04 +00:00
David Heinemeier Hansson
964a477340 Include Routing tests in rake run #1287
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1473 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-21 16:39:28 +00:00
David Heinemeier Hansson
817744a725 Added an exception if calling id on nil to WhinyNil #584 [kevin-temp@writesoon.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1472 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-21 16:36:40 +00:00
David Heinemeier Hansson
a9fd639adf Fixed that calling Model.find([]) returns [] and doesn't throw an exception #1379
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1471 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-21 16:36:18 +00:00
Jamis Buck
361be5a7dd Removed the AR::Recursion module--it broke more code than it fixed
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1470 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-21 12:58:27 +00:00
David Heinemeier Hansson
c88ce04662 changelog message
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1466 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-21 07:18:31 +00:00
David Heinemeier Hansson
c608ebeade Added TextHelper#word_wrap(text, line_length = 80) #1449 [tuxie@dekadance.se]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1465 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-21 07:16:11 +00:00
David Heinemeier Hansson
e59bfc8519 Added a fall-through action for form_remote_tag that'll be used in case Javascript is unavailable #1459 [Scott Barron]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1464 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-21 07:08:13 +00:00
David Heinemeier Hansson
1e0d9a642f Added :xhr => true/false option to verify so you can ensure that a request is coming from an Ajax call or not #1464 [Thomas Fuchs]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1463 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-21 07:02:30 +00:00
David Heinemeier Hansson
6c8d354b8d Added Fix/Bignum#multiple_of? which returns true on 14.multiple_of?(7) and false on 16.multiple_of?(7) #1464 [Thomas Fuchs] Added even? and odd? to work with Bignums in addition to Fixnums #1464 [Thomas Fuchs]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1462 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-21 07:00:28 +00:00
David Heinemeier Hansson
b69199c1da Fixed that mailer generator generated fixtures/plural while units expected fixtures/singular #1457 [Scott Barron]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1461 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-21 06:54:04 +00:00
David Heinemeier Hansson
bc6570dfcb Added tag_options as a third parameter to AssetHelper#auto_discovery_link_tag to control options like the title of the link #1430 [kevin.clark@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1460 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-21 06:52:05 +00:00
David Heinemeier Hansson
f2a021dc06 Added option to pass in parameters to CaptureHelper#capture, so you can create more advanced view helper methods #1466 [duane.johnson@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1459 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-21 06:43:14 +00:00
David Heinemeier Hansson
0bdd44acca Make migrations work with the latest SQLite
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1458 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-21 06:00:17 +00:00
David Heinemeier Hansson
aa49feb588 Proper order in test #1329
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1457 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-21 05:58:42 +00:00
David Heinemeier Hansson
5ba31b3d1d Changed the default name of the input tag generated by FormTagHelper#submit_tag from "submit" to "commit" so it doesnt clash with form.submit() calls in Javascript #1271
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1456 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-21 05:26:40 +00:00
David Heinemeier Hansson
9113aa2744 Forgot to actually add the whiny nil
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1455 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-20 11:15:46 +00:00