Aaron Patterson
1d96d44da3
passing the ast to a table when the relation is a table
2010-12-07 18:54:04 -08:00
Aaron Patterson
d98cb5153d
JoinDependency is always created with an AST now
2010-12-07 17:05:15 -08:00
Aaron Patterson
2d9d6cd4c2
passing the ast to JoinDependency
2010-12-07 16:48:59 -08:00
Aaron Patterson
d6133209ce
arel is lazy about column information, so no need to pass it around
2010-12-07 15:25:16 -08:00
Aaron Patterson
ddbd203961
reduce string objects, reduce method calls
2010-12-07 15:25:16 -08:00
Pavel Gorbokon
1ce9b73e5c
Replace nested ifs with case/when
...
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com >
2010-12-07 20:56:10 -02:00
Pavel Gorbokon
4c4c7a272f
Ommit nil in method call
...
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com >
2010-12-07 20:55:39 -02:00
Aaron Patterson
ef79658bd1
save the AR reference rather than delegating
2010-12-07 14:47:21 -08:00
Aaron Patterson
70ab450274
cleaning up custom_join_sql method
2010-12-07 14:01:37 -08:00
Santiago Pastorino
7c920631ec
Test using default option as symbol added for human_attribute_name
2010-12-05 13:26:14 -02:00
Santiago Pastorino
33b0a30fcc
default could be a symbol here so attribute.to_s.humanize should be the final option
2010-12-05 12:57:45 -02:00
Santiago Pastorino
20ba81e47d
We can use the keys of the @attributes hash here and avoid a method call
2010-12-05 12:44:17 -02:00
Santiago Pastorino
c4809d9984
use map instead of each
2010-12-05 12:44:14 -02:00
Santiago Pastorino
3ab98cf6e0
If default is provided don't add attribute.to_s.humanize to the options
2010-12-05 12:36:56 -02:00
Santiago Pastorino
0dbf4ac709
Test falling back to default added for human_attribute_name
2010-12-05 12:36:53 -02:00
Santiago Pastorino
b870d67290
Test using default option added for human_attribute_name
2010-12-05 12:36:51 -02:00
Xavier Noria
48386d245b
Merge branch 'master' of git://github.com/lifo/docrails
2010-12-05 10:33:50 +01:00
Carlos Antonio da Silva
e1d0d5ae81
Fix mime type doc typos
2010-12-04 22:40:05 -02:00
Santiago Pastorino
b696dd70db
Allow back passing :rescue_format => nil and test added
2010-12-04 20:08:23 -02:00
Santiago Pastorino
be4551f63b
Use ||= here
2010-12-04 19:01:00 -02:00
Santiago Pastorino
a11ddf3ee2
Fix indentation here
2010-12-04 17:50:02 -02:00
Santiago Pastorino
3e84255942
attributes_before_type_cast are just the value of @attributes
2010-12-04 17:49:37 -02:00
Sven Fuchs
896e25e994
Make TranslationHelper#translate use the :rescue_format option in I18n 0.5.0
...
Don't catch exceptions here. Instead only declare that we want exceptions to be rescued as :html, but also let users configure reactions to exceptions in I18n.
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-12-04 18:00:52 +01:00
Sven Fuchs
7ffd5daa7f
bump i18n gem
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-12-04 18:00:31 +01:00
Ryan Bigg
c4669d3c02
Config guide: continuing work on documenting the initializers
2010-12-04 11:27:17 +11:00
Aaron Patterson
a299fcaef9
not a responsibility for rails to test
2010-12-03 16:22:42 -08:00
Aaron Patterson
d21f38aaa2
use the columns hash for primary key lookup
2010-12-03 15:33:59 -08:00
Aaron Patterson
399730bdd2
removing unused setup
2010-12-03 12:00:09 -08:00
Aaron Patterson
47737681fd
in the middle of refactoring
2010-12-03 12:00:09 -08:00
José Valim
226ea0e9e8
Wrap everything in class << self.
2010-12-03 13:27:43 +01:00
José Valim
78afe68afb
Merge remote branch 'joshk/redirect_routing'
...
Conflicts:
actionpack/CHANGELOG
actionpack/lib/action_controller/metal/mime_responds.rb
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-12-03 12:27:50 +01:00
Ryan Bigg
30bcdff405
Config guide: begin documenting the initializers
2010-12-03 19:16:25 +11:00
Ryan Bigg
b800125ae8
Config guide: Add javascript_expansions and stylesheet_expansions
2010-12-03 18:06:02 +11:00
Ryan Bigg
04779fbadd
Config guide: should use config.action_dispatch.tld_length to set the TLD
2010-12-03 17:34:34 +11:00
Ryan Bigg
e600f84208
Config guide: Add cache_asset_ids
2010-12-03 17:28:51 +11:00
Ryan Bigg
79b14407ad
Config guide: add tld_length to ActionDispatch section
2010-12-03 17:26:40 +11:00
Ryan Bigg
7f1c794a11
Remove extra f
2010-12-03 13:29:02 +11:00
Ryan Bigg
1304c92b68
Config guide: Mention ActionDispatch::Callbacks methods: before, to_prepare and after
2010-12-03 13:05:58 +11:00
Ryan Bigg
4d11af2e8f
Config guide: clarify what cache_store defaults to.
2010-12-03 12:16:08 +11:00
Ryan Bigg
2e021ef477
Clarify that preload_frameworks defaults to nil
2010-12-03 11:57:42 +11:00
Aaron Patterson
9a3e29e126
remove calls to deprecated methods
2010-12-02 15:56:55 -08:00
Aaron Patterson
b0fc912f1b
avoid deprecate api
2010-12-02 15:50:34 -08:00
Aaron Patterson
8c9b5e413f
removing more calls to deprecated methods
2010-12-02 15:07:01 -08:00
Aaron Patterson
ead0c6eed3
removing more calls to deprecated methods
2010-12-02 15:07:00 -08:00
Aaron Patterson
12b9920a15
removing calls to deprecated methods
2010-12-02 15:07:00 -08:00
Aaron Patterson
9f0133fbf4
refactor self.class to a variable
2010-12-02 15:07:00 -08:00
Santiago Pastorino
ae35a36afc
:method: is not needed when RDoc can detect it
2010-12-02 20:31:06 -02:00
Santiago Pastorino
21eadc1b3f
Base#[] and Base#[]= are aliases so implement them as aliases :)
2010-12-02 20:28:28 -02:00
Santiago Pastorino
42c51b8527
Doesn't need to sort, lets users of attribute_names sort them if they want
2010-12-02 20:28:24 -02:00
Aaron Patterson
6673d88f6f
avoiding deprecated methods in arel
2010-12-02 14:02:52 -08:00