github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
21,116 Commits 34 Branches 105 Tags
1f2e7214aaed01f50be12017f0ffbf9fcdbdbb5e
Commit Graph

21116 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Aaron Patterson
1f2e7214aa make sure string keys are always looked up from the class cache 2011-03-02 10:11:28 -08:00
Aaron Patterson
9198372421 Ruby 1.8: Y U NO FUN? 2011-03-02 09:43:27 -08:00
Aaron Patterson
dd41387f34 use newer class cache api 2011-03-02 09:35:10 -08:00
Aaron Patterson
69e348013b adding deprecation noticies to deprecated class cache methods 2011-03-02 09:31:40 -08:00
Aaron Patterson
66245441d4 adding backwards compat for class cache references. <3<3 2011-03-02 09:18:05 -08:00
Cheah Chu Yeow
2ee5555744 Fix Action caching bug where an action that has a non-cacheable response always renders a nil response body. It now correctly renders the response body. 
Note that only GET and HTTP 200 responses can be cached.

[#6480 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2011-03-02 13:11:07 -02:00
Dalibor Nasevic
e4cf28f3a0 Fixed typos in asset_host_test 
[#6501 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2011-03-02 12:48:33 -02:00
Aaron Patterson
f345e2380c yo dawg, directly use the class cache rather than the cache of the cache 2011-03-01 17:43:45 -08:00
Aaron Patterson
7b6bfe84f3 refactor Reference to a ClassCache object, fix lazy lookup in Middleware so that anonymous classes are supported 2011-03-01 17:20:35 -08:00
Aaron Patterson
50ed1a25a4 initialize ivars 2011-03-01 17:20:35 -08:00
Alexander Uvarov
24faddd60c Move ActiveModel::AttributeMethods#attribute_methods_generated? to ActiveRecord, so it's flexible now 
[#6428 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2011-03-01 20:22:45 +01:00
Aaron Patterson
fd26afc93b Enumerable gives us include?, so remove include? 2011-03-01 10:21:44 -08:00
Aaron Patterson
648fd60ecf prefer composition over inheritance with AD::MS 2011-03-01 10:14:09 -08:00
Aaron Patterson
e477fc1147 fixing test case test on 1.9.3dev 2011-03-01 10:14:09 -08:00
Sam Elliott
9cf3b1f671 Remove warnings about redefined test methods 
[#6490 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2011-03-01 12:39:04 -02:00
Aaron Patterson
46bb424287 Revert "compute ext in initialize, and use an attr_reader" 
This reverts commit 2dbb73bdda.

Conflicts:

	actionpack/lib/action_dispatch/middleware/static.rb
 2011-02-28 19:47:09 -08:00
Aaron Patterson
f279422e33 no need to pass a regex to Regexp.compile 2011-02-28 18:03:06 -08:00
Aaron Patterson
2dbb73bdda compute ext in initialize, and use an attr_reader 2011-02-28 17:54:00 -08:00
Aaron Patterson
c563f71e53 Merge branch 'fuuu' 
* fuuu:
  Move JoinDependency and friends from ActiveRecord::Associations::ClassMethods to just ActiveRecord::Associations
  Rewrote AssociationPreload.
 2011-02-28 17:13:39 -08:00
Aaron Patterson
54fdd33f33 use a subclass of AS::TZ for testing html output 2011-02-28 16:30:14 -08:00
Aaron Patterson
19c763f783 reduce two method calls per request, 1 to method_missing and one to send 2011-02-28 15:47:25 -08:00
Jon Leighton
b171b9e73d Move JoinDependency and friends from ActiveRecord::Associations::ClassMethods to just ActiveRecord::Associations 2011-02-28 22:12:43 +00:00
Jon Leighton
d90b4e2615 Rewrote AssociationPreload. 2011-02-28 22:12:34 +00:00
Josh Kalderimis
7112cf5e02 Updated the AS guides with some information on the difference between Date.today and Date.current. 2011-02-28 14:05:49 -08:00
Josh Kalderimis
0f8d2794f2 updated Time, Date and DateTime current methods in AS to use Time.zone and not Time.zone_default. 
[#6410 state:committed]
 2011-02-28 14:05:49 -08:00
Xavier Noria
de9713186d revises a few details in public/index.html 2011-02-28 20:03:40 +01:00
Ben Orenstein
726599df98 Remove redundant to_sym call. 
[#6483 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2011-02-28 16:43:12 -02:00
Aaron Patterson
a8dae084c9 skip this on oracle 2011-02-28 09:15:19 -08:00
Oriol Gual and Josep M. Bach
f42562f97b Make ActiveSupport::Configurable work with modules 
[#6486 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2011-02-28 13:30:32 -02:00
Diego Carrion
a0629927b2 added activesupport/test/tmp to gitignore 
[#6484 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2011-02-28 13:14:16 -02:00
Santiago Pastorino
53b17e9ad0 javascript_include_tag shouldn't raise if you register an expansion key with nil value 2011-02-28 11:52:00 -02:00
Santiago Pastorino
801e314006 Add tests for register expansion methods with key = [] 2011-02-28 11:30:12 -02:00
Santiago Pastorino
a00bed0c48 Revert "Properly interpolate i18n keys in modules [#5572 state:resolved]" 
This breaks #6448, you should use :"module/class" as key for namespacing
[#6448 state:committed]

This reverts commit 8d30193b08.
 2011-02-27 21:30:03 -02:00
Santiago Pastorino
acf0688fdd failing test for i18n key collision with namespaced models 2011-02-27 21:23:52 -02:00
Jeff Kreeftmeijer
86ad8a6c87 Make sure the Thor generator LoadError does not output --dev twice [#6431 state:resolved] 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2011-02-27 18:53:18 -02:00
Aaron Patterson
f3e9cbc695 use an attribute rather than a SQL literal 2011-02-26 16:05:15 -08:00
Aaron Patterson
54a2bf6601 removing limits and offsets from COUNT queries unless both are specified. [#6268 state:resolved] 2011-02-25 15:38:59 -08:00
Aaron Patterson
8fc54a2e81 only take the limit if there is a limit to take 2011-02-25 14:24:05 -08:00
Xavier Noria
2e60b00788 Merge branch 'master' of git://github.com/lifo/docrails 2011-02-25 20:53:55 +01:00
Prem Sichanugrist
515ea955b6 Always use ActionDispatch::ShowExceptions middleware [#6462 state:resolved] 
This will make sure the application will raise `ActionController::RoutingError` in case "X-Cascade: pass" header was set, usually when there's no route match.
 2011-02-25 10:03:53 -08:00
Prem Sichanugrist
439a74520d Make sure that we set env["action_dispatch.show_exceptions"] 
This has been used by `show_exception` middleware even the setting wasn't get passed to `env` hash.
 2011-02-25 10:03:40 -08:00
Vijay Dev
287bb6990c standardize all shell commands with the $ prefix 2011-02-25 02:59:37 +05:30
Eric Allam
13547c16d9 fixes: ActiveRecord::Base.scopes includes all scopes defined in all subclasses 2011-02-24 11:17:06 -08:00
Josep M. Bach
55105c4318 Fix missing inheritance from AR::Base in docs 2011-02-24 10:00:09 +01:00
Aaron Patterson
5f1fc0c8ac observers leak across tests, so rather than modify the object, we should just count the number of times the observer was called 2011-02-23 16:04:01 -08:00
Vinicius Baggio
e8a578224f Removing redundant File.expand_path from generators test 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2011-02-23 19:42:51 +01:00
Rodrigo Navarro
0b2412978f Fixing wrong class name. 2011-02-23 10:23:01 -08:00
Rodrigo Navarro
29399e00c9 ActiveModel::Validator#validate must receive have a record parameter. 2011-02-23 10:22:03 -08:00
Kamal Fariz Mahyuddin
6ba8caf3ee Fix observer callbacks firing multiple times on descendant instances 2011-02-22 16:25:19 -08:00
José Valim
3265bbb659 Fix tests on 1.8. 2011-02-22 22:51:02 +01:00