Commit Graph

5485 Commits

Author SHA1 Message Date
Rick Olson
2a60093fa3 Decode json strings as Dates/Times if they're using a YAML-compatible format. Closes #9614 [Rick]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7613 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-24 17:41:55 +00:00
David Heinemeier Hansson
911ea2f26f Beefed up docs a bit
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7612 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-24 17:02:02 +00:00
Jeremy Kemper
7f9a6c0d92 Cache computed public asset paths.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7611 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-24 09:18:30 +00:00
Jeremy Kemper
8db51ee3c0 Cache more file existence checks. Flip-flop escaping.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7610 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-24 08:26:04 +00:00
Jeremy Kemper
871b87a323 Cache file existence checks and the list of all stylesheet sources. Manually escape tag attributes.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7609 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-24 08:15:56 +00:00
Jeremy Kemper
4b33306c70 The tag helper may bypass escaping.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7608 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-24 08:13:55 +00:00
Jeremy Kemper
38454983b4 Cache asset ids.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7607 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-24 06:25:13 +00:00
Jeremy Kemper
e711d8fade escape_once uses negative lookahead to avoid double-escaping instead of a second gsub
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7606 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-24 05:43:59 +00:00
Jeremy Kemper
cb5b8a7f05 Optimized named routes respect AbstractRequest.relative_url_root. Closes #9612.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7605 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-23 22:52:57 +00:00
David Heinemeier Hansson
ab09984d4a Fix docs (closes #9570) [anshkakashi]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7604 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-23 22:42:19 +00:00
David Heinemeier Hansson
f0055871a3 Follow our own conventions (closes #6506) [packagethief]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7603 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-23 22:16:09 +00:00
David Heinemeier Hansson
2cfe118305 Dont need all of test/unit (closes #6673) [zenspider/josh]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7602 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-23 22:12:45 +00:00
David Heinemeier Hansson
906c49d0f3 Added --skip-fixture option to script/generate model (closes #6862) [sandofsky]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7601 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-23 22:08:02 +00:00
Jeremy Kemper
6580b3ab00 Remove , and ; (comma and semicolon) from routing separators again. References #8558.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7599 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-23 21:58:02 +00:00
David Heinemeier Hansson
7d9fe04b1d Fixed cache_page to use the request url instead of the routing options when picking a save path (closes #8614) [josh]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7598 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-23 21:56:52 +00:00
Jeremy Kemper
a6f49d9b78 Introduce ActionController::Base.rescue_from to declare exception-handling methods. Cleaner style than the case-heavy rescue_action_in_public. Closes #9449.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7597 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-23 21:56:22 +00:00
Rick Olson
c619003854 Rename some RequestForgeryProtection methods. The class method is now #protect_from_forgery, and the default parameter is now 'authenticity_token'. [Rick]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7596 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-23 18:14:44 +00:00
Rick Olson
da0725aae3 move TextHelper#sanitize config options to the TextHelper module so it can be included and used with any class, not just ActionView::Base
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7595 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-23 18:09:46 +00:00
Jeremy Kemper
ccc9549436 Revert [7574]. Closes #7521.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7594 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-23 11:31:37 +00:00
Jeremy Kemper
547447ad2a RailsFCGIHandler tests. Closes #9630.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7593 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-23 11:20:25 +00:00
Rick Olson
4e3ed5bc44 Merge csrf_killer plugin into rails. Adds RequestForgeryProtection model that verifies session-specific _tokens for non-GET requests. [Rick]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7592 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-23 02:32:55 +00:00
Jeremy Kemper
3dea8b580b Dispatcher tests. References #9630.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7591 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-23 02:11:44 +00:00
Jeremy Kemper
ea45680118 Object.subclasses_of includes anonymous subclasses.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7590 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-23 01:09:20 +00:00
Rick Olson
2d02199e15 Secure #sanitize, #strip_tags, and #strip_links helpers against xss attacks. Closes #8877. [Rick, lifofifo, Jacques Distler]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7589 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-23 00:11:08 +00:00
Jeremy Kemper
4965b1b961 Correctly quote id list for limited eager loading. Closes #7482.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7588 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-22 23:51:03 +00:00
David Heinemeier Hansson
f3bf372630 Test fix (closes #6911)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7587 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-22 23:26:22 +00:00
David Heinemeier Hansson
32b31a2d0d More tests (closes #7066) [sethladd]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7586 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-22 23:21:35 +00:00
David Heinemeier Hansson
82a85e8592 Skip svnindex.xsl files when installing plugins (closes #7070) [davidjrice]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7585 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-22 23:20:48 +00:00
David Heinemeier Hansson
5757fb61d8 self.fixture_class_names is defined twice in fixtures.rb (closes #7135) [jarkko]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7584 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-22 23:17:01 +00:00
David Heinemeier Hansson
0b2e059f0a Removed unnecessary or statement (closes #7158) [richcollins]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7583 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-22 23:15:54 +00:00
David Heinemeier Hansson
953de118db Improve tests (closes #7166) [zackchandler]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7582 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-22 23:12:24 +00:00
David Heinemeier Hansson
f0dc2774e8 Improve tests (closes #7240) [josh]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7581 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-22 23:11:45 +00:00
David Heinemeier Hansson
ee45d76df8 Roll back #7578, tests failed
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7580 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-22 23:10:41 +00:00
Michael Koziarski
1abe5a2ded Fix broken mysql test [frederick.cheung@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7579 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-22 22:33:51 +00:00
David Heinemeier Hansson
9ab8d4d9ed Improve the error message for assert_redirected_to (closes #7337) [sandofsky]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7578 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-22 22:22:20 +00:00
David Heinemeier Hansson
766fbce04e Fixed that using version-targetted migrates would fail on loggers other than the default one (closes #7430) [valeksenko]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7577 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-22 22:18:55 +00:00
David Heinemeier Hansson
4cf23c9f8e Print Rails version when starting console (closes #7440) [eyematz]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7576 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-22 22:17:10 +00:00
David Heinemeier Hansson
833bd62e20 Fix CSS error in scaffold (closes #7450) [kampers]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7575 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-22 22:14:16 +00:00
David Heinemeier Hansson
35e382627e Added rake db:version to get the current schema version from the command line (closes #7521) [pelargir]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7574 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-22 22:12:10 +00:00
David Heinemeier Hansson
1d4002d462 Fixed the placement of fixture files for nested models when generating through script/generate model (closes #7547) [jkit]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7573 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-22 22:10:49 +00:00
Michael Koziarski
7573791284 Disable the routing optimisation code when dealing with foo_url helpers. Add test to actionmailer to expose the problem they introduced. References #9450 [Koz]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7572 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-22 19:20:06 +00:00
Nicholas Seckar
defb4d08dc Remove use of & logic operator. Closes #8114.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7571 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-22 19:02:51 +00:00
David Heinemeier Hansson
0442f1ea75 Docfix (closes #7593) [tarmo]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7570 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-22 18:35:41 +00:00
David Heinemeier Hansson
3dcae9fefd Fixed that pluralizing an empty string should return the same empty string, not "s" (closes #7720) [josh]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7569 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-22 18:34:43 +00:00
David Heinemeier Hansson
59c36fd456 Added TEMPLATE option to rake doc:app to set a custom output template (closes #7737) [Jakob S]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7568 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-22 18:33:39 +00:00
David Heinemeier Hansson
da5d8fa6ad Fixed JavaScriptHelper#escape_javascript to also escape closing tags (closes #8023) [rubyruy]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7567 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-22 18:31:44 +00:00
David Heinemeier Hansson
9809dc4540 Added VERBOSE option to rake db:migrate to turn off output #8204 [jbarnette]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7566 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-22 18:28:53 +00:00
David Heinemeier Hansson
05f173e2c2 Added call to inspect on non-string classes for the logger (closes #8533) [codahale]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7565 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-22 18:25:30 +00:00
David Heinemeier Hansson
2a34e082f3 Doc fixes (closes #8608) [deepblue]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7564 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-22 18:24:17 +00:00
David Heinemeier Hansson
046a87a855 Fixed rename_column for SQLite when using symbols for the column names (closes #8616) [drodriguez]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@7563 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-09-22 18:23:30 +00:00