Commit Graph

9893 Commits

Author SHA1 Message Date
Yehuda Katz + Carl Lerche
2b166d306c Added support to new callbacks for around filter object that respond to :before & :after 2009-05-27 16:49:23 -07:00
Yehuda Katz + Carl Lerche
bd7e3dc47d Added a compatibility layer to get legacy filter tests to pass on new base 2009-05-27 16:49:04 -07:00
Yehuda Katz + Carl Lerche
e70bd6bdfa Added hook point in new base #send_action which does the actual action method dispatching 2009-05-27 16:16:33 -07:00
Carl Lerche
a5688fa907 Add the ability to prepend filters to new callbacks 2009-05-27 16:15:53 -07:00
Hongli Lai (Phusion)
760cb63339 Make the default 500 Internal Server Error page more friendly. Many people don't know they're supposed to look in the log files. [#2716 state:resolved]
Signed-off-by: Joshua Peek <josh@joshpeek.com>
2009-05-27 15:01:03 -05:00
calavera
0d9e904da3 ensure initialize_database_middleware doesn't use ActionController if action_controller framework is not enabled [#2680 state:resolved]
Signed-off-by: Joshua Peek <josh@joshpeek.com>
2009-05-27 14:56:14 -05:00
Joshua Peek
6ef329d325 Ensure Memcache local cache returns duplicated values [#2302 state:resolved] 2009-05-27 14:54:58 -05:00
Eduard Bondarenko
61c471eebb Add % to RESERVED_PCHAR [#2574 state:resolved]
Signed-off-by: Joshua Peek <josh@joshpeek.com>
2009-05-27 14:53:05 -05:00
Niels Ganser
bb8e5843f3 ActionController::Flash::FlashHash.use now returns either the value corresponding to the passed key or itself when no key is passed [#1792 state:resolved]
Signed-off-by: Joshua Peek <josh@joshpeek.com>
2009-05-27 14:51:33 -05:00
anupom syam
746f3860c1 server command help inconsistency fix [#2685 state:resolved]
Signed-off-by: Joshua Peek <josh@joshpeek.com>
2009-05-27 14:45:16 -05:00
Chad Woolley
5679bf64d5 Fix failing CI test (broken in 2daac47 or e693f45): make test_multipart_with_template_path_with_dots only test path with dots, and stop failing on unrelated mimetype assertion. The image/jpeg multipart content type is already tested in test_explicitly_multipart_messages.
Signed-off-by: Yehuda Katz <wycats@yehuda-katzs-macbookpro41.local>
2009-05-27 21:38:23 +02:00
Fabien Jakimowicz
2cb60abfec Add an model_subclass generator.
This generator creates a new model as a subclass of an existing model and the unit test for that model.  Lets users avoid having to manually delete the fixtures and migration or remember to pass those arguments.

[#2702 state:committed]

Signed-off-by: Michael Koziarski <michael@koziarski.com>
2009-05-27 13:14:04 +02:00
Yehuda Katz
eaf8fe7708 Merge branch 'master' of git@github.com:rails/rails 2009-05-27 10:40:55 +02:00
Yehuda Katz
6bbe965ccd Reduce the cost of using ActionController::Http significantly by:
* Removing the dependency on AD::Request and AD::Response
  * Moving the logic for the request and response object
    into a new module that is included by default.
  * Changing Renderer and Redirector to use self.headers,
    self.content_type, and self.status, which have very basic
    default implementations on AC::Http. When RackConvenience
    is included (which it is by default on AC::Base), the full
    Request/Response logic is used instead of the simple logic.
2009-05-27 10:40:43 +02:00
Jeremy Kemper
d73f2ff434 Rename tools/profile_requires -> tools/profile since we do both require and ruby-prof profiling. 2009-05-27 01:11:33 -05:00
Jeremy Kemper
311d686d03 add a metal to minimal examples for comparison 2009-05-27 01:00:02 -05:00
Carl Lerche
7211048b2b Get all template tests passing on new base 2009-05-26 15:19:39 -07:00
Carl Lerche
a1f280e83d Got all the dispatch tests running on new base 2009-05-26 15:03:09 -07:00
Carl Lerche
1358f77745 Add controller/integration_test.rb to the new base test runner 2009-05-26 14:24:22 -07:00
Carl Lerche
a3ca5638d3 Get controller/test_test.rb to pass on new base 2009-05-26 14:13:35 -07:00
Carl Lerche
7dd094329e Add html-scanner to the new base set of autoloads 2009-05-26 13:40:58 -07:00
Carl Lerche
09907d1b93 Get controller/view_paths_test.rb to pass on new base 2009-05-26 12:14:50 -07:00
Carl Lerche
cbb0724f0d In new base Rails2Compatibility, move @template assignment to right before the first action is processed. 2009-05-26 12:06:48 -07:00
Carl Lerche
cd8fb1800d Remove a no-op from view path tests and removed a Symbol#to_proc 2009-05-26 11:47:42 -07:00
Pratik Naik
2f59066470 Support Method callbacks 2009-05-26 13:09:33 +02:00
Pratik Naik
10085114ce Make Filter#filter work with around filters 2009-05-25 18:09:12 +02:00
Pratik Naik
9cda410d81 Make cookie store tests pass with the new base 2009-05-25 16:52:44 +02:00
Jeremy Kemper
8097da93cc Don't want Rack's Content-Type default header though 2009-05-24 19:25:53 -07:00
Jeremy Kemper
b1d4fb71bf Construct a single HeaderHash. Speed up assign_default_content_type_and_charset 2009-05-24 17:35:49 -07:00
Jeremy Kemper
bdb61c1dad Compare Base with Http 2009-05-24 17:34:40 -07:00
Jeremy Kemper
6e039e863a Speed up Request#formats 2009-05-23 19:30:23 -07:00
Jeremy Kemper
a78b0a40c6 runner class 2009-05-23 19:30:18 -07:00
Jeremy Kemper
4e3fd23e31 test depends on html-scanner 2009-05-23 03:10:48 -07:00
Yehuda Katz
e0ed4b7aa4 Make a couple more tests pass.
A large number of the remaining failing tests have to do with
  the semantics of filters that are Objects. The right solution
  is probably to just implement the filter/before/after semantics
  in NewCallbacks directly (the current semantics are based
  on the old AS::Callbacks specs)
2009-05-23 01:30:25 -07:00
Yehuda Katz
e22a3d893e Slightly modify things to get content type matching working without breaking other code 2009-05-23 00:39:32 -07:00
Pratik Naik
3ac6d8f8b0 Remove unnecessary asset_host initialization 2009-05-23 02:35:34 +02:00
Pratik Naik
9286d422f8 Add asset_host to Rails2Compatibility 2009-05-23 02:29:55 +02:00
Yehuda Katz + Carl Lerche
5097bd6241 Modify render_test's determine_layout to match RJS 2009-05-22 17:26:27 -07:00
Jeremy Kemper
fb64263c91 Restore some missing test constants 2009-05-22 17:22:37 -07:00
Pratik Naik
595107f22e Move html-scanner tests one dir up 2009-05-23 02:21:07 +02:00
Yehuda Katz + Carl Lerche
69a1ea8b5d Created an ActionController::Renderers::All that includes all the default render options (:json, :js, :rjs, :xml) 2009-05-22 17:17:16 -07:00
Jeremy Kemper
da9e53ec3b Move testing_sandbox to test/lib 2009-05-22 17:17:14 -07:00
Jeremy Kemper
8a03a999ef Cordon off missing filter methods 2009-05-22 17:16:03 -07:00
Yehuda Katz + Carl Lerche
7b3fb1d43f Got controller/render_js_test.rb to pass on new base 2009-05-22 17:08:58 -07:00
Pratik Naik
3a72b55229 Add missing selector_test to the list 2009-05-23 02:08:07 +02:00
Jeremy Kemper
f9dde8fe4e Port cookies to new base 2009-05-22 17:05:44 -07:00
Pratik Naik
c90f613ad6 Add Translation to the new base 2009-05-23 02:03:22 +02:00
Yehuda Katz + Carl Lerche
28dbeb3a64 Get controller/render_other_test.rb to pass on new base and fixed a bug in new base with regards to rendering layouts. 2009-05-22 16:55:27 -07:00
Yehuda Katz + Carl Lerche
63ed43cb99 Added render_other_test.rb to the new base test runner 2009-05-22 16:55:27 -07:00
Pratik Naik
b77602824a Add some more tests to the test_new_base_on_old_tests task 2009-05-23 01:46:37 +02:00