github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
5,032 Commits 34 Branches 105 Tags
2be3a33f32b43287b692be2cc2550f159b00165e
Commit Graph

5032 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jeremy Kemper
2be3a33f32 find gracefully copes with blank :conditions. Closes #7599. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6852 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-26 00:35:49 +00:00
Jeremy Kemper
9dac6b759f auto_complete_field takes a :method option so you can GET or POST. Closes #8120. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6851 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-26 00:32:52 +00:00
Jeremy Kemper
64d655628c validates_numericality_of takes :greater_than, :greater_than_or_equal_to, :equal_to, :less_than, :less_than_or_equal_to, :odd, and :even options. Closes #3952. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6850 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-26 00:30:14 +00:00
Jeremy Kemper
1f03c5111d Add db:create, drop, reset, charset, and collation tasks. Closes #8448. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6849 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-26 00:24:58 +00:00
Jeremy Kemper
ed2a84f99b MySQL: create_database takes :charset and :collation options. Charset defaults to utf8. References #8448. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6848 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-26 00:20:37 +00:00
Jeremy Kemper
79212def83 Test that #to_xml takes a block. Closes #8471. [seth] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6847 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-25 23:04:45 +00:00
Jeremy Kemper
6149c39d14 Typo in [6845]. References #8437. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6846 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-25 22:05:57 +00:00
Jeremy Kemper
109926c5a3 Find with a list of ids supports limit/offset. Closes #8437. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6845 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-25 21:56:21 +00:00
Jeremy Kemper
ad4f1fd630 Date, Time, and DateTime support formatting blocks in addition to strftime strings. Introduce :long_ordinal format, e.g. 'February 21st, 2005'. Closes #8191. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6844 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-25 21:43:19 +00:00
Jeremy Kemper
c4a31560bd Optimistic locking: revert the lock version when an update fails. Closes #7840. Also return the number of affected rows instead of true. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6843 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-25 21:31:44 +00:00
Jeremy Kemper
38deb0ed83 Migrations: add_column supports custom column types. Closes #7742. First-patch cheers to jsgarvin\! 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6842 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-25 21:21:41 +00:00
Jeremy Kemper
0cbb75e9a0 Also remove the duplicated unit test template. References #7222. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6841 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-25 21:16:38 +00:00
Jeremy Kemper
b0b5ee958a Scaffold generator depends on model generator instead of duplicating it. Closes #7222. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6840 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-25 21:15:46 +00:00
Jeremy Kemper
74265b6501 Missed commit from [6833]. References #8456. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6839 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-25 21:14:32 +00:00
Jeremy Kemper
4793c5b808 Test reconnection after MySQL client timeout. References #428. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6838 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-25 21:09:46 +00:00
Jeremy Kemper
def61a200e Call the newly generated read method after generating it. Closes #8470. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6837 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-25 20:55:05 +00:00
Jeremy Kemper
cb7a17a9d0 Load database adapters on demand. Eliminates config.connection_adapters and RAILS_CONNECTION_ADAPTERS. Closes #8456. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6833 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-25 03:19:35 +00:00
Jeremy Kemper
162a4c5309 Include some missing fixtures. Closes #7981. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6832 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-25 01:28:40 +00:00
Jeremy Kemper
06f325f478 Add multipart request parsing test with bracketed parameter key. References #8449. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6831 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-24 23:37:37 +00:00
David Heinemeier Hansson
74d1512b99 Added option to suppress :size when using :maxlength for FormTagHelper#text_field #3112 [rails@tpope.info] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6830 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-24 20:47:03 +00:00
Jeremy Kemper
b290bc6b2f Don't alias local var 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6829 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-24 20:42:03 +00:00
Rick Olson
04354cd4c2 update changelog too 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6828 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-24 20:40:14 +00:00
Rick Olson
c57c7210cd Ensure that associations with :dependent => :delete_all respect :conditions option. Closes #8034 [danger, joshpeek, Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6827 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-24 20:39:51 +00:00
Rick Olson
4b9e67c5b9 catch possible WSOD when trying to render a missing partial. Closes #8454 [Catfish] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6826 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-24 16:42:10 +00:00
Jeremy Kemper
da7f9f516a Scaffold generator tests. Closes #8443. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6824 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-23 22:42:24 +00:00
Jeremy Kemper
4bd3e3aa1b Set RAW_POST_DATA when request parameters are parsed. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6823 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-23 19:09:37 +00:00
Jeremy Kemper
7b99b40352 Fix JSON date/time conversion tests. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6822 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-23 08:43:48 +00:00
Jeremy Kemper
301b92370a Extend the view instance directly instead of mucking with anonymous subclasses. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6821 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-23 08:00:35 +00:00
Jeremy Kemper
27ff573290 Don't play with fire (anonymous class and returning block). 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6820 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-23 07:44:57 +00:00
Jeremy Kemper
f78a1948d2 Don't load observers if Active Record isn't loaded. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6819 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-23 07:05:51 +00:00
Jeremy Kemper
a11374ad5a whiny nil shouldn't depend on Active Record 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6818 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-23 07:03:31 +00:00
Jeremy Kemper
9f51eb2472 Fix :through docs wrecked up by [6777]. Closes #4961. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6817 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-23 06:35:08 +00:00
Jeremy Kemper
ba7dc5d421 Revert [6811]. Should be fixed instead of selectively reintroducing the deprecated environment variable. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6816 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-23 06:11:48 +00:00
Jeremy Kemper
b0d01921d8 Rewind request body after reading it, if possible. Closes #8438. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6815 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-23 05:43:00 +00:00
Tobias Lütke
d418b7d391 Set RAW_POST_DATA in integration tests as expected 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6811 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-22 22:26:00 +00:00
Tobias Lütke
19fbd84e12 Rescuing in around_filters works as expected again [codahale, Stephan Kaes]. Closes #8341 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6810 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-22 19:17:43 +00:00
Tobias Lütke
4611d0e108 Initializers are now loaded consistently sorted by name. Closes #8343 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6809 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-22 19:09:32 +00:00
Jeremy Kemper
43cd97e7fa Generated scaffold functional tests use assert_difference. Closes #8421. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6808 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-22 09:41:28 +00:00
Jeremy Kemper
def8f101b8 Strip junk whitespace from [6806]. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6807 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-22 09:38:54 +00:00
Jeremy Kemper
5a3b4cf0bc Resource namespaces are inherited by their has_many subresources. Closes #8280. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6806 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-22 09:37:07 +00:00
Jeremy Kemper
4afd6c9f0a belongs_to assignment creates a new proxy rather than modifying its target in-place. Closes #8412. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6804 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-22 03:39:36 +00:00
Jeremy Kemper
8ba22a690c Fix filtered parameter logging with nil parameter values. Closes #8422. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6802 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-21 23:01:17 +00:00
Rick Olson
f6edfa3553 forgot binary fixture 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6801 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-21 19:50:44 +00:00
Rick Olson
96bc3d224d Fix column type detection while loading fixtures. Closes #7987 [roderickvd] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6798 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-21 18:54:51 +00:00
Jeremy Kemper
d1c957d067 Integration tests: alias xhr to xml_http_request and add a request_method argument instead of always using POST. Closes #7124. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6796 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-21 09:15:16 +00:00
Jeremy Kemper
7232cb705a Fix USAGE typo in resource generator. Closes #8406. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6795 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-20 23:25:18 +00:00
Jeremy Kemper
ae2db50873 Document Object#blank?. Closes #6491. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6793 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-20 23:19:10 +00:00
Jeremy Kemper
5b414190d0 Document deep eager includes. Closes #6267. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6790 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-19 22:36:36 +00:00
Jeremy Kemper
c7c867ebd2 Revert [4706] which added incorrect docs. References #5684. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6789 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-19 22:15:28 +00:00
Jeremy Kemper
ab3d187943 Document caches_action. Closes #5419. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6787 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-05-19 22:07:30 +00:00