github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-01-30 16:58:15 -05:00
Code Issues Packages Projects Releases Wiki Activity
4,817 Commits 34 Branches 105 Tags
3202fbabe6df3591d7e2c35727ea9c8b68df8828
Commit Graph

4817 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Sam Stephenson
3202fbabe6 Refactor ActiveSupport::JSON to be less obtuse. Add support for JSON decoding by way of Syck with ActiveSupport::JSON.decode(json_string). Prevent hash keys that are JavaScript reserved words from being unquoted during encoding. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6443 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-18 07:05:58 +00:00
Jeremy Kemper
3d5c947155 Fix method visibility bug uncovered by #7854. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6442 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-18 03:32:48 +00:00
Jeremy Kemper
46f092097b alias_method_chain preserves the original method's visibility. Closes #7854. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6441 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-18 03:16:53 +00:00
Jeremy Kemper
a38f28fff1 Base.update_all :order and :limit options. Useful for MySQL updates that must be ordered to avoid violating unique constraints. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6440 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-17 15:48:47 +00:00
Michael Koziarski
f87db851c6 Remove deprecated object transactions. People relying on this functionality should install the object_transactions plugin at http://code.bitsweat.net/svn/object_transactions. Closes #5637 [Koz, Jeremy Kemper] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6439 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-16 22:39:01 +00:00
Michael Koziarski
16b4739e1e Remove special cases for BigDecimal and SQLite, tests pass without them and fail with them. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6437 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-16 21:41:09 +00:00
Jeremy Kemper
c593721e7c Revert [6430] since the test is faulty. References #7837, closes #7842. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6435 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-16 13:55:36 +00:00
Jeremy Kemper
bcff10adec Fix typo in migration test. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6434 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-16 08:26:45 +00:00
Jeremy Kemper
db69c9c12a PostgreSQL: remove DateTime -> Time downcast. Bypass the DateTime migration test on 64-bit platforms since it may be a Time. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6433 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-16 08:25:37 +00:00
Jeremy Kemper
814dd007e5 Performance: patch cgi/session/pstore to require digest/md5 once rather than per #initialize. Closes #7583. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6431 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-16 05:52:12 +00:00
Jeremy Kemper
f596dda0bb Undeprecate redirect_to with Hash argument and additional url_for parameters. Closes #7837. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6430 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-16 05:21:19 +00:00
Nicholas Seckar
8a9496cb4e Add environment variable RAILS_DEFAULT_DATABASE, which allows the builtin default of 'mysql' to be overridden. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6429 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-14 23:45:17 +00:00
Nicholas Seckar
d16aa4e039 Fix changelog line 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6427 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-14 23:30:08 +00:00
Nicholas Seckar
4eec5f4fbb Update Dependencies to ignore constants inherited from ancestors. Closes #6951. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6426 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-14 23:27:28 +00:00
Jeremy Kemper
bbcfb9b625 Cookie session store: ensure that new sessions doesn't reuse data from a deleted session in the same request. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6424 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-14 11:33:10 +00:00
Jeremy Kemper
1f02271048 Deprecation: verification with :redirect_to => :named_route shouldn't be deprecated. Closes #7525. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6422 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-14 01:38:41 +00:00
Jeremy Kemper
14cc8d2faf find_or_create_by_* takes a hash so you can create with more attributes than are in the method name. Closes #7368. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6420 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-14 01:08:45 +00:00
Jeremy Kemper
5219aa9008 Cookie session store: raise ArgumentError when :session_key is blank. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6415 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-13 20:44:16 +00:00
Michael Koziarski
5bd116ccf4 Make sure with_scope takes both :select and :joins into account when setting :readonly. Allows you to save records you retrieve using finders on a has_many :through associations. [Koz] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6413 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-13 09:45:09 +00:00
Jeremy Kemper
f770165cc2 Deprecation: remove deprecated url_for(:symbol, *args) and redirect_to(:symbol, *args) controller methods. Use named routes instead. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6412 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-13 05:44:18 +00:00
Rick Olson
42f8e3f611 trim the fat 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6411 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-13 05:38:01 +00:00
Jeremy Kemper
1def3f0073 Deprecation: remove deprecated update_element_function, start_form_tag, and end_form_tag. Use RJS and form_tag instead. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6409 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-13 05:24:10 +00:00
Rick Olson
e3dab67c44 Allow a polymorphic :source for has_many :through associations. Closes #7143 [protocool] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6408 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-13 05:23:18 +00:00
Jeremy Kemper
2823a56f14 Deprecation: remove deprecated human_size helper alias. Use number_to_human_size instead. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6407 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-13 05:18:49 +00:00
Rick Olson
b7107d070a forgot to add tests for #7044 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6406 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-13 05:16:22 +00:00
Jeremy Kemper
dfc1285aad Deprecation: remove deprecated link_to_image and link_image_to methods. Use link_to(image_path(...), url). 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6405 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-13 05:12:59 +00:00
Jeremy Kemper
d20b943551 Deprecation: privatize deprecated render_partial and render_partial_collection methods. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6404 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-13 05:06:41 +00:00
Jeremy Kemper
da87839c89 Deprecation: remove toplevel components directory and uses_component_template_root. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6403 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-13 04:46:12 +00:00
Jeremy Kemper
ee71950f60 Deprecation: remove deprecated dependency methods. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6402 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-13 04:37:39 +00:00
Jeremy Kemper
0631400b4a Deprecation: remove deprecated request methods. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6401 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-13 04:32:45 +00:00
Jeremy Kemper
cb6d94cc57 Deprecation: remove deprecated redirect methods. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6400 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-13 03:58:22 +00:00
Jeremy Kemper
83c8db9818 Deprecation: remove deprecated instance variables. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6399 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-13 03:49:52 +00:00
Jeremy Kemper
9c0fe36d46 Credit Dan by name rather than nick. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6397 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-13 02:16:27 +00:00
Jeremy Kemper
07d8f46b85 Consistent public/protected/private visibility for chained methods. Closes #7813. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6396 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-13 02:14:31 +00:00
Jeremy Kemper
93db1989fe Fix to_datetime test broken by DST change. Closes #7797. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6389 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-12 05:54:26 +00:00
Jeremy Kemper
bedb879913 Oracle: fix quoted primary keys and datetime overflow. Closes #7798. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6388 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-12 05:44:01 +00:00
Jeremy Kemper
8e01143854 Adjust test for unsorted Array#to_query. References #7756. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6380 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-11 13:29:40 +00:00
Jeremy Kemper
d97456dd82 Allow array and hash query parameters. Closes #7756. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6379 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-11 13:27:57 +00:00
Jeremy Kemper
8a7275e7f4 Array#to_query preserves its ordering. References #7756. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6378 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-11 13:26:28 +00:00
Jeremy Kemper
3edc98a1cc form_options_helper refactoring for clarity. Closes #7787. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6377 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-11 13:14:53 +00:00
Jeremy Kemper
47387e1725 Fix typo, closes #7788. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6376 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-11 12:46:15 +00:00
Jeremy Kemper
be408bd4c6 Fix @logger.debug? conditional considering @logger may be nil. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6375 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-11 12:30:28 +00:00
Jeremy Kemper
9cc32a9ec8 Give time_ago_in_words test some DST slop. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6374 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-11 12:29:20 +00:00
Jeremy Kemper
98165fd31e Consistently quote primary key column names. Closes #7763. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6364 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-09 03:23:37 +00:00
Jeremy Kemper
49d1f6a813 Fixtures: fix YAML ordered map support. Closes #2665. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6360 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-09 02:06:50 +00:00
Jeremy Kemper
866cba7bb7 DateTimes assume the default timezone. Closes #7764. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6359 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-09 00:34:17 +00:00
Jeremy Kemper
c59bce8596 Fix typo. References #7727, closes #7762. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6355 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-08 12:11:51 +00:00
David Heinemeier Hansson
182b3ed70c Backed out of using File.atomic_write in the asset_tag_helper.rb as its still half-baked. Most importantly, it creates files with different permissions than File.open/write 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6354 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-07 00:48:28 +00:00
David Heinemeier Hansson
d4528effbb Caching shouldnt include the host still 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6353 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-07 00:33:13 +00:00
Tobias Lütke
3644415a1e Cached versions of concatted js/css asset tags have to be written out atomically. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6351 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-06 14:22:40 +00:00