github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
13,242 Commits 34 Branches 105 Tags
32afcdcb889e651b13e161a04c4d6d2ea78a652f
Commit Graph

13242 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
José Valim
32afcdcb88 ActiveModel::Lint should not require our models to respond to id. 2010-02-28 11:39:39 +01:00
Yehuda Katz
6ffc8364dc Explain why we're calling an empty callback 2010-02-27 17:29:28 -08:00
Yehuda Katz
b51c0d4d25 1.9 doesn't like lambda {} being called with arguments 2010-02-27 17:28:46 -08:00
Jeremy Kemper
b1b922d6ea Revert "Revert "Application detection should also allow dots in the path."" 
Works after all. Culprit was 226dfc2.

This reverts commit 6189480b18.
 2010-02-27 17:10:04 -08:00
Jeremy Kemper
6189480b18 Revert "Application detection should also allow dots in the path." 
Ruby 1.9 regression.

This reverts commit 76237f163f.
 2010-02-27 16:59:18 -08:00
S. Christoffer Eliesen
09cb0977d4 Print database.rake errors to stderr. 
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-02-27 16:53:40 -08:00
Yehuda Katz
1c9de08734 Escape the file name (who knows when a "(" might appear in a filename!) 2010-02-27 12:18:28 -08:00
Yehuda Katz
d8acaf2b66 Remove the noisy lines involving AS::Dependencies from the NameError stack trace if a constant cannot be found. 2010-02-27 11:51:19 -08:00
Yehuda Katz
8247bd9d3e The instance_reader of default_url_options needs to not exist. 2010-02-27 00:18:16 -08:00
Yehuda Katz
3f0ed205e7 Remind us that RoutingAssertions should work in an integration context 2010-02-26 22:47:36 -08:00
Carlhuda
4bdc783d37 1.9 seems to have a bug involving cloned classes and super. Fix it by not cloning (and instead creating classes on demand). The 1.9 bug should be investigated. 2010-02-26 18:25:56 -08:00
Carlhuda
faf3c2f827 Set the body using the accessor for AD::Response introspection mode so it gets wrapped in a [] 2010-02-26 18:24:55 -08:00
Carlhuda
8689989a52 Make ActionController::Routing::Routes a DeprecatedProxy 2010-02-26 17:31:32 -08:00
Carlhuda
050831803a If IntegrationSession is initialized with an objects that responds to #routes, automatically extend the URL helpers from the RouteSet onto it 2010-02-26 17:18:45 -08:00
Jeremy Kemper
6324eeefd7 plugin rails/init.rb deprecation message 2010-02-26 16:08:00 -08:00
Carlhuda
be0bf10a3c Upon further reflection, we realized that SharedTestRoutes is not really a hack, but is instead a standin (in the Rails tests) for Rails.application.routes. 
* In a real application, action_controller/railties.rb does AC::Base.include(app.routes.url_helpers)
  * ActionController itself does not know about Rails.application, but instead can have named routes for any router
  * SharedTestRoutes are created in abstract_unit to stand in for Rails.application.routes, and is used in
    internal functional tests
 2010-02-26 16:06:54 -08:00
Carlhuda
74df7795a8 Relatively speaking, it's not actually that bad... 2010-02-26 15:58:24 -08:00
Carlhuda
ab0cc7286f Setting UrlFor in with_routing is no longer needed now that it's not global 2010-02-26 15:56:38 -08:00
Carlhuda
dae109a463 Including UrlFor in Redirecting and Head will warn usefully if a controller is wired up without a router included (and still support redirect_to "omg") 2010-02-26 15:56:17 -08:00
Carlhuda
3bad24c85d Remove traces of SharedTestRoutes from user code; leave it as a standin for Rails.application.routes in Rails internal tests 2010-02-26 15:44:22 -08:00
Carlhuda
5797575bac Stop setting UrlFor using SharedTestHelpers 2010-02-26 15:40:36 -08:00
Carlhuda
47fe14bfcc Silence test deprecation warnings 2010-02-26 15:34:12 -08:00
Carlhuda
bae691f61a Change the API for setting global options for #url_for to self.url_options = { ... } 
This attr_accessor can be set in a before filter or in the action itself.
    Overwriting default_url_options still works but will output a deprecation notice.
 2010-02-26 15:20:41 -08:00
Carlhuda
224c0318bd Remove the :use_defaults check in UrlFor#merge options 2010-02-26 15:04:51 -08:00
Carlhuda
98f77e0827 Rename named_url_helpers to url_helpers and url_helpers to url_for 2010-02-26 15:04:50 -08:00
Santiago Pastorino
f10a019452 no more warning ambiguous first argument; put parentheses or even spaces on log_subscriber_test 2010-02-26 14:54:18 -08:00
Santiago Pastorino
b25c41e6d8 no more warning interpreted as argument prefix on association_preload.rb 2010-02-26 14:54:10 -08:00
Santiago Pastorino
b4b158ee10 no more interpreted as grouped expression warnings on array_ext_test 2010-02-26 14:54:02 -08:00
Yehuda Katz
1e95f019bb Fix 1.9 issue 2010-02-26 14:31:29 -08:00
Jeremy Kemper
47260598be CI: restore sudo for bundler gem install 2010-02-26 09:14:12 -08:00
Jeremy Kemper
e1daf3fb73 Remove bin dir from .gitignore 2010-02-26 08:09:09 -08:00
José Valim
e6dffb70e6 reload! on console now works as expected. [#3822 status:resolved] 2010-02-26 12:09:39 +01:00
José Valim
bd36418c51 Fix controller_path returnsing an empty string in Ruby 1.8.7 [#4036 status:resolved] 2010-02-26 11:51:21 +01:00
Tobias Bielohlawek
4db72b702f fixed a 'RecordNotFound' bug when calling 'reload' on a object which doesn't met the default_scope conditions, added test [#3166 status:resolved] 
The reload method didn't made use of 'with_exclusive_scope' when reloading the object. This lead to a RecordNotFound exception, in case the object doesn't met the default_scope condition (anymore) - which is obviously a bug. This quick fix makes use of with_exclusive_scope in the reload method as well. See test for full example.

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-02-26 11:14:16 +01:00
Dr Nic Williams
b56b9ee7d6 #add_source: Fixed docco + added required newline to line added to Gemfile 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-02-26 11:11:35 +01:00
Henry Hsu
bf9a0ae12b Fix a bug where default_scope was overriding attributes given on model initialization [#3218 status:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-02-26 11:09:43 +01:00
Ramon Soares
79c47abe6c the folder public/javascripts should be created by default [#4027 status:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-02-26 10:54:44 +01:00
José Valim
36a234609d Update thor dependency. 2010-02-26 10:51:13 +01:00
José Valim
5893baa683 Add autoload to generators modules and fix failing test. 2010-02-26 10:44:53 +01:00
José Valim
b48beb6986 Add missing require on abstract_controller/collector [#4061 status:resolved] 2010-02-26 10:27:06 +01:00
Carlhuda
f863045c45 Rename metaclass to singleton_class 2010-02-25 17:56:58 -08:00
Carlhuda
8760add31a Get URL helpers working again in integration tests. 2010-02-25 17:53:30 -08:00
Carlhuda
fc4582fb66 Final pass at removing the router from a global constant 2010-02-25 17:53:29 -08:00
Carlhuda
36fd9efb5e Continued effort to deglobalize the router 2010-02-25 17:53:01 -08:00
Carlhuda
9a5be2e5a8 Get Railties tests passing 2010-02-25 17:53:01 -08:00
Carlhuda
1fb2c6f635 Get ActionMailer's tests passing with the non global router 2010-02-25 17:53:01 -08:00
Carlhuda
a278f23310 Fix all of AP's tests with the non global router 2010-02-25 17:53:01 -08:00
Carlhuda
4b038f638d Merge branch 'master' of github.com:rails/rails 2010-02-25 17:53:01 -08:00
Carlhuda
226dfc2681 WIP: Remove the global router 2010-02-25 17:53:00 -08:00
José Valim
76237f163f Application detection should also allow dots in the path. 2010-02-26 02:35:14 +01:00