github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-02-03 18:55:29 -05:00
Code Issues Packages Projects Releases Wiki Activity
6,382 Commits 34 Branches 105 Tags
3335bd12c8b3fbfe33ceda4b4f2f33ef023571da
Commit Graph

2486 Commits

Author SHA1 Message Date
Rick Olson
4a9fc4424f Remove ERB trim variables from trace template in case ActionView::Base.erb_trim_mode is changed in the application. Closes #10098 [tpope, kampers] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8813 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-07 17:06:53 +00:00
Rick Olson
efa739d73d Fix typo in form_helper documentation. Closes #10650 [xaviershay, kampers] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8812 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-07 16:50:55 +00:00
Rick Olson
8e6638afa4 Fix bug with setting Request#format= after the getter has cached the value. Closes #10889 [cch1] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8811 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-07 16:46:50 +00:00
Rick Olson
57cea9c945 Add a slightly more informative exception message for ActionView::TemplateFinder::InvalidViewPath [rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8809 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-07 02:45:13 +00:00
Rick Olson
13264afb12 Correct inconsistencies in RequestForgeryProtection docs. #11032 [mislav] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8807 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-06 18:50:48 +00:00
Michael Koziarski
692dbbf793 Introduce a Template class to ActionView. Closes #11024 [lifofifo] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8805 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-06 04:26:40 +00:00
Jeremy Kemper
72640c6125 Cache partial variable names to reduce garbage 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8793 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-03 12:11:30 +00:00
Jeremy Kemper
53eca3abc8 Add --measure option to script/performance/request to set ruby-prof measure mode: process_time, wall_time, cpu_time, allocations, memory. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8792 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-03 12:11:12 +00:00
Jeremy Kemper
780151c01e Fix missing extension for caching. Closes #10733 [Catfish, tcoppock, mpalmer] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8791 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-03 01:11:42 +00:00
Jeremy Kemper
0da2aa6d11 Introduce the :index option for form_for and fields_for to simplify multi-model forms (see http://railscasts.com/episodes/75). Closes #9883. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8786 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-02 06:16:04 +00:00
Jeremy Kemper
fadaba679a Introduce map.resources :cards, :as => 'tarjetas' to use a custom resource name in the URL: cards_path == '/tarjetas'. Closes #10578. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8785 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-02 05:57:16 +00:00
Jeremy Kemper
9e1d91c24b TestSession supports indifferent access. Closes #7372. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8782 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-02 05:32:44 +00:00
Jeremy Kemper
9d79e0668d Fix number_to_human_size incorrectly removing trailing zeros. Closes #10099 [libc, developingchris] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8774 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-02 02:59:10 +00:00
Jeremy Kemper
b84a33ddd1 Don't split cookies on comma also. References r8505. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8773 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-02 02:55:44 +00:00
Michael Koziarski
1ba5fc745b Move the declaration of the compilation related cattr_accessors to compilable. Closes #10959 [lifofifo] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8756 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-30 21:09:32 +00:00
Michael Koziarski
05707a436b Make the non inferrable controller message a little friendlier. [Koz] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8749 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-30 01:32:28 +00:00
Michael Koziarski
900d6d7bd2 Make assert_routing aware of the HTTP method used. Closes #8039 [mpalmer] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8748 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-30 01:25:44 +00:00
Michael Koziarski
aecb7fbefc Correct line numbers from template errors. Closes #10937 [Aleksey Kondratenko] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8744 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-27 20:48:13 +00:00
Michael Koziarski
c155fe9a39 Precalculate the Backtrace of a template error to avoid raising exceptions in TemplateError#backtrace. These will abort the ruby vm. Closes #10936 [Aleksey Kondratenko] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8743 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-27 20:45:35 +00:00
Michael Koziarski
f11904ad6d Add documentation for polymorphic URL helpers, make API consistent for polymorphic_path and polymorphic_url. 
Closes #10883 [mislav] Closes #8782 [gbuesing] Closes #8720 [gbuesing]


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8741 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-27 01:18:47 +00:00
Michael Koziarski
10aa728e8b Don't repeatedly add relative_url_root to asset sources. Closes #10767 [tomtoday, Koz] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8740 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-27 01:10:48 +00:00
Michael Koziarski
5ac3a9bd0b Use File.join to construct partial path. Closes #10932 [patrick.t.joyce] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8739 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-27 01:03:56 +00:00
Michael Koziarski
6e165b8940 Make it simpler to make the root route an alias for another route. Closes #10818 [bscofield] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8738 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-26 08:41:19 +00:00
Michael Koziarski
02625c9c96 Correct documentation for dom_id [jbarnette] Closes #10775 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8734 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-26 05:11:09 +00:00
Michael Koziarski
9f1fdcc27d Handle corner case with image_tag when passed 'messed up' image names. Closes #9018 [duncanbeevers, mpalmer] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8717 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-25 04:13:50 +00:00
Jeremy Kemper
2cd8424aae Preserve integration session's request_count 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8701 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-23 08:37:58 +00:00
Michael Koziarski
c0110a9faa Refactor template compilation from AV::Base into the template handlers. Closes #10888 [lifofifo] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8689 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-22 01:46:34 +00:00
Michael Koziarski
7701e6466d Add label_tag helper for generating elements. Closes #10802 [DefV] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8685 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-21 21:08:28 +00:00
Michael Koziarski
37f71a77cc missing changelog for [8683] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8684 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-21 21:07:43 +00:00
Michael Koziarski
61c90a4ad6 Reapply the TemplateFinder first applied in [8669] then reverted in [8676]. Closes #10800 [lifofifo] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8683 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-21 20:45:04 +00:00
Michael Koziarski
250a1194b9 Ensure mime types can be compared with symbols. Closes #10796 [bscofield] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8677 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-20 22:55:25 +00:00
Jeremy Kemper
88bc014acc Revert r8669 for now, breaks Action Mailer. Reopens #10800. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8676 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-19 06:01:57 +00:00
Jeremy Kemper
f95ff8d4dc Performance: optimize route recognition. Large speedup for apps with many resource routes. Closes #10835. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8674 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-19 05:25:20 +00:00
Jeremy Kemper
630c643f5b Add timing test for large restful route recognition. References #10835 [oleganza] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8673 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-19 05:24:44 +00:00
Jeremy Kemper
84b0f9c739 Introduce TemplateFinder to handle view paths and lookups. Closes #10800. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8669 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-19 03:20:39 +00:00
Jeremy Kemper
aae37bb4f7 Extract ActiveSupport::Callbacks from Active Record, test case setup and teardown, and ActionController::Dispatcher. Closes #10727. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8664 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-19 02:44:45 +00:00
Michael Koziarski
3845de022b Restructure routing into several smaller files. References #10835 [oleganza] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8652 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-17 22:45:54 +00:00
Michael Koziarski
b812b23687 Make render :partial recognise form builders and use the _form partial. Closes #10814 [djanowski] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8646 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-16 02:01:57 +00:00
Michael Koziarski
8a71f87009 Ensure that the tests use the instance-level view-paths correctly. Closes #10820 [lifofifo] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8645 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-16 01:41:31 +00:00
Michael Koziarski
76ea495ec9 Correct docs on caching and all.js 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8641 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-14 04:22:44 +00:00
Michael Koziarski
7e1c04d866 Allow users to declare other namespaces when using the atom feed helpers. Closes #10304 [david.calavera] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8637 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-13 00:11:39 +00:00
Michael Koziarski
7501451d7f don't misbehave when redirecting to nil. Closes #10272 [farleyknight] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8633 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-12 03:09:39 +00:00
Michael Koziarski
fb63fc67fb Add some tests for adv_attr_accessor. Closes #10633 [fcheung] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8632 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-12 03:06:10 +00:00
David Heinemeier Hansson
eff27ab119 Fix a few caching errors, expose a case thats still not working (ref #107330 [catfish] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8630 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-12 01:19:46 +00:00
Jeremy Kemper
9889d86a6c Introduce send_file :x_sendfile => true to send an X-Sendfile response header. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8628 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-11 22:07:04 +00:00
David Heinemeier Hansson
5d1a305f06 Fixed ActionView::Helpers::ActiveRecordHelper::form for when protect_from_forgery is used (closes #10739) [jeremyevans] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8626 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-11 16:25:23 +00:00
Michael Koziarski
104f31af1d Provide a nicer way to access headers. request.headers["Content-Type"] instead of request.headers["HTTP_CONTENT_TYPE"] [Koz] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8625 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-11 06:39:56 +00:00
Michael Koziarski
e6de95889d * Pass around handler instances, not their classes [Koz] 
* Move compilation, rendering and 'compilable?' checks into the Handlers [Koz]
 * Remove delegate_* methods as the handler is now an instance [Koz]


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8624 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-11 04:45:06 +00:00
Jeremy Kemper
a8eb90fcee Move fragment caching from special helper methods to TemplateHandler. Closes #10754 [Josh Peek] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8619 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-10 03:17:20 +00:00
Jeremy Kemper
59f222dbf7 UrlWriter respects relative_url_root. Closes #10748. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8616 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-10 02:51:09 +00:00