github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
20,812 Commits 34 Branches 105 Tags
385be358cfa80cedff113ba57338e83ca8ac2b52
Commit Graph

20812 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Andrew White
385be358cf Fix assert_recognizes with block constraints [#5805 state:resolved] 2011-02-13 23:24:46 +00:00
Santiago Pastorino
9143032a10 Add missing require 2011-02-13 02:38:31 -02:00
Santiago Pastorino
944d314244 Add Date#rfc3339 and Date#iso8601 to AS 2011-02-13 02:10:13 -02:00
Ernie Miller
fbd917f50a Remove Relation#& alias for Relation#merge 2011-02-12 17:23:19 -08:00
Brian Lopez
7eb554bdb1 switch over to Mysql2::Client#ping for the mysql2 connection check 2011-02-12 16:59:13 -08:00
Santiago Pastorino
0e9c7a265f Make gem "ruby-debug19" require ruby-debug 2011-02-12 22:44:12 -02:00
Wojciech Wnętrzak
22e14ea573 added proper require for ruby-debug19 gem to generated Gemfile 
[#6419 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2011-02-12 22:39:06 -02:00
Josh Kalderimis
33cc36678b Allow for the format of time_tag in AP to be changed via an option argument. 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2011-02-12 22:22:30 -02:00
Sjoerd Andringa
95a5bd87cb Added time_tag helper to AP for HTML5 time tag [#5919 state:resolved] 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2011-02-12 22:22:18 -02:00
Ernie Miller
d72add9c20 Fix table name collision due to incorrect alias count on certain joins. 
[#6423 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2011-02-12 19:52:12 -02:00
Josh Kalderimis
e2b99eb1a7 Applied changes to stylesheet_link_tag from javascript_include_tag which corrects issues with ordering and duplicates. 2011-02-13 05:50:25 +08:00
Josh Kalderimis
1363bb8f72 This corrects two issues with javascript_include_tag, the order at which they are expanded, and removing duplicates. 
When individual js assets are specified, they will override the order of the same asset specified in an expansion.

[#5938 state:resolved]
 2011-02-13 05:50:24 +08:00
Carlos Antonio da Silva
ad5b4d980a Remove duplicated action pack tests added to fix issue with fields_for, nested attributes and erb 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2011-02-12 16:40:41 -02:00
Tom Stuart
829de9d98e Add block support to button_tag helper 
As per the HTML 4.01 spec:

  Buttons created with the BUTTON element function just like buttons
  created with the INPUT element, but they offer richer rendering
  possibilities: the BUTTON element may have content. For example, a
  BUTTON element that contains an image functions like and may resemble
  an INPUT element whose type is set to "image", but the BUTTON element
  type allows content.

Since rich content is the main purpose of the <button> element, it makes
sense for the button_tag helper to accept a block.

http://www.w3.org/TR/html401/interact/forms.html#edef-BUTTON
http://dev.w3.org/html5/spec/the-button-element.html#the-button-element

Signed-off-by: Santiago Pastorino and Emilio Tagua <santiago+emilioe@wyeworks.com>
 2011-02-12 13:52:00 -02:00
Tom Stuart
03749d6c88 Make type="submit" the default for button_tag helper 
"submit" is the default value of the <button> element's type attribute
according to the HTML 4.01 and the HTML5 draft specs, so if button_tag
is going to have a default, type="submit" is a more sensible choice than
type="button".

http://www.w3.org/TR/html401/interact/forms.html#adef-type-BUTTON
http://dev.w3.org/html5/spec/the-button-element.html#attr-button-type

Signed-off-by: Santiago Pastorino and Emilio Tagua <santiago+emilioe@wyeworks.com>
 2011-02-12 13:51:02 -02:00
Josh Kalderimis
e8c870726a Updated the json date regex to recognize xmlschema formatted date times during json decoding. [#3031 state:resolved] 
Signed-off-by: Santiago Pastorino and Emilio Tagua <santiago+emilioe@wyeworks.com>
 2011-02-12 13:30:30 -02:00
Aaron Patterson
5b0695a8cb key habtm fixtures off table name 2011-02-11 17:53:55 -08:00
Aaron Patterson
2b353acac3 Fixture class no longer needs a reference to the database connection 2011-02-11 17:45:09 -08:00
Aaron Patterson
bc3c3453d4 convert fixtures to a list of hashes to insert 2011-02-11 17:20:53 -08:00
Aaron Patterson
55a4fb5e70 fixture should quack like a hash 2011-02-11 17:14:23 -08:00
Aaron Patterson
a5b61269f3 Fixtures class constantizes this value, so no need to do it twice 2011-02-11 17:02:53 -08:00
Aaron Patterson
24166c2603 database quoting should take care of this, no need to gsub 2011-02-11 16:52:23 -08:00
Aaron Patterson
0ebbf6be8a calculate model class on construction 2011-02-11 16:35:15 -08:00
Aaron Patterson
61fc309479 clear cache for all connections when resetting 2011-02-11 16:26:48 -08:00
Aaron Patterson
e0802fa176 avoid side effects from method calls, localize ivar assignment 2011-02-11 16:22:38 -08:00
Aaron Patterson
af5b1db965 create fixtures always returns a list, so build a hash from the list 2011-02-11 16:18:37 -08:00
Aaron Patterson
6344246654 create_fixtures() should always return a list 2011-02-11 16:09:34 -08:00
Aaron Patterson
ca938c0fc9 fixing variable names 2011-02-11 15:37:05 -08:00
Aaron Patterson
77a6e25584 use hash defaults to dry up ||= calls 2011-02-11 15:01:51 -08:00
Aaron Patterson
fb09d02542 refactor fixtures to do less work in the constructor 2011-02-11 14:33:03 -08:00
Aaron Patterson
83dd6e1e62 favor composition over inheritence. use AS::OrderedHash rather than omap 2011-02-11 10:03:45 -08:00
Josh Kalderimis
b17d8d727f Fixes an issue when decoding a json string which looks like a date but is invalid. This DateTime parse error is now caught and the original string is instead passed back [#6286 state:resolved] 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2011-02-11 13:54:57 -02:00
Carlos Antonio da Silva
f23bf7dbdb Add missing deprecation require 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2011-02-11 13:29:23 -02:00
José Valim
28185ebc2e Remove misleading reference to polymorphic_url. 2011-02-11 05:51:13 -08:00
Aaron Patterson
339ad0d002 fixing tests on 1.8, using a list of lists because order is important 2011-02-10 14:17:09 -08:00
Aaron Patterson
61b69338b2 simplify bind parameter logging 2011-02-10 13:54:29 -08:00
Aaron Patterson
2f49cd91b7 bind parameters are logged to debug log 2011-02-10 13:34:33 -08:00
Aaron Patterson
028016ede3 test cases for bind parameter logging 2011-02-10 09:56:50 -08:00
Josh Kalderimis
1814298d75 Removed Array#safe_join in AS core_ext and moved it to a view helper with the same same. This also changes how safe_join works, if items or the separator are not html_safe they are html_escape'd, a html_safe string is always returned. 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2011-02-10 16:51:30 +01:00
José Valim
89a5f1463d Revert "Removed Array#safe_join in AS core_ext and moved it to a view helper with the same same." 
Applied the wrong version.

This reverts commit 98c0c5db50.
 2011-02-10 16:50:35 +01:00
Josh Kalderimis
98c0c5db50 Removed Array#safe_join in AS core_ext and moved it to a view helper with the same same. 2011-02-10 23:47:54 +08:00
Josh Kalderimis
1a73407b85 Corrected the html_safe implementation for Array. Moved the html safe version of join to its own method (safe_join) as not to degrade the performance of join for unrelated html_safe use. [#6298 state:resolved] 2011-02-10 23:47:54 +08:00
Paul Hieromnimon
f7221f5c75 Initial html_safe implemention for Array 2011-02-10 23:47:53 +08:00
Aaron Patterson
c560c8b2ba log method takes an option list of bind values 2011-02-09 15:15:37 -08:00
Aaron Patterson
37efb517cb fanout unsubscribe only accepted one argument, so taking *args here is probably bad 2011-02-09 14:33:56 -08:00
Aaron Patterson
3e02b3702e just use an attr_accessor so we do not pay ||= on every notification call 2011-02-09 14:02:38 -08:00
Aaron Patterson
e50d43a201 fixing indentation 2011-02-09 13:47:32 -08:00
Aaron Patterson
3d0579fc03 speed up notification publishing by writing the delegate method 2011-02-09 13:46:47 -08:00
Aaron Patterson
5548e47adb rawr, mysql, mysql2, why do you hate me. :'( 2011-02-09 13:35:56 -08:00
Josh Bassett
056be15212 Fixed a bug where ActiveResource::HttpMock would not replace an existing response when passing a block to the respond_to method. 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2011-02-09 19:25:53 -02:00