github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
9,974 Commits 34 Branches 105 Tags
38b608ecab2441cd0c4e75bc08bdf57fcf85dd71
Commit Graph

9974 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Yehuda Katz + Carl Lerche
38b608ecab Writing comments to AbstractController 2009-06-08 16:15:14 -07:00
Yehuda Katz + Carl Lerche
a470bb3612 Remove extraneous response_obj 2009-06-08 16:15:13 -07:00
Jeremy Kemper
30a3b6b4fc Ruby 1.9: fix json encoding 2009-06-08 15:16:47 -07:00
Jeremy Kemper
d3078b540e Explicitly qualify constants in BasicObjects 2009-06-08 15:07:52 -07:00
Yehuda Katz + Carl Lerche
c1fcabb350 Remove duplicate 2009-06-08 14:26:22 -07:00
Jeremy Kemper
a6bf6f275c Use as_json instead of rails_to_json 2009-06-08 14:08:04 -07:00
Yehuda Katz + Carl Lerche
86fc43fd58 ActionPack components should no longer have undeclared dependencies. 
* Tests can be run in isolation
  * Dependencies added
  * A few tests modified to avoid depending on AS deps 
    not depended on my files they were testing
 2009-06-08 13:34:07 -07:00
Jeremy Kemper
00ee990443 JSON: split encoding and coercion 2009-06-08 13:21:30 -07:00
Jeremy Kemper
5e1b46d4c2 Don't rely on Rails.logger 2009-06-08 01:40:14 -07:00
Geoff Buesing
7fe8b630ce Add notes to TZInfo bundling task 2009-06-07 22:09:21 -05:00
Geoff Buesing
71b1a4b39d Kathmandu TimeZone: reference Asia/Kathmandu zone directly instead of through linked timezone 2009-06-07 21:43:44 -05:00
Geoff Buesing
184986067a Load correct version of TZInfo 2009-06-07 21:36:09 -05:00
Jason Frey (Fryguy)
1d9346428b String #to_time and #to_datetime: handle fractional seconds [#864 state:resolved] 2009-06-07 20:16:08 -05:00
Geoff Buesing
04eb2b72b4 Update bundled TZInfo to v0.3.13 2009-06-07 20:00:25 -05:00
Tim Connor
6a3f8ae407 Work around a gem dependency edge case that prevents Rails from booting.. 
If you have a frozen gem with unfrozen dependencies (for instance if the
dependency has native extensions so can't be frozen) you can have a
nightmare upgrade problem, where you cannot rake gems:install, because
rake is broken by a gem loading problem.

If you bump up your frozen gem to a newer version that requires a newer
dependency, everybody else on the team will have rake broken by that
dependency mismatch, since you will have had to specify the dependency
in your config.gems, otherwise nobody will have installed it, since the
parent is frozen. And now the config.gems loading code will kill rake.

[#2609 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2009-06-05 21:54:56 -07:00
Jeremy Kemper
ccf70b9570 Pull in time extensions also 2009-06-05 18:27:27 -07:00
Jeremy Kemper
a838ba392e Prefer sibling action_controller 2009-06-05 18:27:27 -07:00
Yehuda Katz
d6e4113c83 YAGNI Method references. Deprecated 2009-06-02 22:06:21 -07:00
Yehuda Katz
6b4da2ecac Add explicit requirement in a few cases it was missing. 
TODO: Come up with the minimal core and remove all of these
 2009-06-02 21:43:54 -07:00
Yehuda Katz
1126a85aed Further cleaning up new callbacks 2009-06-02 21:41:31 -07:00
Yehuda Katz
971e2438d9 Simplify callbacks to use less metaprogramming 2009-06-02 19:00:59 -07:00
Yehuda Katz + Carl Lerche
196f780e30 Get all the callback tests to work on new base 2009-06-01 15:40:40 -07:00
Jeremy Kemper
dcba6e1148 Fix initializer i18n path test 2009-06-01 13:44:43 -07:00
Jeremy Kemper
94911c7af7 Ensure ERB source begins with the encoding comment 2009-06-01 12:34:08 -07:00
Han Kessels
9537fd0e3a fix for IE incompatibility of :disable_with in submit_tag 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
 2009-06-01 14:03:52 +12:00
Giles Alexander
532219fd09 Schema dumper now records scale 0 decimal columns as decimal not integer. 
The schema dumper would dump out any decimal or numeric column that had a zero
scale as an integer column. This will cause problems for very large precision
columns on some DBMSs, particularly PostgreSQL. It also looks strange to see
your column change type after moving through schema.rb.

Signed-off-by: Michael Koziarski <michael@koziarski.com>
[#2741 state:committed]
 2009-06-01 13:40:05 +12:00
Jeff Dean
b3839f1c98 Updated the db:structure:dump task to properly format the pgdump command when you have multiple schemas in your schema search path. 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
[#2695 state:committed]
 2009-06-01 12:12:45 +12:00
Vladimir Dobriakov
64756e8f71 better db:create for mysql - do not assume root user 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
[#1459 state:committed]
 2009-06-01 12:09:19 +12:00
Jeremy Kemper
f9bd10054c Sidestep need for Kernel#silence_warnings 2009-05-30 11:59:17 -07:00
Jeremy Kemper
c79551f02b Depend on Hash#slice and Object#try 2009-05-30 11:59:17 -07:00
Jeremy Kemper
85eb3af873 Tolerate missing logger 2009-05-30 11:59:17 -07:00
Jeremy Kemper
3962be5b8c Use URI and Inflector 2009-05-30 11:59:17 -07:00
Jeremy Kemper
c53057d4fd html-scanner uses Set and class_inheritable_accessor 2009-05-30 11:59:17 -07:00
Jeremy Kemper
249d9a6606 Depend on Hash#diff extension 2009-05-30 11:59:17 -07:00
Jeremy Kemper
5481e54175 AM::StateMachine autoloads 2009-05-30 11:59:16 -07:00
Joshua Peek
a1140a1031 Revert "Only save the session if we're actually writing to it [#2703 state:resolved]" 
This reverts commit dd98280e38.
 2009-05-30 09:36:08 -05:00
Luke Melia
54984f0f24 Avoid loading the ActiveRecord::SessionStore class on initialization if it is not in use [#2737 state:resolved] 
Signed-off-by: Joshua Peek <josh@joshpeek.com>
 2009-05-30 09:35:25 -05:00
Joshua Peek
e7d6f48ea9 Use AS::Concern in ActiveModel 2009-05-30 09:35:24 -05:00
Pratik Naik
e767c65cc9 Make sure tests pass action name to Controller.action() 2009-05-30 15:18:46 +01:00
Pratik Naik
63992e8f3a Support Object#filter method for before/after filters 2009-05-30 15:14:23 +01:00
Joshua Peek
669fd84910 AS::Concern redefines "include" to lazy include modules as dependencies 2009-05-29 17:03:23 -05:00
Joshua Peek
c7c35be8fe AS::Concern includes InstanceMethods module if it exists 2009-05-29 16:28:54 -05:00
Joshua Peek
69742ca8fa Merge branch 'master' into active_model 
Conflicts:
	activemodel/lib/active_model/core.rb
	activemodel/test/cases/state_machine/event_test.rb
	activemodel/test/cases/state_machine/state_transition_test.rb
	activerecord/lib/active_record/validations.rb
	activerecord/test/cases/validations/i18n_validation_test.rb
	activeresource/lib/active_resource.rb
	activeresource/test/abstract_unit.rb
 2009-05-29 16:06:21 -05:00
Jeremy Kemper
5ec2c7dc29 Ruby 1.9: ERB template encoding using a magic comment at the top of the file 2009-05-28 17:12:48 -05:00
Jeremy Kemper
e23554d79e Ruby 1.9: flushing the output buffer preserves its encoding 2009-05-28 17:12:48 -05:00
Jeremy Kemper
d120f9de7e Reinstate pending output buffer tests 2009-05-28 17:12:48 -05:00
Jeremy Kemper
cf3ccd7be0 Ruby 1.9: use UTF-8 for default internal and external encodings. 2009-05-28 17:12:48 -05:00
Joshua Peek
4e50a35fa2 Break up DependencyModule's dual function of providing a "depend_on" DSL and "included" block DSL into separate modules. But, unify both approaches under AS::Concern. 2009-05-28 11:35:36 -05:00
Joshua Peek
de203245af Revert "Revert "Whitespace!"" 
This reverts commit 0cac68d3be.
 2009-05-28 09:49:02 -05:00
Johan Sörensen
dd98280e38 Only save the session if we're actually writing to it [#2703 state:resolved] 
Signed-off-by: Joshua Peek <josh@joshpeek.com>
 2009-05-28 09:35:17 -05:00