Arun Agrawal
425c892a8f
Fixed tests for JDOM. File From Xml is working now
2011-06-01 23:35:44 +05:30
Arun Agrawal
88813e1cf7
Fixing XMLMini_JDOM
2011-06-01 23:35:44 +05:30
Arun Agrawal
60c9b7bc5c
Using java_import instead of import. Need with rake 0.9.0
2011-06-01 23:35:43 +05:30
Arun Agrawal
98cd7ca8ec
Loading files if PLATFORM available.
2011-06-01 23:35:43 +05:30
Arun Agrawal
7f34d5bc0b
Adding comment
2011-06-01 18:51:03 +01:00
Vishnu Atrai
26d0f42f18
AttributeMethodTest test fix #jruby
2011-06-01 18:51:03 +01:00
Brian Mathiyakom
8a4013ddd0
Fix issue #1272
...
Set reverse_order_value when asked to reverse_order().
Do the actual reversal in build_arel.
2011-06-01 18:30:14 +01:00
Andrew White
f1fe3c2d52
Raise NameError instead of ArgumentError in ActiveSupport::Dependencies
...
ActiveSupport::Dependencies now raises NameError if it finds an existing
constant in load_missing_constant. This better reflects the nature of
the error which is usually caused by calling constantize on a nested constant.
Closes #1423
2011-06-01 01:12:41 +01:00
Jon Leighton
5ca2e57a2f
Merge pull request #1437 from joshk/ar_collection_new_alias
...
Ar collection new alias
2011-05-31 15:53:49 -07:00
Jon Leighton
3c09ae786d
Merge pull request #1437 from joshk/ar_collection_new_alias
...
Ar collection new alias
2011-05-31 15:49:46 -07:00
Jon Leighton
668767091f
Merge pull request #1437 from joshk/ar_collection_new_alias
...
Ar collection new alias
2011-05-31 15:48:13 -07:00
Josh Kalderimis
22b02cb049
added an alias for new to build to the AR collection proxy, this corrects an issue where the collection proxies were not consistent
2011-06-01 00:42:02 +02:00
Andrew White
de7fecbb39
Make MemCacheStore work with Ruby 1.9 and -Ku
2011-05-31 23:20:54 +01:00
Jon Leighton
f4e3b70e9c
Ensure that calculations properly override the select value even if it's set in the default scope. Fixes #1395 .
2011-05-31 21:12:40 +01:00
Erik Fonselius
c22364b60d
Failing test for aggregating on default_scope with select
2011-05-31 21:12:40 +01:00
Jon Leighton
64d7348b98
Only save the record once when calling create! on a collection association. Fixes #1360 .
2011-05-31 20:32:55 +01:00
Farley Knight
842043e352
Tests for issue #1360
2011-05-31 20:32:47 +01:00
Jon Leighton
9d179135b0
Implementing @dmathieu's cleaner fix from #1425 . Unfortunately he deleted the branch so I cannot just merge it.
2011-05-31 18:37:37 +01:00
Aaron Patterson
1c42bd5444
Merge pull request #1375 from amatsuda/disable_im_by_default_on_test_31
...
Disable IdentityMap by default for ActiveRecord testing on 3-1-stable
2011-05-28 10:39:11 -07:00
Akira Matsuda
37304e3be9
Disable IdentityMap by default for ActiveRecord testing
...
because enabling IM by default will possibly hide some bugs on 3.1 default behavior
2011-05-28 20:59:33 +09:00
jacott
db05478d92
fixed asset_paths when called from sprockets for relative_url_root
2011-05-28 08:50:00 +02:00
Aaron Patterson
18a2dfbbcf
work around bug in the sqlite3 bindings. fixes #1289
2011-05-27 14:12:08 -07:00
Aaron Patterson
c0c9a336be
fixing test for mysql2
2011-05-27 11:45:49 -07:00
Aaron Patterson
37b2104109
adding a test for #1322
2011-05-27 11:45:32 -07:00
dmathieu
9cb8a18200
don't raise an exception if the format isn't recognized
...
Fixed while traveling to heuruko
2011-05-27 07:50:44 +02:00
José Valim
3868624c79
Merge pull request #1313 from joshk/deprecation_message_correction
...
Deprecation message correction
2011-05-25 14:56:10 -07:00
Josh Kalderimis
a1936b4a6b
correction to the AR::Base#attributes= guard_protected_attributes deprecation message
2011-05-25 23:44:52 +02:00
wycats
9701014b96
Renaming helper in the Rake task, but why is this needed in the first place? (paging JP)
2011-05-25 11:37:47 -07:00
José Valim
289f9cedef
Everyone receives app as argument for consistency.
...
Conflicts:
railties/lib/rails/application.rb
2011-05-25 01:39:09 +02:00
Jon Leighton
b519b0cac9
Fix infinite recursion where a lazy default scope references a scope. Fixes #1264 .
2011-05-25 00:18:08 +01:00
Andrew White
8a4263c957
Ignore :includes on through associations
2011-05-25 00:17:53 +01:00
Jon Leighton
63a659847b
Ensure that the surrounding code in Relation#to_a respects the default_scope (as well as having Relation#arel respect the default scope). Fixes #1233 .
2011-05-25 00:17:15 +01:00
Andrew White
0daf574648
Failing tests for #1233 .
2011-05-25 00:17:00 +01:00
wycats
c08f845c91
Update default Gemfile to point to sass-rails, not sass
2011-05-24 16:14:02 -07:00
wycats
23820a2042
Hide css:* and the default stylesheet from rails g
2011-05-24 16:13:53 -07:00
wycats
5d9eb1a44e
Update generator config to support hiding namespaces and pass the app into generator blocks
2011-05-24 16:13:45 -07:00
tomhuda
e1043cc848
Move SCSS generators and default templates from Rails to the Sass Railtie (d435726312601edb3ba6f97b34f562221f72c1f8).
...
* Sass gem registers a compressor
* Sass gem registers generators for assets and scaffold
* Create a default stylesheet_engine ("css") for apps that remove the Sass gem
2011-05-24 16:13:39 -07:00
tomhuda
7eed5c0303
Change compressor API so that plugins can register default compressors for their stylesheet or JS engines and still allow the user to turn off compression
2011-05-24 16:13:32 -07:00
Aaron Patterson
656e7b0807
rescue record invalid exceptions and return false from the save method. fixes #796
2011-05-24 11:26:53 -07:00
Aaron Patterson
1d864e823a
add tests surrounding behavior of save and save! for associations that have validation errors
2011-05-24 11:26:49 -07:00
Aaron Patterson
b102e60bf5
adding a test for create! with invalid associations
2011-05-24 11:26:44 -07:00
Aaron Patterson
d48563352f
do not bother with assert_nothing_raised, the test will fail and we get a better trace without it
2011-05-24 11:26:39 -07:00
Joey Butler
177666ebcf
Add failing test case for issue 796
2011-05-24 11:26:34 -07:00
David Heinemeier Hansson
c77bdc017b
Remove asserts for js ext stuff thats not used any more
2011-05-24 10:22:45 -05:00
David Heinemeier Hansson
da1ee0e371
The asset pipeline is always on for new apps, dont need the legacy js ext stuff
2011-05-24 07:46:30 -05:00
Jon Leighton
872a9c1b50
Fix problem with loading polymorphic associations which have been defined in an abstract superclass. Fixes #552 .
2011-05-23 20:30:26 +01:00
Jon Leighton
3cbfc8cc4e
Deprecate ActiveSupport::SecureRandom. Just use SecureRandom which is provided by the standard library.
2011-05-23 20:24:44 +01:00
Jon Leighton
5a6927ec1e
Replace references to ActiveSupport::SecureRandom with just SecureRandom, and require 'securerandom' from the stdlib when active support is required.
2011-05-23 20:24:44 +01:00
José Valim
b648286a0c
Merge pull request #1235 from joshk/deprecate_kernel_requires
...
Deprecate kernel requires
2011-05-23 12:20:30 -07:00
Josh Kalderimis
d79e2846da
deprecate AS core_ext/kernel/requires in 3.1
2011-05-23 19:54:00 +02:00