github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
22,834 Commits 34 Branches 105 Tags
425c892a8f213c168fbefb51bd566ce94dea3416
Commit Graph

5994 Commits

Author SHA1 Message Date
Arun Agrawal
7f34d5bc0b Adding comment 2011-06-01 18:51:03 +01:00
Vishnu Atrai
26d0f42f18 AttributeMethodTest test fix #jruby 2011-06-01 18:51:03 +01:00
Brian Mathiyakom
8a4013ddd0 Fix issue #1272 
Set reverse_order_value when asked to reverse_order().
Do the actual reversal in build_arel.
 2011-06-01 18:30:14 +01:00
Andrew White
f1fe3c2d52 Raise NameError instead of ArgumentError in ActiveSupport::Dependencies 
ActiveSupport::Dependencies now raises NameError if it finds an existing
constant in load_missing_constant. This better reflects the nature of
the error which is usually caused by calling constantize on a nested constant.

Closes #1423
 2011-06-01 01:12:41 +01:00
Jon Leighton
668767091f Merge pull request #1437 from joshk/ar_collection_new_alias 
Ar collection new alias
 2011-05-31 15:48:13 -07:00
Josh Kalderimis
22b02cb049 added an alias for new to build to the AR collection proxy, this corrects an issue where the collection proxies were not consistent 2011-06-01 00:42:02 +02:00
Jon Leighton
f4e3b70e9c Ensure that calculations properly override the select value even if it's set in the default scope. Fixes #1395. 2011-05-31 21:12:40 +01:00
Erik Fonselius
c22364b60d Failing test for aggregating on default_scope with select 2011-05-31 21:12:40 +01:00
Jon Leighton
64d7348b98 Only save the record once when calling create! on a collection association. Fixes #1360. 2011-05-31 20:32:55 +01:00
Farley Knight
842043e352 Tests for issue #1360 2011-05-31 20:32:47 +01:00
Jon Leighton
9d179135b0 Implementing @dmathieu's cleaner fix from #1425. Unfortunately he deleted the branch so I cannot just merge it. 2011-05-31 18:37:37 +01:00
Akira Matsuda
37304e3be9 Disable IdentityMap by default for ActiveRecord testing 
because enabling IM by default will possibly hide some bugs on 3.1 default behavior
 2011-05-28 20:59:33 +09:00
Aaron Patterson
18a2dfbbcf work around bug in the sqlite3 bindings. fixes #1289 2011-05-27 14:12:08 -07:00
Aaron Patterson
c0c9a336be fixing test for mysql2 2011-05-27 11:45:49 -07:00
Aaron Patterson
37b2104109 adding a test for #1322 2011-05-27 11:45:32 -07:00
Josh Kalderimis
a1936b4a6b correction to the AR::Base#attributes= guard_protected_attributes deprecation message 2011-05-25 23:44:52 +02:00
José Valim
289f9cedef Everyone receives app as argument for consistency. 
Conflicts:

	railties/lib/rails/application.rb
 2011-05-25 01:39:09 +02:00
Jon Leighton
b519b0cac9 Fix infinite recursion where a lazy default scope references a scope. Fixes #1264. 2011-05-25 00:18:08 +01:00
Andrew White
8a4263c957 Ignore :includes on through associations 2011-05-25 00:17:53 +01:00
Jon Leighton
63a659847b Ensure that the surrounding code in Relation#to_a respects the default_scope (as well as having Relation#arel respect the default scope). Fixes #1233. 2011-05-25 00:17:15 +01:00
Andrew White
0daf574648 Failing tests for #1233. 2011-05-25 00:17:00 +01:00
Aaron Patterson
656e7b0807 rescue record invalid exceptions and return false from the save method. fixes #796 2011-05-24 11:26:53 -07:00
Aaron Patterson
1d864e823a add tests surrounding behavior of save and save! for associations that have validation errors 2011-05-24 11:26:49 -07:00
Aaron Patterson
b102e60bf5 adding a test for create! with invalid associations 2011-05-24 11:26:44 -07:00
Aaron Patterson
d48563352f do not bother with assert_nothing_raised, the test will fail and we get a better trace without it 2011-05-24 11:26:39 -07:00
Joey Butler
177666ebcf Add failing test case for issue 796 2011-05-24 11:26:34 -07:00
Jon Leighton
872a9c1b50 Fix problem with loading polymorphic associations which have been defined in an abstract superclass. Fixes #552. 2011-05-23 20:30:26 +01:00
Guillermo Iguaran
6e5419a0b1 Adding pluralize_table_names change to CHANGELOG 2011-05-21 22:16:34 -05:00
David Heinemeier Hansson
82857adc56 Bump versions for rc1 2011-05-21 20:56:52 -05:00
Xavier Noria
eb0257944e Merge pull request #1180 from Karunakar/documentation_change 
Documentation Error Fixed for ticket #839
 2011-05-21 10:39:28 -07:00
Santiago Pastorino
da8469fa7d Merge pull request #1187 from thedarkone/polymorphic-class-fix 
Handle polymorphic_type NOT NULL columns
 2011-05-21 09:43:42 -07:00
Andrew White
09daaaa1e0 Add support for passing mass assignment roles to dynamic finders. Closes #1170. 2011-05-21 16:33:54 +01:00
thedarkone
1c614bcb0f Handle polymorphic_type NOT NULL-able columns as well. 2011-05-21 15:18:09 +02:00
José Valim
26703f4905 Merge pull request #1165 from arunagw/rubyforge_remove 
Not updating rubyforge for new versions.
 2011-05-21 04:55:37 -07:00
Jon Leighton
d62a39a22b Merge pull request #1162 from guilleiguaran/singularize_individual_table_name 
Singularize individual table name
 2011-05-21 01:30:00 -07:00
Ganesh Kumar
3d789ea4b9 ActionMailer deliver method Documentation corrected Ticket #761 2011-05-21 13:55:52 +05:30
Karunakar (Ruby)
b134e0f445 Documentation Error Fixed for ticket #839 2011-05-21 13:01:53 +05:30
Guillermo Iguaran
e0e8918003 AliasTracker.pluralize use pluralize_table_names of model 2011-05-20 22:54:55 -05:00
Xavier Noria
499825e19f Merge pull request #1157 from smartinez87/extra_whitespaces 
Remove extra white spaces.
 2011-05-20 06:03:12 -07:00
Arun Agrawal
f72f591c8c Not updating rubyforge for new versions. Result of "gem list -d rails" is not useful. 2011-05-20 17:43:40 +05:30
Guillermo Iguaran
23e94a67f8 Refactoring test_has_many_with_pluralize_table_names_false test 2011-05-20 01:53:13 -05:00
Guillermo Iguaran
6a3b3fba5a Allow pluralize_table_names for individual model 2011-05-20 01:44:13 -05:00
Guillermo Iguaran
159213001a for => each in model migration template 2011-05-20 00:22:17 -05:00
Guillermo Iguaran
e7d600dcdb Syntax cleanup: for in => each 2011-05-19 22:55:37 -05:00
Sebastian Martinez
b91c9076a6 Remove extra white spaces. 2011-05-19 20:51:33 -03:00
Jon Leighton
0afd5850f5 Implement proxy_owner, proxy_target and proxy_reflection methods on CollectionProxy with deprecations. Fixes #1148. 2011-05-19 23:28:44 +01:00
Michael Koziarski
2c08a74855 Merge pull request #1097 from kirillrdy/master 
Improved "treat  0000-00-00 00:00:00 as nil Date"
 2011-05-19 09:13:54 -07:00
Xavier Noria
b13d24e5b9 Merge branch 'master' of git://github.com/lifo/docrails 2011-05-18 22:50:44 +02:00
Akira Matsuda
0cd38a4af1 on.upcase! 2011-05-19 01:29:34 +09:00
Akira Matsuda
486a890505 why not use JOIN statement for joining tables? (vol. 2) 2011-05-18 18:51:03 +09:00