github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
13,366 Commits 34 Branches 105 Tags
44ebab96da0ab47cc45c64a6efdd2cbb80f9d042
Commit Graph

13366 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
José Valim
44ebab96da Rename Template::Lookup to LookupContext. 2010-03-08 15:19:03 +01:00
José Valim
ea68fe59c6 More refactoring on the views side of rendering. 2010-03-08 14:46:57 +01:00
José Valim
0a85380966 Finally moved the find template logic to the views. 2010-03-08 11:32:01 +01:00
José Valim
34b2180451 More refactoring. Split _normalize_args and _normalize_options concerns. 2010-03-08 03:23:23 +01:00
José Valim
4bae77a89b More cleanup on the layouts side. 2010-03-08 02:58:16 +01:00
José Valim
ffd8d753f1 Move layout lookup to views. 2010-03-08 02:04:18 +01:00
José Valim
c7564d74e8 Added template lookup responsible to hold all information used in template lookup. 2010-03-07 19:41:58 +01:00
José Valim
6e0443fd43 First take on ViewPaths clean up. 2010-03-07 12:49:27 +01:00
Aaron Patterson
a424f199a9 drying up more code in associations.rb 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-06 21:41:13 -08:00
Aaron Patterson
939291e8f2 deleting repeated code 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-06 21:33:29 -08:00
Stefan Penner
4bc2cbc3cf Load RAILS_VERSION relative to the gemspec file. 2010-03-06 21:33:28 -08:00
Aaron Patterson
3789539916 converting inject to each and map 
[#4119 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-03-06 20:31:50 -08:00
Aaron Patterson
45c36ea096 refactoring build_where 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-06 13:25:12 -08:00
José Valim
028e54c63d Add mailers to paths in case someone wants to access it directly and ensures deep nesting works in controllers. 2010-03-06 19:25:55 +01:00
Stijn Mathysen
67512b9489 Removed the + sign as an accepted character from the parameterize method, as a + sign is interpreted by the browser as a space, possibly resulting in a "ArgumentError: illegal character in key" 
[#4080 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-03-05 14:11:21 -08:00
Santiago Pastorino
e472f76e4c Adds disable option to date_helpers generated hidden fields when html_options specifies it. ht by Marc Schütz 
[#3807 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-03-05 13:49:04 -08:00
Jeremy Kemper
8fc97d198e Allow deprecation messages with or without a final period. 2010-03-05 12:35:42 -08:00
Jeremy Kemper
a82cf0a932 Tweak default_url_options deprecation warning 2010-03-05 12:17:23 -08:00
Jose Fernandez
a04b44910e Solved a problem that prevented render :file => work in layouts 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-05 08:52:10 -08:00
Xavier Shay
8da026cb79 Remove some of the blank rescues from number helper. This makes the code easier to understand, as you're not left wondering what the rescue is actually doing. This does not change documented/tested behaviour. 
Signed-off-by: wycats <wycats@gmail.com>
 2010-03-05 08:50:01 -08:00
José Valim
7d4d97e22a Actually, revert previous commit. Having a lot of information is better than having no information at all. 2010-03-05 15:49:36 +01:00
José Valim
80715cee73 Define to_s method in ActionView::Resolver, so I'm not required to write it in inherited classes. 2010-03-05 15:40:06 +01:00
Carl Lerche
57cf1c578a Remove the ability to set the mountpoint when initializing a route set. 2010-03-04 22:17:25 -08:00
Carl Lerche
9a17416d8b Tweak out url_for uses :script_name and add some tests 2010-03-04 22:00:30 -08:00
Carl Lerche
48672cd199 Have ActionDispatch::Routing::RouteSet.new ready to receive routes as is. 2010-03-04 21:40:26 -08:00
Bryan Helmkamp
deb00bcb8c Read Rails version from a file instead of modifying the load path and doing requires 
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-03-04 21:25:52 -08:00
Carlhuda
46bf2f04a8 Fixed a broken AM test. I'm unsure how this passed before. 2010-03-04 17:44:16 -08:00
Carlhuda
900a2d304a Get rid of relative_url_path in favor of respecting SCRIPT_NAME. Also added a way to specify a default SCRIPT_NAME when generating URLs out of the context of a request. 2010-03-04 17:43:46 -08:00
Carlhuda
3438373f03 Use AS::Concern for caching modules 2010-03-04 16:59:54 -08:00
Carlhuda
ff29606c06 Refactor cache_store to use ActionController config 2010-03-04 16:50:57 -08:00
Carlhuda
c8e1cc8657 remove_method is private 2010-03-04 16:35:05 -08:00
Carlhuda
ecf84b239f Change generated code to replace faulty comment 2010-03-04 16:12:34 -08:00
Carlhuda
e311622e7b Deprecated ActionController::Base.session_options= and ActionController::Base.session_store= in favor of a config.session_store method (which takes params) and a config.cookie_secret variable, which is used in various secret scenarios. The old AC::Base options will continue to work with deprecation warnings. 2010-03-04 16:05:52 -08:00
Carlhuda
48bb3b3904 Move stuff from compatibility.rb to deprecated.rb 2010-03-04 16:05:52 -08:00
Jeremy Kemper
5e3e5ac12b Clarify cookie jar test 2010-03-04 15:31:28 -08:00
wycats
7c785592ec Safely cleans up a test to avoid relying on a particular test order 2010-03-04 15:07:26 -08:00
wycats
70916f6a9c Fixes test ordering bug (ht: evan) 2010-03-04 12:21:12 -08:00
Carlhuda
9795bf0e74 Fix Sam Ruby's tests and deprecation warnings 2010-03-04 12:12:04 -08:00
Carlhuda
1776969627 Move session and session_store onto ActionDispatch and add deprecation warnings 2010-03-04 11:58:30 -08:00
Carl Lerche
c0c1599fb1 Update CI to the latest bundler 2010-03-04 11:24:38 -08:00
Carl Lerche
cc789ddc89 No need for a module if it's only being included once into an empty class. 2010-03-04 09:56:40 -08:00
Carl Lerche
0de3b9ec93 Somehow this fixes the AR tests when ran with rake. I should probably figure out why. 2010-03-04 02:20:01 -08:00
Carl Lerche
05b9382e29 Update the ActionMailer tests to run off of the latest ActionController config refactor 2010-03-04 01:12:16 -08:00
Carl Lerche
ad2e6ee4ec Fix a bunch of failing AP / AM specs created from the previous AbstractController configuration refactor. 2010-03-04 01:01:21 -08:00
Carl Lerche
9eddc85444 Add a method for configuring abstract controllers 2010-03-04 00:52:10 -08:00
Carl Lerche
5ce25aecee Merge branch 'configuration_refactor' 2010-03-03 22:35:43 -08:00
Carl Lerche
13a932cddc Modifying configurations on the instance of a controller should not affect the class 2010-03-03 21:32:05 -08:00
Carl Lerche
7dbf5c820b Tweak how ActionPack handles InheritableOptions 2010-03-03 21:29:26 -08:00
Carl Lerche
15b3b74624 Fix all the broken tests due to the AC configuration refactor 2010-03-03 21:24:27 -08:00
Carl Lerche
1f0f05b10c Move the original config method onto AbstractController 2010-03-03 21:24:27 -08:00