github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
17,700 Commits 34 Branches 105 Tags
4da32babdf04a151ec633cebf412fa6ca61e556d
Commit Graph

2145 Commits

Author SHA1 Message Date
RainerBlessing
8b7219b9d6 query value is converted to_s instead of to_yaml 2010-08-03 14:55:15 -07:00
Neeraj Singh
db1c484c55 Dynamic finder method like scoped_by_* create methods so that 
method_missing is not hit next time. Adding a test for this
scenario.

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-03 10:46:09 +02:00
Neeraj Singh
807239f5a1 Making Active Record base_test.rb thinner by moving tests 
to relevant files.

Number of assertions before refactoring:
2391 tests, 7579 assertions, 0 failures, 0 errors

Number of assertions after refactoring:
2391 tests, 7579 assertions, 0 failures, 0 errors

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-03 10:45:54 +02:00
Neeraj Singh
009aa8825b Eager loading an association should not change the count of children 
[#4971 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-02 17:12:59 +02:00
José Valim
e1344bf504 Tidy up previous commit. 2010-08-02 16:51:08 +02:00
Robert Pankowecki
f8b53f35b9 test and fix collection_singular_ids= with string primary keys [#5125 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-02 16:41:20 +02:00
José Valim
b613c3cc7b Add an internal (private API) after_touch callback. [#5271 state:resolved] 2010-08-02 16:16:46 +02:00
Jakub Kuźma
311ea94f73 added failing touch propagation test 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-02 15:56:49 +02:00
Aaron Patterson
834e304b22 reverting where() functionality, adding a test 2010-07-30 14:12:01 -07:00
Tarmo Tänav
2ea922bcec Don't increment and then decrement the same counter when re-assigning a belongs_to association 
[#2786 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-07-29 22:37:20 -03:00
Jon Buda
9d109302f1 fixed joining of attributes when using find_or_create_by with multiple attributes through an association 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-07-28 00:42:48 -03:00
Santiago Pastorino
4ac3ae0685 missing requires added 2010-07-26 16:26:07 -03:00
José Valim
dd61a817de Move runtime back to the Thread.current 2010-07-26 19:14:56 +02:00
Thiago Pradi
f70c0b348d Removing unnecessary code [#5192 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-26 17:13:52 +02:00
Aaron Patterson
df95948d45 do not execute the session tests within transactions 2010-07-25 15:17:03 -07:00
Santiago Pastorino
b0b9bf3204 Object#returning removed 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-25 23:30:27 +02:00
José Valim
304c49b146 Move runtime back to connection. 2010-07-25 20:59:37 +02:00
José Valim
ff0d842454 Revert the previous three commits. 
* AS::Notifications#instrument should not measure anything, it is not its responsibility;

* Adding another argument to AS::Notifications#instrument API needs to be properly discussed;
 2010-07-25 20:46:42 +02:00
Aaron Patterson
b7e0408ca9 use a hash to collect optional statistics about the instrumentation 2010-07-25 11:11:23 -07:00
José Valim
d02f2d2fb2 runtime should be properly initialized. 2010-07-25 18:26:42 +02:00
Aaron Patterson
5ebc1d88d3 testing sqlbypass destroy. caching connection during destroy 2010-07-23 08:36:58 -07:00
Aaron Patterson
da37716c35 refactoring class methods to a module 2010-07-22 23:40:39 -07:00
Santiago Pastorino
227680f415 session_id is a VARCHAR 2010-07-22 13:34:27 -07:00
Aaron Patterson
38734aff20 adding a test for session save 2010-07-22 09:35:50 -07:00
Aaron Patterson
a78547a9c6 testing loaded? method and reducing funcalls 2010-07-21 16:59:23 -07:00
Aaron Patterson
87a319cd0c testing new_record? and converting to an attribute 2010-07-21 16:55:04 -07:00
Aaron Patterson
ba0d2a9ce3 starting sql bypass test, fixing create_table and drop_table! 2010-07-21 16:36:28 -07:00
Aaron Patterson
bdbe390a98 initializing instance variables 2010-07-21 16:36:28 -07:00
Subba Rao Pasupuleti
b0c7dee4f2 removing unused models from tests 
[#5153 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-21 22:08:07 +02:00
Neeraj Singh
659e3b02ab renaming tests by removing proxy_options from names 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-21 15:25:39 +02:00
José Valim
7131244313 Ensure default_scope can be overwriten by association conditions. 2010-07-21 15:06:23 +02:00
Subba Rao Pasupuleti
d77c3b669c eagerly loaded association records should respect default_scope [#2931 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-21 15:01:40 +02:00
Neeraj Singh
992711a86b update_attribute should not update readonly attributes 
[#5106 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-21 14:55:57 +02:00
Neeraj Singh
8bb3b634c0 Timestamp columns of HABTM join table should record timestamps 
[#5161 state:resolved]
 2010-07-21 14:45:36 +02:00
José Valim
01add55d6a Revert "save on parent should not cascade to child unless child changed [#3353 state:open]" 
Please check Lighthouse for more information.

This reverts commit 4a0d7c1a43.
 2010-07-21 14:44:46 +02:00
Subba Rao Pasupuleti
96b2516c3c Strengthening the test for nested_attribute 
Loading the associate target in nested_attributes
should load most recent attributes for child
records marked for destruction

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-21 14:25:34 +02:00
Szetobo
0057d2df71 association load target shouldn't replace records 
from db if it is already loaded by nested attributes assignment

[#5053 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-21 14:25:27 +02:00
Subba Rao Pasupuleti
c0bfa0bfc1 In nested_attributes when association is not loaded and association 
record is saved and then in memory record attributes should be saved

[#5053 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-21 14:25:19 +02:00
Neeraj Singh
6ba7d5e654 - without the id test is passing even if I change :allow_destroy from 'false' - adding more tests to strengthen the test suite 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-21 14:25:13 +02:00
Neeraj Singh
f576d7cf84 Ensure that primary_keys of HABTM records is not double quoted 
[#5152 state:reslved]
 2010-07-20 16:45:42 -07:00
Santiago Pastorino
978c49ea6a Make use of severity levels 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-20 23:10:59 +02:00
José Valim
d4151d7f0a Fix a failing test in Railtie and properly define all severity levels in MockLogger for LogSubscriber. 2010-07-20 21:21:14 +02:00
Santiago Pastorino
d39c3b179c Test added, we shouldn't log sql calls when logger is not on debug? mode 2010-07-20 04:32:08 +08:00
Aaron Patterson
1b26c66ce4 mocking out debing? call in the MockLogger 2010-07-19 13:19:28 -07:00
Łukasz Strzałkowski
661fd98aad Make use of redefine_method, removed some more redefining warnings 2010-07-19 23:44:50 +08:00
Łukasz Strzałkowski
7637b7184a Test for behaviour of befeore_type_cast when operating on datetime colmun 2010-07-19 23:44:49 +08:00
Łukasz Strzałkowski
247886e1b4 Removed warnings when a variable is shadowed 2010-07-19 23:44:45 +08:00
Neeraj Singh
0fce4ae57f expected value should come first in assert_equal 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-18 15:13:38 +02:00
Neeraj Singh
6caf943ace primary_keys_test reads better than pk_test 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-18 15:13:29 +02:00
Neeraj Singh
b58e1c52f7 fixing typo 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-18 15:13:21 +02:00