Santiago Pastorino
67df21f895
No need for parenthesis here
2010-10-17 12:34:51 -02:00
Neeraj Singh
f527f9097b
no need to check for nil
...
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com >
2010-10-17 12:26:47 -02:00
Neeraj Singh
ea14396c45
replace if ! with unless
...
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com >
2010-10-17 12:26:32 -02:00
Xavier Noria
21ff8849bb
in regexps, the dot in a character class is not a metacharacter
2010-10-15 16:31:00 +02:00
Carl Lerche
69789c3b29
#transaction on the instance level should take options as well
2010-10-14 21:27:40 -07:00
Michael Koziarski
9ebe582830
Revert 0c0b0aa0f2 which introduced a security vulnerability.
...
This addresses CVE-2010-3933
Conflicts:
activerecord/lib/active_record/nested_attributes.rb
2010-10-15 10:27:33 +13:00
Xavier Noria
13f7f89bda
Merge branch 'master' of git://github.com/lifo/docrails
2010-10-14 23:15:23 +02:00
Piotr Sarnacki
f07cbec865
Do not treat information about skipped migrations as WARNINGs but as a NOTEs, also puts to stdin
2010-10-14 07:46:12 +02:00
Carl Lerche
91ba75806f
Update the ActiveRecord tests to not set unused options
...
This makes a test fail, but it is revealing a bug in Arel master.
2010-10-13 12:32:52 -07:00
Rafael Mendonça França
aec5ef243a
Remove doc for debugging callbacks. Methods don't exist in Rails master
2010-10-13 15:59:57 -03:00
Carl Lerche
0b6af35ef0
Update the PostgreSQL adapter documentation
2010-10-13 11:49:32 -07:00
Carl Lerche
941844cbe5
rb_thread_select should always be used in DB drivers when available.
2010-10-13 11:40:47 -07:00
Jon Leighton
1ddbb216ea
Delete unused methods in JoinAssociation
2010-10-13 08:24:19 -07:00
Jon Leighton
19304a9758
Renaming and formatting changes in JoinDependency
2010-10-13 08:24:19 -07:00
Jon Leighton
7dcb633427
Refactor JoinDependency and friends so that a JoinAssociation can produce an arbitrary number of joins, which will be needed in order to support nested through associations.
2010-10-13 08:24:19 -07:00
Aaron Patterson
603406dc53
stop using deprecated arel API
2010-10-12 14:33:16 -07:00
Aaron Patterson
25a2909355
dry up column type testing
2010-10-12 13:13:19 -07:00
Aaron Patterson
4b2e16ed24
all columns respond to string_to_binary, so no need to check respond_to?
2010-10-12 13:10:52 -07:00
Aaron Patterson
5b5ae01f29
drying up true and false cases
2010-10-12 11:59:20 -07:00
Aaron Patterson
01893f43f6
reducing comparisons in when statements
2010-10-12 11:55:52 -07:00
Aaron Patterson
9852a72417
removing intermediate variables
2010-10-12 11:48:41 -07:00
Aaron Patterson
c882154cd1
reduce the number of times we test for the column variable
2010-10-12 11:45:59 -07:00
Aaron Patterson
31b132aa9b
refactoring date / time / datetime when statement
2010-10-12 11:41:23 -07:00
Aaron Patterson
ef11ce2af8
fixing case / when indentation
2010-10-12 11:38:40 -07:00
Aaron Patterson
cecccf1156
we should always cast the value based on the column
2010-10-11 13:35:58 -07:00
Aaron Patterson
bef5b826e3
removing freeze
2010-10-11 13:02:36 -07:00
Marcelo Giorgi
1c9022de21
Honor distinct option when used with count operation after group clause [ #5721 state:resolved]
2010-10-11 09:39:34 -07:00
Santiago Pastorino
e0b76d6151
reorder removed in favor of except(:order).order
2010-10-11 11:54:46 -02:00
José Valim
a8b1780410
Updated DOCS for engines and added a couple TODOs. Also, commented internal railties rake tasks description.
2010-10-11 10:29:31 +02:00
wycats
cc8e386d08
Always pull in version for frameworks (standardize autoload / require / none)
2010-10-10 16:12:04 -07:00
Piotr Sarnacki
8636f64def
Rename rake railties:copy_migrations to rake railties:install:migrations and fix it to work with new copying strategy
2010-10-09 21:32:34 +02:00
Piotr Sarnacki
022205be1d
Add callback on skipped migration while copying migrations
2010-10-09 21:32:34 +02:00
Piotr Sarnacki
4377f8eba2
Change the method for copying migrations, do not add scope.
...
The purpose of this change is to allow copying fail on the same names.
Migrations change database and they should be treated with caution,
if 2 migrations are named the same it's much better to skip migration
and allow user decide if it should be copied or not.
2010-10-09 21:32:34 +02:00
Aaron Patterson
740d7e5aa2
removing false comment
2010-10-07 16:40:15 -06:00
Xavier Noria
db520042b3
Merge branch 'master' of git://github.com/lifo/docrails
2010-10-06 23:16:13 +02:00
Hemant Kumar
2a04110f26
fix ruby 1.9 deadlock problem, fixes #5736 add connection pool tests
2010-10-06 14:45:56 -06:00
José Valim
d649bf158b
Provide a cleaner syntax for paths configuration that does not rely on method_missing.
2010-10-06 17:20:15 +02:00
Aaron Patterson
e7d860c6be
create fewer objects, call fewer methods in extract_pg_identifier_from_name
2010-10-04 15:25:20 -07:00
Aaron Patterson
d8135eb452
* + flatten is not required in >= Ruby 1.8.7
2010-10-04 15:19:27 -07:00
Aaron Patterson
69a2c6b041
converting inject([]) to map
2010-10-03 16:42:08 -07:00
Aaron Patterson
365c93b7cd
speed up duplicate migration detection
2010-10-03 16:39:48 -07:00
Aaron Patterson
40761c4bf3
reduce the number of calls to camelize
2010-10-03 16:36:43 -07:00
Aaron Patterson
e6583901e5
convertion MigrationProxy to a Struct, initialize instance variables
2010-10-03 16:32:27 -07:00
Aaron Patterson
341e71a1b9
dry up some migration logic
2010-10-03 16:23:07 -07:00
Aaron Patterson
8beda11fd3
no need to differentiate between nil and false in this case
2010-10-03 16:13:45 -07:00
Aaron Patterson
5154a464cc
lengths will be nil or an array
2010-10-03 15:35:56 -07:00
Aaron Patterson
7836616a64
remove a few function calls
2010-10-03 15:18:32 -07:00
Aaron Patterson
bd78d24bd8
be kind to the garbage collector and reuse our visitor object
2010-10-03 14:40:06 -07:00
Aaron Patterson
83633b807a
avoid creating objects when we can
2010-10-03 14:40:06 -07:00
José Valim
50215f9525
Rely on Rack::Session stores API for more compatibility across the Ruby world.
2010-10-03 21:24:22 +02:00
