github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-02-14 08:04:59 -05:00
Code Issues Packages Projects Releases Wiki Activity
6,362 Commits 34 Branches 105 Tags
5ef2b089f03271fcff02280fdcbb12d38d726eba
Commit Graph

872 Commits

Author SHA1 Message Date
Jeremy Kemper
0da2aa6d11 Introduce the :index option for form_for and fields_for to simplify multi-model forms (see http://railscasts.com/episodes/75). Closes #9883. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8786 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-02 06:16:04 +00:00
Jeremy Kemper
9d79e0668d Fix number_to_human_size incorrectly removing trailing zeros. Closes #10099 [libc, developingchris] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8774 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-02-02 02:59:10 +00:00
Michael Koziarski
1ba5fc745b Move the declaration of the compilation related cattr_accessors to compilable. Closes #10959 [lifofifo] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8756 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-30 21:09:32 +00:00
Michael Koziarski
aecb7fbefc Correct line numbers from template errors. Closes #10937 [Aleksey Kondratenko] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8744 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-27 20:48:13 +00:00
Michael Koziarski
c155fe9a39 Precalculate the Backtrace of a template error to avoid raising exceptions in TemplateError#backtrace. These will abort the ruby vm. Closes #10936 [Aleksey Kondratenko] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8743 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-27 20:45:35 +00:00
Michael Koziarski
10aa728e8b Don't repeatedly add relative_url_root to asset sources. Closes #10767 [tomtoday, Koz] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8740 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-27 01:10:48 +00:00
Michael Koziarski
5ac3a9bd0b Use File.join to construct partial path. Closes #10932 [patrick.t.joyce] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8739 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-27 01:03:56 +00:00
Michael Koziarski
9f1fdcc27d Handle corner case with image_tag when passed 'messed up' image names. Closes #9018 [duncanbeevers, mpalmer] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8717 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-25 04:13:50 +00:00
Michael Koziarski
c0110a9faa Refactor template compilation from AV::Base into the template handlers. Closes #10888 [lifofifo] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8689 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-22 01:46:34 +00:00
Michael Koziarski
7701e6466d Add label_tag helper for generating elements. Closes #10802 [DefV] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8685 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-21 21:08:28 +00:00
Michael Koziarski
61c90a4ad6 Reapply the TemplateFinder first applied in [8669] then reverted in [8676]. Closes #10800 [lifofifo] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8683 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-21 20:45:04 +00:00
Jeremy Kemper
88bc014acc Revert r8669 for now, breaks Action Mailer. Reopens #10800. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8676 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-19 06:01:57 +00:00
Jeremy Kemper
84b0f9c739 Introduce TemplateFinder to handle view paths and lookups. Closes #10800. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8669 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-19 03:20:39 +00:00
Michael Koziarski
b812b23687 Make render :partial recognise form builders and use the _form partial. Closes #10814 [djanowski] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8646 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-16 02:01:57 +00:00
Michael Koziarski
76ea495ec9 Correct docs on caching and all.js 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8641 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-14 04:22:44 +00:00
Michael Koziarski
7e1c04d866 Allow users to declare other namespaces when using the atom feed helpers. Closes #10304 [david.calavera] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8637 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-13 00:11:39 +00:00
David Heinemeier Hansson
eff27ab119 Fix a few caching errors, expose a case thats still not working (ref #107330 [catfish] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8630 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-12 01:19:46 +00:00
David Heinemeier Hansson
5d1a305f06 Fixed ActionView::Helpers::ActiveRecordHelper::form for when protect_from_forgery is used (closes #10739) [jeremyevans] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8626 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-11 16:25:23 +00:00
Michael Koziarski
e6de95889d * Pass around handler instances, not their classes [Koz] 
* Move compilation, rendering and 'compilable?' checks into the Handlers [Koz]
 * Remove delegate_* methods as the handler is now an instance [Koz]


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8624 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-11 04:45:06 +00:00
Jeremy Kemper
a8eb90fcee Move fragment caching from special helper methods to TemplateHandler. Closes #10754 [Josh Peek] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8619 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-10 03:17:20 +00:00
David Heinemeier Hansson
f05b870ae0 Fix CacheHelper#cache (closes #10733) [mindforge] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8614 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-10 00:47:08 +00:00
Michael Koziarski
5ef8a81b84 Don't append the forgery token to an ajax request if it's serializing a form, prevents duplicate tokens. Closes #10684 [macournoyer] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8598 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-08 21:17:08 +00:00
Michael Koziarski
934706a8da Replace labelled_form_for example with one that will actually work. References #10738 [justinfrench, Koz] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8597 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-08 21:16:22 +00:00
Rick Olson
ce84cebc0e Doc fixes for #atom_feed_helper. Closes #10715 [hasmanyjosh] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8593 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-07 20:44:40 +00:00
Jeremy Kemper
008becb5a2 Use explicit toplevel namespace for constant reference in AS::BasicObject 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8586 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-07 08:08:22 +00:00
Jeremy Kemper
607511c1e0 Ruby 1.9 compat: truncate and excerpt helpers 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8584 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-07 00:12:53 +00:00
Jeremy Kemper
2b326a7155 Ruby 1.9 compat: remove stray colon 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8582 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-07 00:12:32 +00:00
Jeremy Kemper
a1b0349362 The asset_host block takes the controller request as an optional second argument. Example: use a single asset host for SSL requests. Closes #10549. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8578 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-06 20:53:23 +00:00
David Heinemeier Hansson
2a9ad9ccbc Moved the caching stores from ActionController::Caching::Fragments::* to ActiveSupport::Cache::*. If you're explicitly referring to a store, like ActionController::Caching::Fragments::MemoryStore, you need to update that reference with ActiveSupport::Cache::MemoryStore [DHH] Deprecated ActionController::Base.fragment_cache_store for ActionController::Base.cache_store [DHH] All fragment cache keys are now by default prefixed with the 'views/' namespace [DHH] Added ActiveRecord::Base.cache_key to make it easier to cache Active Records in combination with the new ActiveSupport::Cache::* libraries [DHH] Added ActiveSupport::Gzip.decompress/compress(source) as an easy wrapper for Zlib [Tobias Luetke] Included MemCache-Client to make the improved ActiveSupport::Cache::MemCacheStore work out of the box [Bob Cottrell, Eric Hodel] Added config.cache_store to environment options to control the default cache store (default is FileStore if tmp/cache is present, otherwise MemoryStore is used) [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8546 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-03 21:05:12 +00:00
David Heinemeier Hansson
e2e98ef0b8 Made fragment caching in views work for rjs and builder as well (closes #6642) [zsombor] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8542 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-03 15:35:10 +00:00
David Heinemeier Hansson
d5645fd4a0 Fixed rendering of partials with layout when done from site layout (closes #9209) [antramm] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8541 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-03 15:28:36 +00:00
Rick Olson
744b1d7f4d Fix atom_feed_helper to comply with the atom spec. Closes #10672 [xaviershay] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8529 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2008-01-02 19:45:53 +00:00
Rick Olson
58cf6df41a Fix that auto_link looks for ='s in url paths (Amazon urls have them). Closes #10640 [bgreenlee] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8506 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-28 20:59:30 +00:00
Jeremy Kemper
7bd33735d4 Introduce ActiveSupport::BasicObject which bridges Builder::BlankSlate and Ruby 1.9 BasicObject. Closes #10634 [Frederick Cheung] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8500 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-28 11:14:18 +00:00
Jeremy Kemper
5162e31e5b Ruby 1.9 compat: javascript proxy. References #1689 [Frederick Cheung] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8493 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-27 11:18:11 +00:00
Jeremy Kemper
a81333f115 Add :default option to time_zone_select. Closes #10590. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8473 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-21 22:18:07 +00:00
Jeremy Kemper
1f98bf101a Ruby 1.9 compat: date helper 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8467 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-21 12:26:18 +00:00
Jeremy Kemper
5c4469f3a8 Ruby 1.9 compat: form helper test 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8466 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-21 12:26:08 +00:00
Jeremy Kemper
8931a6ec16 Ruby 1.9 compat: url helper encoding 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8463 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-21 11:51:01 +00:00
David Heinemeier Hansson
c92a7cea05 Docfix (closes #10493) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8424 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-16 23:59:23 +00:00
David Heinemeier Hansson
d6859a7216 Add tests for html_escape, and remove an unneeded backslash (closes #10511) [fxn] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8422 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-16 23:53:45 +00:00
David Heinemeier Hansson
56e646296a Added option to pass proc to ActionController::Base.asset_host for maximum configurability (closes #10521) [chuyeow] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8421 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-16 23:50:02 +00:00
Jeremy Kemper
2703d55935 Ruby 1.9 compat: use String#ord to escape filenames for compiled method names 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8404 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-15 02:28:42 +00:00
David Heinemeier Hansson
78727dd8e2 Fixed that ActionView#file_exists? would be incorrect if @first_render is set (closes #10569) [dbussink] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8385 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-14 18:07:20 +00:00
Jeremy Kemper
9aca06fbee More Action View refactoring. Knock :erb default down a notch. Closes #10455. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8374 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-10 23:14:47 +00:00
Jeremy Kemper
93ec552e9b Fix up template handler tests. Closes #10437. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8372 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-10 20:41:59 +00:00
Jeremy Kemper
d0b5f640f2 Fix javascript_tag method name collision. Closes #10337. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8368 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-10 09:12:50 +00:00
Jeremy Kemper
9208390f32 Ensure asset cache directories are automatically created. Closes #10337. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8366 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-10 06:09:30 +00:00
Jeremy Kemper
3fab196da3 Refactor Action View template handlers. Closes #10437. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8341 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-09 22:11:11 +00:00
David Heinemeier Hansson
ee6232e607 Fixed documentation that made rdoc bark 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8323 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-12-06 18:45:22 +00:00