github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-04 03:00:58 -04:00
Code Issues Packages Projects Releases Wiki Activity
2,851 Commits 34 Branches 105 Tags
5f4b66201eb9bd01be96a212adfea8fb95334380
Commit Graph

2851 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Michael Koziarski
5f4b66201e Allow has_many :through to work with :include [Michael Schoen]. Closes #3611 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3566 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-10 05:19:41 +00:00
Jeremy Kemper
7e6d5b5109 PostgreSQL: smarter schema dumps using pk_and_sequence_for(table). Closes #2920. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3565 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-09 22:09:17 +00:00
Jeremy Kemper
60793cc27f SQLServer: more compatible limit/offset emulation. Closes #3779. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3564 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-09 21:42:29 +00:00
Jeremy Kemper
7654082260 Major components cleanup and speedup. Closes #3527. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3563 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-09 20:05:11 +00:00
Jeremy Kemper
3a38c829e0 Closes #3784. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3562 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-09 19:47:13 +00:00
Jeremy Kemper
08bda903ec Update AR default timezone docs. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3561 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-09 19:46:12 +00:00
Jeremy Kemper
d424674f1b SQL Server cannot sort on type text. This causes three errors in the activerecord test suite, where tests sort on the comments.body or posts.body columns. This patch changes these columns from text to varchar(4096), allowing these tests to proceed (and pass). All activerecord tests now pass under sqlserver. References #3581. [Tom Ward] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3559 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-09 19:41:32 +00:00
Jeremy Kemper
b3065a51a9 Polymorphic join support for has_one associations (has_one :foo, :as => :bar). Closes #3785. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3558 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-09 19:37:05 +00:00
Jeremy Kemper
c326851e4d defaults_test gets a dummy test method so it has at least one test to run 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3557 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-09 19:32:32 +00:00
Jeremy Kemper
d0f3e52f02 Move active_record_store_test.rb to test/activerecord/. Closes #3790. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3556 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-09 19:24:22 +00:00
Jeremy Kemper
5991e5c789 PostgreSQL: correctly parse negative integer column defaults. References #3776. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3554 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-09 18:06:29 +00:00
Michael Koziarski
d49a5fcb4c * Fix pagination problems when using include 
* Introduce Unit Tests for pagination
* Allow count to work with :include by using count distinct.

[Kevin Clark & Jeremy Hopple]


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3553 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-09 09:17:40 +00:00
Sam Stephenson
803b9a41af Add :html option for specifying form tag options in form_for 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3552 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-08 20:46:15 +00:00
Marcel Molina
73ed47ddec Replace dubious controller parent class in filter docs. Closes #3655, #3722. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3551 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-08 05:24:53 +00:00
Marcel Molina
ba2619f539 Don't interpret the :value option on text_area as an html attribute. Set the text_area's value. Closes #3752. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3550 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-08 05:13:21 +00:00
Scott Barron
a447e82de4 A more aesthetically pleasing implementation and changelog entry 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3549 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-08 03:43:38 +00:00
Scott Barron
2d7309388d Make String#last behave more like Array#last, i.e. 
"f".last(3) => "f"  not
"f".last(3) => nil


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3548 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-08 00:49:41 +00:00
Michael Koziarski
49fad6e6d5 Add Configuration#after_initialize for specifying a block to be executed after the framework is completely initialized. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3547 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-07 00:21:45 +00:00
Nicholas Seckar
7139e2a0e1 Fix remote_form_for creates a non-ajax form. Closes #3741. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3545 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-06 05:06:36 +00:00
Tobias Lütke
796295dba6 ActiveRecord::RecordInvalid now states which validations failed in its default error message 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3544 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-05 17:39:54 +00:00
David Heinemeier Hansson
0633bb865b Update versions to match latest from stable 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3543 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-05 00:59:57 +00:00
Nicholas Seckar
5450538563 Don't let arbitrary classes match as controllers 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3542 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-04 23:59:37 +00:00
Nicholas Seckar
427d0a8d14 Fix bad require for rake test 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3541 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-04 23:14:22 +00:00
Nicholas Seckar
cc768dc900 Fix routing tests to pass when run independently of the entire AP suite 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3540 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-04 23:12:15 +00:00
Nicholas Seckar
b381d8511d Fix Routing tests. Fix routing where failing to match a controller would prevent the rest of routes from being attempted. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3539 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-04 23:09:26 +00:00
Tobias Lütke
28cee08fa4 fixed small bug in routing which caused the traverse_to_controller mechanism to drop out on 
Multi::Nested::Controllers


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3538 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-04 22:04:19 +00:00
Tobias Lütke
6fa5b7b304 added some (pointless) test cases to dependency loading, the more the merrier 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3537 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-04 21:24:40 +00:00
Nicholas Seckar
9474fe72dd Add :builder => option to form_for and friends. Closes 3268. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3536 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-04 19:58:45 +00:00
David Heinemeier Hansson
2ee6229bd8 Added delegation support to Module that allows multiple delegations at once (unlike Forwardable in the stdlib) [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3535 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-04 19:14:53 +00:00
David Heinemeier Hansson
5cbc062c8a Just go with Subclasses instead of OnlySubclasses 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3534 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-04 16:26:55 +00:00
David Heinemeier Hansson
ed080863d5 Just go with Subclasses instead of OnlySubclasses 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3533 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-04 06:11:42 +00:00
David Heinemeier Hansson
a6a683b0bb Fixed Class.remove to not blow up on inheritance 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3532 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-04 06:01:28 +00:00
Nicholas Seckar
38aae1b122 Remove unneeded logging 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3531 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-04 05:41:58 +00:00
Nicholas Seckar
dfa6e14af6 Fix controller resolution to avoid accidentally inheriting a controller from a parent module. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3530 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-04 05:20:25 +00:00
Nicholas Seckar
c77729fd23 Set sweeper's @controller to nil after a request so that the controller may be collected between requests. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3529 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-04 05:00:21 +00:00
Nicholas Seckar
1aaeb2113b Fix Reloadable to handle the case where a class that has been 'removed' has not yet been garbage collected. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3528 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-04 04:50:53 +00:00
Nicholas Seckar
62aa0603b7 Don't allow Reloadable to be included into Modules 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3527 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-03 22:36:44 +00:00
Nicholas Seckar
ad9cabd77c Remove LoadingModule 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3526 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-03 20:29:39 +00:00
David Heinemeier Hansson
05eb14d55a Using AssociationCollection#build with arrays of hashes should call build, not create [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3525 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-03 18:20:19 +00:00
Nicholas Seckar
6d7b0374d1 Add LoadingModule.clear! back temporarily 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3524 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-02 16:56:15 +00:00
Nicholas Seckar
1129e5b915 Remove definition of reloadable? from ActiveRecord::Base to make way for new Reloadable code. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3523 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-02 06:13:18 +00:00
Nicholas Seckar
52b04e8e74 Reloadable::OnlySubclasses 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3522 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-02 06:11:37 +00:00
Nicholas Seckar
1bce58b312 Add Reloadable::OnlySubclasses which handles the common case where a base class should not be reloaded, but its subclasses should be. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3521 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-02 05:41:00 +00:00
Nicholas Seckar
4bb6f863b4 Pluralization bites again 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3520 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-02 05:08:42 +00:00
Nicholas Seckar
7a43a05a2b Further improvements to reloading code 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3519 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-02 04:54:07 +00:00
David Heinemeier Hansson
65c337ac85 Fixed schema handling for DB2 adapter that didn't work: an initial schema could be set, but it wasn't used when getting tables and indexes (closes #3678) [Maik Schmidt] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3518 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-01 23:34:18 +00:00
Sam Stephenson
49401f880c Subclasses of ActionController::Caching::Sweeper should be Reloadable 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3517 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-01 20:25:27 +00:00
David Heinemeier Hansson
f791fe7621 Silly me 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3513 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-01 04:18:07 +00:00
David Heinemeier Hansson
1f8f982ee0 Added Errors#any? to mean !Errors#empty? [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3510 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-01 04:11:24 +00:00
David Heinemeier Hansson
26761d6d32 If included_modules doesnt take a parameter, we shouldnt either 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3509 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-02-01 03:58:37 +00:00