github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
16,969 Commits 34 Branches 105 Tags
61317b643ae4ff61d458eb273aa86f6f7e780433
Commit Graph

16969 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
José Valim
61317b643a Provive resources_path_names helpers in the router. 2010-06-23 00:43:25 +02:00
José Valim
e5444f84df Stop filling the blocks scope array with nil. 2010-06-22 23:52:12 +02:00
Carlos Antonio da Silva
aacb83143f Allow namespace accept options in routes [#4936 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-22 23:37:49 +02:00
José Valim
fef5cf92ed Deprecate :name_prefix in the new router DSL. 2010-06-22 23:30:19 +02:00
Edgars Beigarts
62c4e4d385 Fix connection reloading in development mode. [#4929 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-22 21:48:43 +02:00
Neeraj Singh
c0fc084e93 should be able to run ActiveModel validations_test [#4933 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-22 21:38:27 +02:00
Santiago Pastorino
f61ac89947 Avoid method redefined warning 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-22 21:16:59 +02:00
Trevor Turk
64987d6711 Note that 'rails server' allows specifying mongrel, thin, etc [#4845 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-22 21:13:12 +02:00
James Harton
d0df7f1196 Fix small bug where ActiveRecord::PredicateBuilder#build_from_hash didn't test for Arel::Relation as right hand value. [#4917 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-22 18:05:27 +02:00
Neeraj Singh
7033be5f72 test for #4917 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-22 18:04:38 +02:00
Paco Guzman
ec37452f68 Remove unused variable on assert_recognizes [#4912 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-22 17:37:18 +02:00
Prem Sichanugrist
6c4bab306a Missing require for the class/attribute.rb [4812 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-22 17:18:28 +02:00
David Chelimsky
f29fb0dd9e update the list of instance variables that are excluded from assigns in view tests 
[#4930 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-22 17:15:56 +02:00
Emilio Tagua
12a9e84799 Clean CHANGELOG whitespace. 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-22 16:44:10 +02:00
Emilio Tagua
7df105b1e6 Fix order method to accept relation attributes. 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-22 16:44:10 +02:00
Emilio Tagua
df595b577e Use the new query API in AR performance script. 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-22 16:44:10 +02:00
David Calavera
b8330a2261 preventing memcached initialization errors with default servers list [#4921 state:resolved] 
As of this writing the JRuby client does not support a default port.

Signed-off-by: Xavier Noria <fxn@hashref.com>
 2010-06-22 16:28:29 +02:00
David Calavera
256a33d0fb defines ORIG_ARGV in Active Support's abstract_unit.rb (used in isolation.rb) [#4922 state:resolved] 
Signed-off-by: Xavier Noria <fxn@hashref.com>
 2010-06-22 16:27:09 +02:00
rohit
40bf76165c Rails Runner now sets $0 and $PROGRAM_NAME to name of file being run [#2244 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-22 15:20:29 +02:00
rohit
9be0b50962 Added 4 tests for Rails Runner. 2 failing tests for $0 and $PROGRAM_NAME [#2244 state:open] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-22 15:20:28 +02:00
RainerBlessing
70c932f794 adds minus to value part of id [#4862 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-22 15:10:56 +02:00
Neeraj Singh
dcfb9805f2 test for #4862 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-22 15:10:49 +02:00
Santiago Pastorino
6ea967729f Avoid method redefined warning 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-22 15:09:01 +02:00
David Chelimsky
0576ec4ddd Add support for specifying locals in view tests with assert template [#4927 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-22 14:51:22 +02:00
José Valim
02399a1184 Ensure overwritten callbacks conditions in controllers work [#4761 state:resolved] [#3913 state:resolved] 2010-06-22 07:57:45 +02:00
Jeremy Kemper
1b369be02f Bump rack-mount to 0.6.5 for tokenizer speedup 2010-06-21 18:28:00 -07:00
Josh Kalderimis
fd03f1738e removed default Formatter in logger, not needed with 1.8.7 upwards 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-22 01:19:02 +02:00
Josh Kalderimis
dad71c6099 removed 'unless const_defined?' code smell 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-21 23:34:45 +02:00
José Valim
0421fb7a91 Refactor previous commit a bit [#4057 state:resolved] 2010-06-21 12:17:24 +02:00
Jeroen van Dijk
26392c4ac5 Make ActiveModel::Errors#add_on_blank and #add_on_empty accept an options hash and make various Validators pass their (filtered) options. 
This makes it possible to pass additional options through Validators to message generation. E.g. plugin authors want to add validates_presence_of :foo, :format => "some format".

Also, cleanup the :default vs :message options confusion in ActiveModel validation message generation.

Also, deprecate ActiveModel::Errors#add_on_blank(attributes, custom_message) in favor of ActiveModel::Errors#add_on_blank(attributes, options).

Also, refactoring of ActiveModel and ActiveRecord Validation tests. Test are a lot more DRY now. Better test coverage as well now.

The first four points were reapplied from an older patch of Sven Fuchs which didn't apply cleanly anymore and was not complete yet.

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-21 11:55:21 +02:00
Jeff Kreeftmeijer
ead72b319f Changed ruby /path/to/rails myapp --dev to ruby /path/to/rails new myapp --dev in the "Thor is not avalable" message. [#4915 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-21 11:10:25 +02:00
rohit
45b263cbf1 Initialize @last_update_at in file_update_checker to hide warnings in AS test suite. 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-21 11:10:19 +02:00
Xavier Noria
b311dbb0ba Revert "files in the lib directory are no longer autoloaded" 
This patch is not consistent since it leaves similar
directories in load_paths, needs more thought.

This reverts commit b5fe014fdc.
 2010-06-21 01:46:24 +02:00
Emilio Tagua
7b7cedcb8d Don't waste time building relations if there are no values presents. [#4860 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-21 01:10:33 +02:00
Hongli Lai (Phusion)
756d77622b Allow instrumentation of cache hits and misses. [#4888 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-21 01:09:55 +02:00
José Valim
f81666698b Alias app to build_middleware_stack for clarity. 2010-06-21 01:08:50 +02:00
José Valim
746a385678 Remove unused webrick_server file. 2010-06-21 01:03:48 +02:00
Xavier Noria
b5fe014fdc files in the lib directory are no longer autoloaded 
Conceptually, the lib directory is closer 3rd party libraries
than to the application itself. Thus, Rails adds it to Ruby's
load path ($LOAD_PATH, $:) but it is no longer included in
dependencies' load paths.

To enable autoloading back put this in your config/application.rb

  config.load_paths += %W( #{config.root}/lib )
 2010-06-21 00:40:00 +02:00
Xavier Noria
69fec3ab3f adds parens to silence a warning in the test suite of AS 2010-06-20 23:29:37 +02:00
Xavier Noria
207fa59675 Merge remote branch 'rails/master' 
Conflicts:
	actionpack/lib/abstract_controller/base.rb
 2010-06-20 23:13:19 +02:00
rspeicher
31cadc730a Generators Guide: Typo of my own 2010-06-20 16:42:20 -04:00
rspeicher
cd54e610f4 Merge branch 'master' of github.com:lifo/docrails 2010-06-20 16:39:52 -04:00
rspeicher
1168d65237 Generators Guide: Style/grammar changes and minor typos 2010-06-20 16:39:44 -04:00
rspeicher
1cc71d7931 Generators Guide: Make titles conform to conventions 2010-06-20 16:38:05 -04:00
Rizwan Reza
c20cfe477a Take out documentation from DeprecatedMapper to discourage its usage. 2010-06-21 01:02:25 +04:30
Rizwan Reza
3ec7b1cba3 Use h1 for titles. 2010-06-21 01:00:42 +04:30
Rizwan Reza
ab7830d66c Final touches and fixes. 2010-06-21 00:56:31 +04:30
Rizwan Reza
96b927d9db Action View is now titled. 2010-06-21 00:50:26 +04:30
Rizwan Reza
1a0dc267f1 Action View is now titled. 2010-06-21 00:50:08 +04:30
Rizwan Reza
3ef1d63a78 All scopes are now cross-referenced. 2010-06-21 00:45:34 +04:30