Commit Graph

5089 Commits

Author SHA1 Message Date
Jeremy Kemper
6435ecc68a Missing helper load error shouldn't shadow load errors within the helper itself.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6914 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-31 19:07:57 +00:00
Jeremy Kemper
d0360a4d5c Base.inspect handles Base itself and abstract_class? Don't use #<Foo ...> since that notation's typically used for instances of a class, not the class itself. Closes #8490 [deepblue]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6913 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-31 17:31:33 +00:00
Jeremy Kemper
8158455ded Fix an edge case with find with a list of ids, limit, and offset. Closes #8437.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6912 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-31 17:15:56 +00:00
David Heinemeier Hansson
0cf79f07b0 Fixed that DateHelper#date_select should set the day to the 1st when its a hidden option and the month is visible (or invalid dates can be produced) [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6911 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-31 16:38:36 +00:00
David Heinemeier Hansson
ff5c7c8c40 Added Date#change (like Time#change) [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6910 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-31 16:37:09 +00:00
Jeremy Kemper
1edd21bb02 with_scope is protected. Closes #8524.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6909 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-30 21:40:55 +00:00
Jeremy Kemper
962b12fb9f Fix imprecise duration addition test. Closes #8516 [Geoff Buesing]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6906 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-30 07:21:14 +00:00
Jeremy Kemper
ff6d2aae0a Quickref for association methods. Closes #7723.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6905 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-30 07:05:14 +00:00
Jeremy Kemper
1f802968c5 Calculations: return nil average instead of 0 when there are no rows to average. Closes #8298.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6904 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-30 06:57:04 +00:00
Jeremy Kemper
b2681cca2e acts_as_nested_set: direct_children is sorted correctly. Closes #4761.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6903 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-30 06:34:25 +00:00
Jeremy Kemper
b7d2dae6dc DateTime#to_time converts to Time unless out of range. Date#to_datetime and Date#to_s(:rfc822). Closes #8512.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6902 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-30 06:24:32 +00:00
Jeremy Kemper
6503da6991 Time durations use since instead of + for accuracy. Closes #8513.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6901 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-30 06:21:08 +00:00
Jeremy Kemper
a1c88273f4 Skip databases that couldn't be created.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6900 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-30 05:39:49 +00:00
Jeremy Kemper
186ac4cdaa Don't choke on nested helpers.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6899 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-29 22:06:13 +00:00
Jeremy Kemper
34a5a896e1 Missed svn add from [6897]. References #8393.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6898 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-29 21:49:37 +00:00
Jeremy Kemper
3cf2c63eee Console reload! runs to_prepare callbacks also. Closes #8393.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6897 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-29 21:44:35 +00:00
Jeremy Kemper
af98d883b9 Raise an exception if both attr_protected and attr_accessible are declared. Closes #8507, #6004.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6896 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-29 20:35:46 +00:00
Rick Olson
32b307bc32 fix test cases to match new json output. Closes #8371
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6894 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-29 09:42:13 +00:00
Rick Olson
0345c97587 escape <'s and >'s in JSON strings. #8371 [Rick]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6893 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-29 09:10:36 +00:00
Jeremy Kemper
ae242b0d23 Workaround test isolation failure with Task.attr_protected :starting.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6892 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-29 08:29:33 +00:00
Jeremy Kemper
690d6e204a Typo in PostgreSQL change_column quoting. References #8466.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6891 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-29 08:06:35 +00:00
Jeremy Kemper
c2d14836a1 Missed Oracle rename_column quoting. References #8466.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6890 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-29 07:40:59 +00:00
Jeremy Kemper
69e4cc6e31 SQLite, MySQL, PostgreSQL, Oracle: quote column names in column migration SQL statements. Closes #8466.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6889 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-29 07:21:41 +00:00
Jeremy Kemper
8139de2812 Routing: drop semicolon and comma as route separators.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6888 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-29 06:40:33 +00:00
Jeremy Kemper
d3017e225f Correct flash discard rdoc. Closes #8502 [kampers]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6887 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-29 02:42:31 +00:00
Jeremy Kemper
af2ebb29da Inflections: MatrixTest -> MatrixTests instead of MatricesTest. Closes #8496.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6886 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-29 02:40:34 +00:00
Jeremy Kemper
9e76583e8e Update CHANGELOG attribution.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6885 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-29 02:13:53 +00:00
Jeremy Kemper
20fa105c35 Wordsmith generator USAGEs.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6884 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-29 02:07:08 +00:00
Jeremy Kemper
06744bb4c5 Generated migrations include timestamps by default. Closes #8501.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6883 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-29 00:11:56 +00:00
Jeremy Kemper
428d1f67da Multibyte strings respond_to the String methods they proxy so they can be duck-typed. Closes #6549.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6882 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-28 23:33:54 +00:00
Jeremy Kemper
d8b67f7fe1 Generate rdoc with utf-8 charset. Closes #7188 [manfred, jferris]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6881 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-28 22:55:14 +00:00
Rick Olson
4472a30aad Allow nil serialized attributes with a set class constraint. #7293 [sandofsky]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6879 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-28 15:51:53 +00:00
Jeremy Kemper
6f6328787c Test that DateTime are quoted as DateTime not Date. Closes #8364 [chas]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6878 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-28 05:55:27 +00:00
Jeremy Kemper
e5b3d4b3b5 request.remote_ip understands X-Forwarded-For addresses with nonstandard whitespace. Closes #7386.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6877 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-28 00:10:13 +00:00
Jeremy Kemper
0aed1d629e Don't croak if ruby-debug isn't installed.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6876 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-28 00:00:07 +00:00
Jeremy Kemper
3f336ad5cc Don't prepare response when rendering a component. Closes #8493.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6875 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-27 23:48:28 +00:00
Jeremy Kemper
77eb0a8493 Fix chained duration operation tests. Closes #8489 [Geoff Buesing]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6874 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-27 23:12:07 +00:00
Jeremy Kemper
2aed78d270 Add Active Resource to rails:freeze:edge and drop Action Web Service. Closes #8205.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6872 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-27 22:21:20 +00:00
Jeremy Kemper
3c356aa9ff Reduce file stat calls when checking for template changes. Closes #7736.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6871 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-27 19:16:09 +00:00
Jeremy Kemper
2c7715a0cf Remove unused resource generator templates obviated by [6841]. Closes #8487 [shane]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6870 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-27 19:10:08 +00:00
Jeremy Kemper
e2ad603f52 Normalize whitespace. Closes #8385 [Time Pope]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6869 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-27 18:44:33 +00:00
David Heinemeier Hansson
d3b5db8919 Added custom path cache_page/expire_page parameters in addition to the options hashes [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6868 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-27 16:38:02 +00:00
Rick Olson
cd599aad71 Action Caching speedup. #8231 [skaes]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6867 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-27 07:38:09 +00:00
Michael Koziarski
62455f56b4 Ensure compiled template tests pass on windows where there are no symlinks. [skaes]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6866 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-27 07:21:01 +00:00
Jeremy Kemper
2a253d488e Wordsmith resources documentation. Closes #8484.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6865 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-27 05:00:53 +00:00
Jeremy Kemper
849038ee51 Recognize and raise an exception on 405 Method Not Allowed responses. Closes #7692.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6864 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-26 20:57:08 +00:00
Marcel Molina
404a357013 Fix syntax error in code example for routing documentation. #8377. [norbert]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6863 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-26 20:29:05 +00:00
Jeremy Kemper
dcaa074abf Routing: respond with 405 Method Not Allowed status when the route path matches but the HTTP method does not. Closes #6953.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6862 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-26 20:07:34 +00:00
Marcel Molina
42ebf559cc Add support for assert_select_rjs with :show and :hide. #7780 [dchelimsky]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6861 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-26 17:29:23 +00:00
Marcel Molina
dc4d23f2d7 Make assert_select's failure messages clearer about what failed. #7779 [dchelimsky]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6860 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2007-05-26 17:25:19 +00:00