github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-04 03:00:58 -04:00
Code Issues Packages Projects Releases Wiki Activity
2,030 Commits 34 Branches 105 Tags
67d1e0cd3d366cd74caa24bc622442d04ef20e57
Commit Graph

2030 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jeremy Kemper
67d1e0cd3d Clean up and extend test coverage for validates_numericality_of 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2402 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-29 02:35:41 +00:00
David Heinemeier Hansson
ba91f9feaf Dont log size of request, doesnt work well with procs, not that interesting 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2401 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 20:03:31 +00:00
David Heinemeier Hansson
00e085f5a5 Solved the hanging issue.. USR2 is now the preferred way of restarting FCGIs! 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2400 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 19:39:12 +00:00
David Heinemeier Hansson
8e4f27a50a Solved the hanging issue.. USR2 is now the preferred way of restarting FCGIs! 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2399 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 19:31:41 +00:00
Nicholas Seckar
fc83920383 Fix transactions so that calling return while inside a transaction will not leave an open transaction on the connection. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2398 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 18:53:22 +00:00
Marcel Molina
0d07152aab Make schema definition column lookups agnostic w/r/t/ whether a key or symbol is passed. Fixes failing test in [2396]. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2397 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 18:07:18 +00:00
Marcel Molina
f43d97a860 Add failing test that shows that AR::Migration.remove_column fails silently with SQLite when passed arguments as symbols. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2396 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 17:50:28 +00:00
Thomas Fuchs
4d6ad9c48b Updated rdoc for javascript_include_tag 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2395 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 10:55:57 +00:00
Jeremy Kemper
db8f727229 Ticket #2156 - Use foreign_key inflection uniformly 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2394 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 09:14:33 +00:00
David Heinemeier Hansson
981763e53e My life for white space 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2393 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 09:06:34 +00:00
David Heinemeier Hansson
ac8f76b521 Dont log it twice 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2392 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 08:55:04 +00:00
David Heinemeier Hansson
d87618d20d Log request method and response size / status code 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2391 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 08:43:17 +00:00
David Heinemeier Hansson
b7faeb20e9 Added in-process restarting on USR2 -- still missing a good way to free up the socket, so not a complete solution yet. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2390 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 08:38:26 +00:00
Jeremy Kemper
5d19fd7841 Unit tests and fixtures for multipart posts. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2389 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 08:19:26 +00:00
Thomas Fuchs
9084f5b6e8 Forgot about CHANGELOGs 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2388 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 08:26:06 +00:00
Thomas Fuchs
516dc2c0f1 Update script.aculo.us to 1.5_rc2, and Prototype to 1.4.0_pre7 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2386 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 08:20:47 +00:00
Jeremy Kemper
dd21e9ae39 r3657@asus: jeremy | 2005-09-28 00:32:33 -0700 
Also test that client.firm_id.nil? after firm.clients.clear when clients is not :dependent


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2385 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 04:00:59 +00:00
Jeremy Kemper
efaf2af07c r3653@asus: jeremy | 2005-09-28 00:23:49 -0700 
Ticket 2221 - model.association.clear should destroy associated objects if :dependent => true instead of nullifying their foreign keys


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2384 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 03:52:57 +00:00
Marcel Molina
1e87d6e887 Added test coverage for stylesheet_path to show that it works as requested in #1471. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2383 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 02:08:58 +00:00
Marcel Molina
93db2f3895 Include additional ticket number that is closed by [2380]. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2382 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 00:21:01 +00:00
Scott Barron
83b390bcfc Returning false in before_destroy should cancel action. Closes #1829. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2381 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 00:09:50 +00:00
Marcel Molina
8e78e9335b Make table_name and controller_name in generators honor AR::Base.pluralize_table_names. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2380 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 00:06:39 +00:00
Nicholas Seckar
0b1abc3360 Undo condition change made in [2345] to prevent normal parameters arriving as StringIO. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2379 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-27 23:39:56 +00:00
Jeremy Kemper
0bd11857ef Ticket 2256 - Recognize PostgreSQL NOW() default as equivalent to CURRENT_TIMESTAMP/CURRENT_DATE 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2378 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-27 23:37:57 +00:00
Scott Barron
e1024e50cf #2261 was supposed to have been closed as wontfix, not sure why it wasn't, 
sorry.  We discussed this on IRC and reached the conclusion that it was
an undesirable addition.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2377 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-27 23:31:32 +00:00
Jeremy Kemper
5217b90909 Ticket 2261 - Include lib/tasks/*.rake in rake stats 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2376 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-27 22:57:05 +00:00
Jeremy Kemper
17d2732b1c Ticket #2295 - Tolerate consecutive delimiters in query parameters 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2375 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-27 22:23:37 +00:00
Jeremy Kemper
0c23f06129 Update change log for #2297 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2374 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-27 22:10:33 +00:00
Jeremy Kemper
ec019d7bc1 Ticket 2297 - rake stats clearly labels functional and unit tests 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2373 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-27 22:09:21 +00:00
Jeremy Kemper
fcd0133f69 Update change log for #2250. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2372 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-27 20:47:34 +00:00
Marcel Molina
b9fa3541b4 Add extensive documentation to the ActiveRecord::AbstractAdapter. #2250 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2371 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-27 20:37:23 +00:00
Jeremy Kemper
3fa38c4dba Oops, swapped order of params to COALESCE! Upcoming patch has test cases. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2370 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-27 20:24:52 +00:00
Jeremy Kemper
fe0ffe406e Ticket 2263 - Make clean logger compatible with both 1.8.2 and 1.8.3 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2369 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-27 20:18:55 +00:00
Nicholas Seckar
564077373d Streamline render process, code cleaning. Closes #2294. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2368 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-27 16:45:39 +00:00
Jeremy Kemper
64937891c7 r3632@asus: jeremy | 2005-09-27 12:18:49 -0700 
reset_sequences cleanup also fixed #2183; credit ticket author


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2367 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-27 15:45:48 +00:00
Scott Barron
a111e1a271 Keep flash after component is rendered. Closes #2291. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2363 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-27 11:02:11 +00:00
Sam Stephenson
72c3ffc7fb Make the migration generator only check files ending in *.rb when calculating the next file name #2317 [Chad Fowler] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2362 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-27 10:47:47 +00:00
Scott Barron
76a7a52557 Fix serialization problem with YAML in 1.8.3 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2360 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-27 09:25:17 +00:00
Jeremy Kemper
f5f7beb369 r3613@asus: jeremy | 2005-09-26 22:25:04 -0700 
Handle sequence reset for empty tables and models with custom primary keys.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2357 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-27 01:51:05 +00:00
Jeremy Kemper
169785162c r3605@asus: jeremy | 2005-09-26 19:10:50 -0700 
Update change log.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2356 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-26 22:41:18 +00:00
Jeremy Kemper
6d7551f1bb r3604@asus: jeremy | 2005-09-26 19:10:42 -0700 
Treat validates_size_of :within as a single validator rather than splitting it into to ends of the range, thus yield two error messages on nil (yuck)


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2355 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-26 22:41:02 +00:00
Jeremy Kemper
54adccda08 r3603@asus: jeremy | 2005-09-26 19:10:00 -0700 
Add unit tests for nil assigned to validates_size_of :attr, :within


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2354 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-26 22:40:51 +00:00
Marcel Molina
1d738cab80 Make update_attribute use the same writer method that update_attributes uses. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2353 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-26 21:55:37 +00:00
Marcel Molina
1465f9cee2 Make migrations honor table name prefixes and suffixes. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2352 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-26 21:30:12 +00:00
Jeremy Kemper
0f276de512 r3597@asus: jeremy | 2005-09-26 17:39:23 -0700 
Minor improvement to SQLite adapter blob escaping.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2351 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-26 21:04:36 +00:00
Marcel Molina
b54560600b Have text helpers use built in Regexp.escape rather than home grown alternative 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2350 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-26 20:49:52 +00:00
Jeremy Kemper
bbfde01b94 r3592@asus: jeremy | 2005-09-26 17:01:47 -0700 
Update change log.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2349 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-26 20:29:11 +00:00
Jeremy Kemper
27ecb482c6 r3591@asus: jeremy | 2005-09-26 17:01:30 -0700 
Simplify binary unit test.  Use flowers.jpg instead of associations.png


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2348 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-26 20:29:06 +00:00
Jeremy Kemper
a5e2f6cd28 r3590@asus: jeremy | 2005-09-26 17:00:53 -0700 
Correct and optimize PostgreSQL bytea escaping.  This is a blend of four patches, each providing a bit to the solution.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2347 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-26 20:29:01 +00:00
Jeremy Kemper
79a535ecd7 r3589@asus: jeremy | 2005-09-26 16:58:40 -0700 
Remove associations.png in favor of flower.jpg which reveals a bug in binary escaping.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2346 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-26 20:28:55 +00:00