github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
10,833 Commits 34 Branches 105 Tags
67eb892e941e49c5059cd5b80443a8f2913f3f8c
Commit Graph

10833 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Joshua Peek
67eb892e94 AV::UrlHelper depends on Array#second 2009-09-13 17:25:40 -05:00
Joshua Peek
8491b77f55 Omit PATH_INFO in integration test so rack mock will properly override it 2009-09-13 17:15:35 -05:00
Joshua Peek
076d7f885e AP tests: detect missing dependencies and automatically run bundler 2009-09-13 16:37:30 -05:00
Joshua Peek
6d214c953b Merge abstract_controller/test_helper and new_base/test_helper since they are expected to run in the same testing sandbox 2009-09-13 16:30:27 -05:00
Joshua Peek
199a423f42 Don't eager require mocha, AS unit needs to set stuff up first 2009-09-13 16:12:33 -05:00
Joshua Peek
48c81f52d4 Remove dead old base abstract unit 2009-09-13 15:34:17 -05:00
Joshua Peek
a01bf41c61 Lazy require memcache for session middleware 2009-09-13 15:30:55 -05:00
Joshua Peek
fff3f0ae0c Detect missing dependencies and automatically run bundler 2009-09-13 15:10:29 -05:00
Joshua Peek
ef38e67562 Ignore bundled gems 2009-09-13 14:36:20 -05:00
Joshua Peek
5b8373da29 Shush interpolation warnings 2009-09-13 14:34:59 -05:00
Joshua Peek
3b6bb4664f Forget about old memoize immutable behavior 2009-09-13 13:08:12 -05:00
Joshua Peek
25f4129151 Need to declare optional dependencies from AS 2009-09-13 12:58:49 -05:00
Joshua Peek
870bf8950f Load vendored i18n if its not found since its a real requirement 2009-09-13 12:49:22 -05:00
Joshua Peek
ec0d4efd79 Avoid referencing rubygems 2009-09-13 12:47:37 -05:00
Joshua Peek
a9f5f4bb45 Don't force test suite to use bundler 2009-09-13 12:42:13 -05:00
Joshua Peek
f3f2e0b00d Move AS vendor support into bundler. 
Run `rake bundle` before running tests.
 2009-09-13 12:24:50 -05:00
Joshua Peek
3b325d624c require reporting before attempting to "shush" 2009-09-13 10:53:12 -05:00
Jeremy Kemper
941e990410 Shush, new_callbacks 2009-09-13 06:06:20 -07:00
Jeremy Kemper
c2018b4b7b Shush, rexml 2009-09-13 05:57:44 -07:00
Jeremy Kemper
7e6652edbf Prefer not to shadow a local 2009-09-13 05:56:21 -07:00
Jeremy Kemper
98f96a0809 Ignore isolation test tests for test-unit 2 also 2009-09-13 05:52:18 -07:00
Jeremy Kemper
053a0f6ac4 Clean up spurious JSON decoding test failure 2009-09-13 05:43:02 -07:00
Jeremy Kemper
7d2add8c96 Ruby 1.9 compat: fix regexp slice test 2009-09-13 05:31:43 -07:00
Jeremy Kemper
cce2112f12 Silence warning for Encoding.default_external= 2009-09-13 04:48:40 -07:00
Jeremy Kemper
91ffddca57 Use Encoding.default_external, not _internal 2009-09-13 04:43:41 -07:00
sdsykes
dbe9fa03df Ruby 1.9 compat: corrected instance_methods check 
[#3156 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2009-09-13 02:57:53 -07:00
Jeremy Kemper
091486fb98 activesupport -> active_support 2009-09-13 02:45:37 -07:00
Aaron Patterson
f959758687 making secure_compare faster 
[#3195 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2009-09-13 02:44:52 -07:00
Michael Koziarski
e590508a9b Dup the arguments to string compare so we can use force_encoding. 2009-09-13 10:36:04 +12:00
Michael Koziarski
81cba78e9e Merge commit 'alloy/master-nested_attributes_and_autosave' 2009-09-13 10:32:24 +12:00
Yehuda Katz
76cd4cb27e Memoize in the endpoint. 2009-09-12 15:38:34 -05:00
Yehuda Katz
ddb4600ce6 Get ActionPack's test running on bundled gems. This should make running tests on new machines, as well as CI, work well. 2009-09-12 15:22:11 -05:00
Yehuda Katz
a8a336cbfc Revert "ruby 1.9 friendly secure_compare" because it breaks CI and Sam Ruby's suite 
This reverts commit 5de75398c4.
 2009-09-12 14:35:03 -05:00
Yehuda Katz
7152a4e9a6 Add per-controller middleware 2009-09-12 13:51:15 -05:00
Eloy Duran
26639e8a45 Removed the version of ActiveRecord::Base#destroyed? that was added in a44a1257d8. 
Because José Valim was cheeky enough to already add it to the master branch.
 2009-09-12 16:16:48 +02:00
Eloy Duran
a144b41cbc Removed some superfluous conditionals from the autosave association validation methods. 
Which are unneeded now that we only define them when needed.
 2009-09-12 16:04:47 +02:00
Alexey Kovyrin
938c0ee045 Define autosave association validation methods only when needed. [#3161 state:resolved] 
Signed-off-by: Eloy Duran <eloy.de.enige@gmail.com>
 2009-09-12 16:04:36 +02:00
Eloy Duran
580ec0dccd Added some documentation about setting :autosave => false on an association. 2009-09-12 16:04:25 +02:00
Eloy Duran
65f98951ac During autosave, ignore records that already have been destroyed. [#2537 state:resolved] 2009-09-12 16:04:07 +02:00
Graeme Porteous
c01be9de32 Fix has_one with foreign_key and primary_key association bug which caused the associated object being lost when saving the owner. [#1756 state:resolved] 
Mixed in a bit from patch by ransom-briggs. [#2813 state:resolved]

Signed-off-by: Eloy Duran <eloy.de.enige@gmail.com>
 2009-09-12 16:03:32 +02:00
José Valim
3091252aba Rename nested attributes _delete to _destroy to reflect its actual behavior and DSL (:allow_destroy). Deprecation warning added. [#2889 state:resolved] 
Signed-off-by: Eloy Duran <eloy.de.enige@gmail.com>
 2009-09-12 15:59:32 +02:00
Dmitry Polushkin
845f62f473 Fix autosave association to skip validation if it is marked for destruction. [#2064 state:resolved] 
Signed-off-by: Eloy Duran <eloy.de.enige@gmail.com>
 2009-09-12 15:56:01 +02:00
Eloy Duran
6cc0b9638f Explicitely setting `autosave => false' should override new_record autosaving. [#2214 state:resolved] 
Original author is Jacob.
 2009-09-12 15:53:15 +02:00
Andrew France
1b78e9bba3 Allow fields_for on a nested_attributes association to accept an explicit collection to be used. [#2648 state:resolved] 
Signed-off-by: Eloy Duran <eloy.de.enige@gmail.com>
 2009-09-12 15:50:05 +02:00
Lance Ivy
a44a1257d8 Don't cascade autosave validation to destroyed children. [#2761 state:resolved] 
Signed-off-by: Eloy Duran <eloy.de.enige@gmail.com>
 2009-09-12 15:40:45 +02:00
Mike Breen
bcd0ef710e Raise an exception with friendlier error message when attempting to build a polymorphic belongs_to with accepts_nested_attributes_for. [#2318 state:resolved] 
Signed-off-by: Eloy Duran <eloy.de.enige@gmail.com>
 2009-09-12 15:37:54 +02:00
sdsykes
3180619c0d Fix habtm associations when using multiple databases 
[#3128]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2009-09-12 02:57:29 -07:00
Jeremy Kemper
8682d76cc9 Revert "Allow frameworks to be required by their gem name" 
This has just been confusing. Better to educate than band-aid.

This reverts commit 18a24274ec.
Originally from http://dev.rubyonrails.org/ticket/8845 [drnic]
 2009-09-12 02:41:01 -07:00
Akira Matsuda
3ce16b4c5f Ruby 1.9 compat: Avoid using the return value of FileUtils.mkdir_p, as it does not return a String but an Array in Ruby 1.9 
[#2018 state:committed milestone:2.3.5]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2009-09-11 19:20:57 -07:00
Akira Matsuda
0990a13500 Ensure validation errors to be ordered in declared order 
[#2301 state:committed milestone:2.3.5]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2009-09-11 18:52:22 -07:00