github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
25,790 Commits 34 Branches 105 Tags
69dcd45aea770ca90bb3e1f8ce4e944dfb37e766
Commit Graph

25790 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Vlad Jebelev
69dcd45aea AR changes to support creating ordered (asc, desc) indexes 2011-11-04 15:45:24 -05:00
Vijay Dev
cb06727b6c add tests for the case where size is explicitly passed to number_field helper 2011-11-04 22:32:40 +05:30
Jon Leighton
76dedf0232 Merge pull request #3517 from arunagw/test_fix_activerecord 
Fix test as one more has_many added
 2011-11-04 07:04:43 -07:00
Arun Agrawal
6da558660c Fix test as one more has_many added 2011-11-04 19:30:59 +05:30
Jon Leighton
0fcf8bfbe9 Merge pull request #3516 from cesario/fix_gemspec 
Synchronize the gemspecs since CHANGELOG has been renamed to CHANGELOG.md
 2011-11-04 06:54:32 -07:00
Franck Verrot
1679aa56f3 Synchronize the gemspecs since CHANGELOG has been renamed to CHANGELOG.md 2011-11-04 14:46:39 +01:00
Jon Leighton
281272ad36 Convert CHANGELOGs to Markdown format. 
Reasons:

 * Markdown reads well as plain text, but can also be formatted.
 * It will make it easier for people to read on the web as Github
   formats the Markdown nicely.
 * It will encourage a level of consistency when people are writing
   CHANGELOG entries.

The script used to perform the conversion is at
https://gist.github.com/1339263
 2011-11-04 12:55:17 +00:00
Jon Leighton
e6cc2ea201 Allow the :class_name option for associations to take a symbol. 
This is to avoid confusing newbies, and to be consistent with the fact
that other options like :foreign_key already allow a symbol or a string.
 2011-11-04 11:17:56 +00:00
José Valim
2c67845271 Merge pull request #3514 from waseem/remove_size_attribute_from_number_field 
Remove 'size' attribute from number_field form helper fixes #3454
 2011-11-04 03:31:39 -07:00
Aaron Patterson
0e407a9041 Merge pull request #1163 from amatsuda/sexier_migration_31 
Sexier migrations
 2011-11-04 03:29:59 -07:00
Waseem Ahmad
56207a3f01 Remove 'size' attribute from number_field form helper fixes #3454 
f.number_field generates <input type="number", size="30"../> which is
invalid HTML5. See: http://dev.w3.org/html5/spec/Overview.html#number-state
 2011-11-04 15:03:02 +05:30
Jeremy Kemper
533a9f84b0 Merge pull request #3507 from jmazzi/issue-3503 
Preserve SELECT columns on the COUNT for finder_sql when possible
 2011-11-03 21:17:15 -07:00
Jon Leighton
b5f908a7ad Stub find_template so that when handle_render_error is called in ActionView::Template, we get to see the actual underlying error rather than a NoMethodError. 
This shows an encoding bug on Ruby 1.9.3.
 2011-11-03 19:08:09 +00:00
Jon Leighton
d486103570 Fix #3271. 
Building the conditions of a nested through association could
potentially modify the conditions of the through and/or source
association.

This is a Bad Thing.
 2011-11-03 15:12:08 +00:00
Jon Leighton
567d454d99 Memoize through association 2011-11-03 13:24:39 +00:00
Jon Leighton
19b2a5f2bd Remove all revelant through records. 
If a record is removed from a has_many :through, all of the join records
relating to that record should also be removed from the through
association's target.

(Previously the records were removed in the database, but only one was
removed from the in-memory target array.)
 2011-11-03 13:13:13 +00:00
Jon Leighton
71bc921ec8 Fix adding multiple instances of the same record to a has_many :through. 
Fixes #3425.
 2011-11-03 12:39:05 +00:00
Jon Leighton
b4b178f7e9 Fix #3247. 
Fixes creating records in a through association with a polymorphic source
type.
 2011-11-03 10:23:42 +00:00
José Valim
982a0f37f5 Merge pull request #3494 from sinisterchipmunk/usage-erb 
treat USAGE as an ERB template
 2011-11-02 06:41:46 -07:00
Colin MacKenzie IV
5745a5e85e treat USAGE as an ERB template 2011-11-02 09:00:18 -04:00
Jeremy Kemper
836b620850 Revert "Disable 1.9.3 builds until upgraded from -preview1 to -rc1" 
This reverts commit 8a6acc17bb.
 2011-11-01 17:41:37 -07:00
Aaron Patterson
62a86748ae this should never return nil, so no use for "try" 2011-10-31 15:17:16 -04:00
Christopher Meiklejohn
6cbe4223a7 Ensure that the format isn't applied twice to the cache key, else it becomes impossible to target with expire_action. 2011-10-31 15:10:07 -04:00
Vijay Dev
1afe269a4a assert_match takes a regexp and a string in that order 2011-10-31 19:01:03 +05:30
José Valim
2407a7ad8d Merge pull request #3477 from rud/stable-migrations-version-order-rebased 
dump_schema_information: explicitly order inserts into schema_migrations
 2011-10-31 03:01:02 -07:00
Laust Rud Jacobsen
ff9c2799c1 dump_schema_information: explicitly order inserts into schema_migrations table 
This change reduces churn in the db/development_structure.sql file when using :sql as
active_record.schema_format, and makes comparing diffs much easier.

Test ensures the output SQL-statements are lexically ordered by version.
 2011-10-31 10:36:13 +01:00
Santiago Pastorino
818bf1da0e Merge pull request #3469 from kennyj/dont_use_old_code 
Refactor ActiveSupport::Cache::FileStore.
 2011-10-30 09:42:39 -07:00
kennyj
7670a5187d Refactor ActiveSupport::Cache::FileStore. used method and deleted duplicate code. 2011-10-30 21:50:17 +09:00
Vijay Dev
3e6ecfb454 Merge pull request #3468 from kennyj/fix_a_document_for_compress_limit 
fix a document for :compress_threshold. DEFAULT_COMPRESS_LIMIT is 16K.
 2011-10-30 03:29:18 -07:00
kennyj
38da6249f0 fix a document for :compress_threshold. DEFAULT_COMPRESS_LIMIT is 16K. 2011-10-30 19:18:23 +09:00
Xavier Noria
c6b933faa9 prefer qualified constant "name" to "reference expression", much simpler 2011-10-30 02:25:25 -07:00
Vijay Dev
c809de8291 Merge branch 'master' of github.com:lifo/docrails 2011-10-30 14:47:23 +05:30
Xavier Noria
9d1ba3755e fixes a typo (thanks to Alexey Vakhov) 2011-10-30 02:08:59 -07:00
Santiago Pastorino
75ee4d97ef Merge pull request #3464 from kennyj/avoid_to_call_twice 
avoided to call `Marshal.dump` twice
 2011-10-29 19:18:46 -07:00
Xavier Noria
11f6795b23 defines Module#qualified_const_(defined?|get|set) and String#deconstantize 
This commit also implements a faster version of #demodulize I was unable
to isolate with git add --patch.

Not a big fan of the name #deconstantize. It complements #demodulize
getting rid of the rightmost constant, hence the name, but it is
unrelated to the well-known #constantize. So unsure. Could not come
with anything better, please feel free to rename.
 2011-10-29 18:10:45 -07:00
Santiago Pastorino
8ef1bd9b29 Merge pull request #3463 from kennyj/fix_document_for_cache 
fix a document for race_condition_ttl. ActiveSupport::Cache::MemoryCache isn't exist.
 2011-10-29 17:53:00 -07:00
Jeremy Kemper
eabda416b7 Removing db/seeds.rb is fine. Don't blow up. 2011-10-29 14:14:13 -07:00
kennyj
3b546afd04 avoided to call twice 2011-10-30 03:14:35 +09:00
kennyj
7b65d12db5 fix a document for race_condition_ttl. ActiveSupport::Cache::MemoryCache isn't exist 2011-10-30 01:55:09 +09:00
José Valim
e848bcacdd Merge pull request #3462 from kennyj/remove_deprecated_code 
removed a reference to SynchronizedMemoryStore and CompressedMemCacheStore
 2011-10-29 09:40:28 -07:00
kennyj
596d625c9b removed reference to SynchronizedMemoryStore and CompressedMemCacheStore (the remaining code from 9cafc28874) 2011-10-30 01:32:02 +09:00
José Valim
e886f97669 Merge pull request #3337 from htanata/fix_rake_routes_for_controller_only_route 
Remove trailing "#" on rake routes for controller only routes
 2011-10-29 09:03:45 -07:00
Xavier Noria
e22a4c6f28 Merge pull request #3460 from arunagw/method_redefine_warning_removed 
method redefined warning removed!
 2011-10-29 06:20:21 -07:00
Hendy Tanata
010622bb98 On inpsect routes, show :controller and :action to indicate dynamic. 2011-10-29 20:04:33 +08:00
Arun Agrawal
3fa8f362ad method redefined warning removed! 2011-10-29 16:09:50 +05:30
Vijay Dev
74f3f19a83 Merge pull request #3459 from arunagw/running_test_doc_fix 
ActiveRecord is no more in controller directory.
 2011-10-29 01:53:06 -07:00
Xavier Noria
0fc531392d let demodulize do less work, and add tests 
This is also faster on 1.9.
 2011-10-29 01:07:54 -07:00
Arun Agrawal
0c7c1dbc41 ActiveRecord is no more in controller directory. 2011-10-29 12:34:08 +05:30
Joost Baaij
f936996f69 Updated links to authentication plugins. 
Removed mention of restful_authentication.
Added devise and authlogic.
Also mention Rails 3.1 built-in logic.
 2011-10-28 13:24:14 +02:00
José Valim
2e74334abd Merge pull request #3456 from pwim/documentation-fix 
Add missing type to number_field_tag documentation
 2011-10-27 23:42:22 -07:00