Commit Graph

2088 Commits

Author SHA1 Message Date
Marcel Molina
6b59011862 Skip directories when checking for identical source and destination files.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2495 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-08 18:57:14 +00:00
Marcel Molina
a7cdaadd19 Evaluate dynamic templates before checking if the new file is identical to the old one.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2494 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-08 18:40:00 +00:00
Marcel Molina
d451044ece Make the generator skip a file if it already exists and is identical to the new file.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2493 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-08 16:56:36 +00:00
Jeremy Kemper
31baeeef1b Look here, braces: gimme some elbow room. #2418
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2492 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-08 13:45:20 +00:00
Marcel Molina
80cd2f6645 Move require_library_or_gem out of AR's abstract_adapter and into ActiveSupport. closes #1992
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2490 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-08 07:48:37 +00:00
Jeremy Kemper
60a60f9798 Don't tell me about defined reader methods, even at debug level.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2489 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-07 18:22:40 +00:00
Marcel Molina
f218771d3e Add option (true by default) to generate reader methods for each attribute of a record to avoid the overhead of calling method missing. In partial fullfilment of #1236.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2483 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-07 00:53:05 +00:00
Marcel Molina
c0899bca10 Add convenience predicate methods on Column class. In partial fullfilment of #1236.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2482 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-06 23:19:55 +00:00
Marcel Molina
e8b427cdef Raise an exception when invalid options are passed to ActiveRecord::Base.find. Closes #2363.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2481 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-06 22:21:10 +00:00
Jeremy Kemper
bcb50f3c89 sqlite topics.approved should default to true like the other dbs
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2480 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-06 21:52:47 +00:00
Jeremy Kemper
c2da5e57cd Remove straggling symbolize_strings_in_hash from [2427].
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2479 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-06 17:16:47 +00:00
Jeremy Kemper
164625ca1f Fixup tests for [2474].
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2478 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-06 17:13:24 +00:00
Tobias Lütke
ebfddf35b9 Add rename_table to mysql, sqlite and postgres adapters for use in migrations
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2477 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-06 14:10:45 +00:00
Michael Koziarski
7e70fc1e9d Allow in memory sqlite DBs when RAILS_ROOT is defined [blair@orcaware.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2476 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-06 04:56:00 +00:00
Jeremy Kemper
78d6cc085a smallint -> boolean in pg sql
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2475 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-06 04:52:32 +00:00
Michael Koziarski
656fb866f9 Quote booleans according the rules defined by the adapter
* SQLite schema has been updated
* Postgresql schema needs to be fixed too
Simplify AR::Base#toggle to store the boolean, not the quoted value
* expand the tests


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2474 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-06 04:15:14 +00:00
David Heinemeier Hansson
0639e1ca7c Added :force option to create_table that'll try to drop the table if it already exists before creating
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2473 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-06 03:20:28 +00:00
David Heinemeier Hansson
0da7142c45 Dont repeat yourself
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2472 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-06 03:13:23 +00:00
David Heinemeier Hansson
0b70320e04 Dont include script/process dir
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2471 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-06 02:21:49 +00:00
David Heinemeier Hansson
7346f3de77 Dont include run
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2470 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-06 02:19:51 +00:00
David Heinemeier Hansson
a9f34eaa0f Backed out of script/run portal idea. Muscle memory too deep
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2469 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-06 02:05:36 +00:00
Jeremy Kemper
eb54de9992 Keep Units and Functionals around for those who don't upgrade their app right away.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2468 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-05 22:47:50 +00:00
Jamis Buck
4efdee4ea5 Load plugins last
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2467 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-05 18:31:30 +00:00
Jamis Buck
445873af19 prepend to load path before loading the plugin
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2466 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-05 18:28:34 +00:00
Jamis Buck
7a854b5379 Add experimental plugin support #2335
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2465 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-05 18:25:15 +00:00
Jamis Buck
d364164763 Schema dumper should emit ":default => false" if the default for a column is false
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2464 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-05 13:37:00 +00:00
David Heinemeier Hansson
f510b09c28 Made the documentation about render template/file sane
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2446 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-03 21:20:52 +00:00
Jamis Buck
ac419a0655 Add :rfc822 as an option for Time#to_s (to get rfc822-formatted times)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2445 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-03 18:30:03 +00:00
Jamis Buck
33f78d8227 Chain the const_missing hook to any previously existing hook so rails can play nicely with rake
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2440 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-03 15:28:08 +00:00
David Heinemeier Hansson
f13534e65f Forced newer versions of RedCloth to use hard breaks [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2437 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-02 20:24:53 +00:00
David Heinemeier Hansson
810ebf7c6a Forced newer versions of RedCloth to use hard breaks [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2436 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-02 20:21:43 +00:00
Jeremy Kemper
e19bd169fa Association validation does not belong in a before_save callback: move it into a validation method. Restores the expected model.valid? == model.save. Add tests for cancelling save by returning false from a before_save callback. Remove assumption that before_destroy's return value indicates whether the record was destroyed.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2434 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-02 02:00:50 +00:00
David Heinemeier Hansson
c6d8a1f975 Use a nicer date format
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2433 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-01 19:00:28 +00:00
David Heinemeier Hansson
c69160a90d Better logging about partials when logger to to debug
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2432 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-01 19:00:06 +00:00
Thomas Fuchs
e7afaf62bd Added new scriptaculous options for auto_complete_field #2343 [m.stienstra@fngtps.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2431 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-01 05:43:53 +00:00
Jamis Buck
1e08d11579 Don't prepend the asset host if the string is already a fully-qualified URL
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2430 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-30 19:10:20 +00:00
David Heinemeier Hansson
11de94748e Run set load path so others can do boot and get path
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2429 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-30 15:13:44 +00:00
David Heinemeier Hansson
241b842be1 Update the spinner to the latest commands
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2428 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-30 13:46:14 +00:00
Jeremy Kemper
f98ec352b6 Get rid of old symbolize_strings_in_hash.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2427 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-30 12:10:04 +00:00
Jeremy Kemper
ee5fe97ac4 Ticket #2282 - fix parsing of timestamps with time zone
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2426 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-30 12:09:13 +00:00
David Heinemeier Hansson
3b108e7d35 Dont redefine RAILS_ENV once set
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2425 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-30 11:11:21 +00:00
David Heinemeier Hansson
562b69829d Not the avenue we want to go down
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2424 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-30 08:13:46 +00:00
David Heinemeier Hansson
735f08aca0 Made the order of framework settings significant so config.action_controller.allow_concurrency can be specified before config.action_controller.fragment_cache_store, which relies on the value of the former
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2423 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-30 07:20:57 +00:00
David Heinemeier Hansson
d994b41a05 Added method access to OrdredOptions
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2422 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-30 07:14:37 +00:00
David Heinemeier Hansson
28329ec8f8 Include OrderedOptions by default
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2421 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-30 07:07:44 +00:00
David Heinemeier Hansson
ab2a24de9d Added test for looping in order
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2420 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-30 07:02:28 +00:00
David Heinemeier Hansson
9f146ea0ac Added OrderedOptions array/hash for use with initializer
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2419 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-30 06:51:42 +00:00
Jeremy Kemper
3f1aad8ac9 No need to string.to_s right after checking that string.is_a?(String)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2418 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-30 04:34:07 +00:00
Jeremy Kemper
e828657973 Move transaction thread-safety test to transactions_test. Check that simultaneous transactions don't step on each others' toes. Check that simultaneous transactions don't give dirty reads (read-committed txn isolation or greater.)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2417 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-30 03:39:15 +00:00
Jeremy Kemper
4ce9b4c557 Use transactional fixtures by default for AR tests. Set ENV['AR_NO_TX_FIXTURES'] to yes to disable. Tidy up abstract_unit.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2416 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-30 01:00:04 +00:00