github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
17,676 Commits 34 Branches 105 Tags
6d6ed5532416aa75889cd34a669696ba640abeb5
Commit Graph

4183 Commits

Author SHA1 Message Date
Aaron Patterson
6d6ed55324 avoid passing AR::Base objects to Arel when we can 2010-08-03 17:58:56 -07:00
RainerBlessing
7e4e1f0ca5 query value is converted to_s instead of to_yaml 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-08-03 21:08:43 -03:00
wycats
c0fa4de65b Allow :name to be a Symbol (was this removed by accident?) 2010-08-03 12:22:36 -07:00
Aaron Patterson
41c1aa607d order query is already a string, no need to to_s 2010-08-03 09:16:01 -07:00
Neeraj Singh
db1c484c55 Dynamic finder method like scoped_by_* create methods so that 
method_missing is not hit next time. Adding a test for this
scenario.

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-03 10:46:09 +02:00
Neeraj Singh
807239f5a1 Making Active Record base_test.rb thinner by moving tests 
to relevant files.

Number of assertions before refactoring:
2391 tests, 7579 assertions, 0 failures, 0 errors

Number of assertions after refactoring:
2391 tests, 7579 assertions, 0 failures, 0 errors

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-03 10:45:54 +02:00
Xavier Noria
4dc2521028 Merge remote branch 'docrails/master' into 3-0-stable 2010-08-03 02:15:12 +02:00
Neeraj Singh
db0e3e5ad1 Correcting the documentation which wrongly states that each dynamic finder creates 
method on the class. Only dynamic finders using <tt>scoped_by_*</tt> creates new
methods.
 2010-08-02 13:10:32 -04:00
Neeraj Singh
d3eacf9352 Adding to AR::Base documentation about dynamically scopeded_by query 
User.scoped_by_user_name('David')
 2010-08-02 13:07:18 -04:00
Neeraj Singh
1ce40ca562 ensuring that description does not exceed 100 columns 2010-08-02 12:25:26 -04:00
José Valim
9effe3cc18 Remove duplicated logic. 2010-08-02 17:20:17 +02:00
Neeraj Singh
009aa8825b Eager loading an association should not change the count of children 
[#4971 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-02 17:12:59 +02:00
Neeraj Singh
b8d9d9ce0a updating documentation to ensure line does not exceed 100 columns 2010-08-02 11:09:31 -04:00
José Valim
e1344bf504 Tidy up previous commit. 2010-08-02 16:51:08 +02:00
Robert Pankowecki
f8b53f35b9 test and fix collection_singular_ids= with string primary keys [#5125 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-02 16:41:20 +02:00
José Valim
b613c3cc7b Add an internal (private API) after_touch callback. [#5271 state:resolved] 2010-08-02 16:16:46 +02:00
Jakub Kuźma
311ea94f73 added failing touch propagation test 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-08-02 15:56:49 +02:00
Neeraj Singh
b29c23a618 ensuring that documentation does not exceed 100 columns 2010-08-01 21:32:36 -04:00
Neeraj Singh
6ac9482905 ensuring that documentation does not exceed 100 columns 2010-07-31 07:12:29 -04:00
Neeraj Singh
69b401220c adding the missing closing tag 2010-07-31 07:04:08 -04:00
Neeraj Singh
4f63294b0f fixing documentation just a little bit 2010-07-31 06:55:33 -04:00
Xavier Noria
3d7099891f Merge remote branch 'rails/master' 2010-07-31 11:55:24 +02:00
Aaron Patterson
834e304b22 reverting where() functionality, adding a test 2010-07-30 14:12:01 -07:00
Aaron Patterson
ecfb252e7a fewer method calls, using faster methods when possible 2010-07-30 14:05:26 -07:00
Aaron Patterson
d1c53a9ad2 reducing function calls and using faster methods for testing 2010-07-30 13:38:09 -07:00
Neeraj Singh
0e20e3ebc2 returns not returned . fixing documentation for reflection 2010-07-30 14:43:43 -04:00
Tarmo Tänav
2ea922bcec Don't increment and then decrement the same counter when re-assigning a belongs_to association 
[#2786 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-07-29 22:37:20 -03:00
Xavier Noria
ccd45618ed Merge remote branch 'rails/master' 2010-07-30 02:35:24 +02:00
Xavier Noria
755af49755 edit pass to apply API guideline wrt the use of "# =>" in example code 2010-07-30 02:30:04 +02:00
Aaron Patterson
a7a6a2ff46 got the ternary backwards. somehow the sqlite tests passed! 2010-07-29 16:08:30 -07:00
Aaron Patterson
f171bc64a2 PERF: avoiding splat args and reducing function calls 2010-07-29 14:55:57 -07:00
Neeraj Singh
e42945333b moving time zone related documentation to timestamp.rb from base.rb 2010-07-29 10:37:38 -04:00
Neeraj Singh
873c5a9e59 adding documentation regarding time_zone_aware_attributes and skip_time_zone_conversion_for_attributes 2010-07-29 10:29:33 -04:00
José Valim
0f0bdaea7b Revert "Avoid uneeded queries in session stores if sid is not given." 
First step to merge Rails and Rack session stores. Rack always expects to receive the SID since it may have different behavior if the SID is nil.

This reverts commit e210895ba9.
 2010-07-29 09:10:01 +02:00
Aaron Patterson
d69949ed0d Shouldn't have committed this! Revert "avoid calling to_sql twice" 
This reverts commit 1c030a3c3c.
 2010-07-28 17:03:52 -07:00
Aaron Patterson
1c030a3c3c avoid calling to_sql twice 2010-07-28 17:01:32 -07:00
Simon Tokumine
f46e841f72 removed ambiguity from autosave description 2010-07-28 14:56:05 -07:00
Neeraj Singh
31f8a0cd23 adding punctuations 2010-07-28 13:10:04 -04:00
Neeraj Singh
51924d49af more documentation for update_attribute 2010-07-28 12:51:36 -04:00
Aaron Patterson
fe9d7abb39 slight performance improvement when grabbing an arel table 2010-07-27 21:05:11 -07:00
Jon Buda
9d109302f1 fixed joining of attributes when using find_or_create_by with multiple attributes through an association 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-07-28 00:42:48 -03:00
Xavier Noria
67e79cf96d Revert "Frameworks are loaded in application.rb rather than config.rb according to Rails 3 conventions." 
This reverts commit 1793b21479.

This commit had no risk, but docrails has a hard rule about touching code.
The contribution is appreciated, I hope you do not mind this technical
revert. I'll apply that to master with proper credit.
 2010-07-27 23:31:59 +02:00
Brian Smith
1793b21479 Frameworks are loaded in application.rb rather than config.rb according to Rails 3 conventions. 2010-07-27 14:27:15 -07:00
Neeraj Singh
c9fe3c3bd0 adding comments to update_attribute method 2010-07-27 13:55:00 -04:00
Santiago Pastorino
4ac3ae0685 missing requires added 2010-07-26 16:26:07 -03:00
David Heinemeier Hansson
856fc4bbc3 Prep for RC 2010-07-26 12:53:25 -05:00
José Valim
dd61a817de Move runtime back to the Thread.current 2010-07-26 19:14:56 +02:00
Neeraj Singh
a44652baed No need to check for :uniq 
[#5170 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-26 17:41:04 +02:00
Thiago Pradi
f70c0b348d Removing unnecessary code [#5192 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-26 17:13:52 +02:00
Santiago Pastorino
963c71edfa Don't interpolate a blank string, avoid warnings 2010-07-26 06:42:44 +08:00