Yehuda Katz
6faff0223b
Merge commit 'rails/3-0-unstable'
2009-02-02 09:54:27 -08:00
Yehuda Katz
44cdf0c5fe
Some merge cleanup
2009-02-02 09:54:23 -08:00
Jeremy Kemper
4945d92b03
Remove dead cgi_ext require
2009-01-31 14:46:02 -08:00
Jeremy Kemper
8da52b13b5
Remove duplicate ConcurrentHash
2009-01-31 14:44:04 -08:00
Yehuda Katz
3030bc90c9
Merge commit 'rails/3-0-unstable'
...
Conflicts:
actionpack/lib/action_controller/base.rb
actionpack/lib/action_dispatch/http/mime_type.rb
actionpack/lib/action_dispatch/http/request.rb
actionpack/lib/action_view/base.rb
actionpack/lib/action_view/paths.rb
actionpack/test/controller/session/cookie_store_test.rb
actionpack/test/dispatch/rack_test.rb
actionpack/test/dispatch/request_test.rb
2009-01-30 11:30:27 -08:00
Yehuda Katz
ae42163bf5
Merge branch 'master' of git@github.com:wycats/rails
2009-01-30 11:01:11 -08:00
Yehuda Katz
da10673e32
Sync 'rails/rails/master'
2009-01-30 10:53:19 -08:00
Charles Nutter
ed0e564087
Ensure constant_watch_stack is protected by a mutex, so concurrent requires do not corrupt it.
...
[#1816 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-01-30 08:27:03 -08:00
Scott Taylor
2dedb5b03a
Controller, response, and request should all refer to same session, even after a call to session_reset [ #1823 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-01-29 19:39:48 -06:00
Mike Gaffney
1b79683171
Deprecation tests for f17c876 [ #1801 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-01-29 19:37:38 -06:00
Pratik Naik
b3bc4fa5e0
Digest#validate_digest_response should accept request instead of controller
2009-01-29 22:06:03 +00:00
Jon Crawford
8761663a68
Added grouped_options_for_select helper method for wrapping option tags in optgroups. [ #977 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-01-29 18:00:18 +00:00
Gregg Kellogg
306cc2b920
Implement HTTP Digest authentication. [ #1230 state:resolved] [Gregg Kellogg, Pratik Naik]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-01-29 16:01:59 +00:00
Joshua Peek
85750f22c9
Move dispatch related tests into test/dispatch
2009-01-28 22:50:46 -06:00
Jacob Dunphy
e6493eb9b7
Sqlite adapter's copy_table incorrectly attempts to recreate a primary key id (:id => true in the create_table) if an :id column is present, even if it isn't a primary_key.
...
This fix sets :id => false if there is an :id column, but it's not the primary_key.
Signed-off-by: Michael Koziarski <michael@koziarski.com >
[#1766 state:committed]
2009-01-29 17:34:33 +13:00
Michael Koziarski
feed7b4cfd
Move to use pg instead of postgres on the CI server
2009-01-29 17:07:29 +13:00
Joshua Peek
2e69db18ce
Only dup local cache values if duplicable [ #1653 state:resolved]
2009-01-28 21:20:46 -06:00
Pratik Naik
a1a9889b06
Move basic auth test controller inside the test class
2009-01-29 01:59:55 +00:00
Bob Aman
166c63818e
Improve exception handling when Location header is invalid. [ #1192 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-01-28 20:56:46 +00:00
Dan Weinand
91eeb0ff11
Using the highlight helper on text with html shouldn't highlight text inside html attributes. [ #1302 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-01-28 19:53:59 +00:00
Filip H.F. "FiXato" Slagter
a0d8202bb9
Ensure whitespaces are stripped when merging string joins. [ #1297 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-01-28 19:50:55 +00:00
Bryan Ray
f725b19710
Added options to script/dbconsole to sqlite3 console in various different modes. [ #607 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-01-28 19:47:45 +00:00
Rasik Pandey
6079ec1f77
ActiveResource#eqls? and == should not take into account object identity and prefix options should be considered. [ #1098 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-01-28 19:39:06 +00:00
Daniel Rodríguez Troitiño
9a8e2a059c
Ensure selected option is not ignored for collection_select. [ #1037 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-01-28 19:35:18 +00:00
Nathan de Vries
32eeb3e521
Ensure that when UrlWriter is included in multiple classes, the default_url_options of one don't affect the other. [ #1277 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com >
2009-01-28 19:31:48 +00:00
Pratik Naik
74871961ec
Add array id support to Model.update_counters. [ #1254 state:resolved] [Carlos Júnior]
2009-01-28 19:20:55 +00:00
Pratik Naik
2ae8d3079b
Session cookie header should always be set if :expire_after option is specified
2009-01-28 05:05:48 +00:00
Joshua Peek
319ae4628f
Move HTTP libs and middleware into ActionDispatch component
2009-01-27 18:54:01 -06:00
Joshua Peek
a0f2b1d95d
Reorganize ActionController folder structure
2009-01-27 18:17:39 -06:00
Jeremy Kemper
9714a9b001
Use toplevel reference to ::StringIO since we're in a BasicObject.
2009-01-27 15:25:05 -08:00
David Heinemeier Hansson
e73445ba1b
Merge branch 'master' of git@github.com:rails/rails
2009-01-27 16:13:23 -06:00
Tys von Gaza
dd02af5c7e
Fix for sweepers method_missing missing &block argument [ #1581 status:committed]
...
Signed-off-by: David Heinemeier Hansson <david@loudthinking.com >
2009-01-27 16:11:45 -06:00
Joshua Peek
f716ab92bf
Disable eager loading for all rake tasks [ #802 state:resolved]
2009-01-27 15:53:02 -06:00
Joshua Peek
093f758bd0
Restore implicit rendering for XHR requests that want a HTML template [ #1590 state:resolved]
2009-01-27 14:09:11 -06:00
Joshua Peek
f17c87665e
Fixed deprecated methods on TestSession [ #1801 state:resolved]
2009-01-27 12:28:05 -06:00
Pratik Naik
57b156b338
Dont use Memoizable for ActionController::Request
2009-01-27 17:26:37 +00:00
Yaroslav Markin
17db28f1ca
Improve i18n support for number_to_human_size helper:
...
* now using pluralization properly
* storage unit translations moved to number.human.storage_units.units
* introduced number.human.storage_units.format for languages that do not follow "{{number}} {{unit}}" format (Japanese)
NOTE: I18n table changed, you will need to update your translations.
[#1634 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2009-01-27 09:22:00 -08:00
Joshua Peek
a1ac635d96
Ensure the full path is used when searching for layouts [ #1803 state:resolved]
2009-01-27 11:08:29 -06:00
Dov Murik
5fe6635e05
Mysql#reconnect is set according to the 'reconnect' key in the connection spec.
...
The 'reconenct' boolean option is read from the connection specification
and is used to set the reconnect attribute of Mysql. The default is
false in order not to change existing application behaviour.
Also, reconnect is set AFTER real_connect is called, so its value sticks
(the mysql gem sets reconnect to false inside real_connect).
Signed-off-by: Michael Koziarski <michael@koziarski.com >
[#1797 state:committed]
2009-01-27 09:55:25 +13:00
Joshua Peek
57f0b85900
Fix for failing ActionMailer multipart tests
2009-01-26 13:15:29 -06:00
Joshua Peek
a98cd7ca9b
Add localized templates
...
# Default locale
app/views/messages/index.html.erb
# I18n.locale is set to :da (Danish)
app/views/messages/index.da.html.erb
2009-01-25 22:51:21 -06:00
Sven Fuchs
5c062bf100
add #available_locales to I18n and I18n::SimpleBackend, flatten translations load_path when loading translations [ #1714 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com >
2009-01-25 22:51:21 -06:00
Greg Borenstein
f4bf318db0
add an inspect method to OrderedHash to make it clear that it is not a species of Array
...
Signed-off-by: Michael Koziarski <michael@koziarski.com >
[#1782 state:committed]
2009-01-26 16:26:37 +13:00
Stephen Bannasch
4ef9845aa3
Adding AR tests for JDBC connections
...
New connections:
jdbcmysql jdbcpostgresql jdbcsqlite3 jdbcderby jdbch2 jdbchsqldb jdbcpostgresql
To test you will need the native database installed (if one is required),
activerecord-jdbc-adapter and the specific activerecord-jdbc<database>-adapter
for the database you are testing.
Run the tests like this:
jruby -S rake test_jdbcmysql
Signed-off-by: Michael Koziarski <michael@koziarski.com >
[#1685 state:committed]
2009-01-26 16:08:44 +13:00
Pratik Naik
617ad23574
Remove the irrelevant fixture added in fe6ffce51d
2009-01-24 18:22:17 +00:00
Pratik Naik
fe6ffce51d
Make sure inner scope conditions get a preference over the outer ones
2009-01-24 17:54:10 +00:00
Pratik Naik
b2192888ab
Fix the changelog entry
2009-01-23 15:38:19 +00:00
Yehuda Katz
eb9af20b7c
Begin unifying the interface between ActionController and ActionView
2009-01-22 16:18:10 -06:00
Joshua Peek
cc0b5fa993
Merge branch 'master' into 3-0-unstable
...
Conflicts:
ci/cruise_config.rb
2009-01-22 15:13:47 -06:00
Josh Susser
ccda96093a
Minor refactoring of validates_associated to replace #inject with #collect + #all?
...
[#1686 state:committed]
2009-01-22 13:45:19 +13:00