github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
17,451 Commits 34 Branches 105 Tags
7113f207c34e41ffcbbd0b3570f3fe41bbfbbcaf
Commit Graph

17451 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Santiago Pastorino
7113f207c3 This is a VARCHAR not a TEXT 2010-07-22 15:48:57 -03:00
Santiago Pastorino
1b8cd5fb53 MySQL can't index a TEXT column 2010-07-22 15:48:55 -03:00
Santiago Pastorino
21c4b0942f Don't shadow outer local variables 2010-07-22 15:48:52 -03:00
Carlhuda
ba8d89c4c8 Performance optimizations to handle cases of instrumentors that are not listened to. Also, fix a possible concurrency issue. 2010-07-22 11:36:16 -07:00
Aaron Patterson
97f3c7387e refactor to use instance methods and be kind to subclasses 2010-07-22 09:38:56 -07:00
Aaron Patterson
38734aff20 adding a test for session save 2010-07-22 09:35:50 -07:00
Santiago Pastorino
30df88ae06 These tests are trusting in the order of the elements so use OrderedHash instead of Hash 2010-07-21 17:34:43 -07:00
Santiago Pastorino
a1e795f554 options could be of any kind of Hash (Hash, HashWithIndifferentAccess or OrderedHash) this way we keep the properties of the options passed as an argument 2010-07-21 17:34:02 -07:00
Aaron Patterson
a78547a9c6 testing loaded? method and reducing funcalls 2010-07-21 16:59:23 -07:00
Aaron Patterson
87a319cd0c testing new_record? and converting to an attribute 2010-07-21 16:55:04 -07:00
Aaron Patterson
f5de56f537 reducing function calls in the session store 2010-07-21 16:52:15 -07:00
Aaron Patterson
4e6cf429a1 readability is hip 2010-07-21 16:45:38 -07:00
Aaron Patterson
ba0d2a9ce3 starting sql bypass test, fixing create_table and drop_table! 2010-07-21 16:36:28 -07:00
Aaron Patterson
bdbe390a98 initializing instance variables 2010-07-21 16:36:28 -07:00
Aaron Patterson
1f8edb996b adding tests for sessions and clearing up warnings 2010-07-21 16:36:28 -07:00
Xavier Noria
b456877cfb camelize and underscore are sort of inverse of each other, but not in a mathematical sense [#5174 state:resolved] 2010-07-22 01:28:31 +02:00
Xavier Noria
b72cc472f7 routing guide: say "path" when you mean path 2010-07-22 01:28:31 +02:00
Xavier Noria
e9127ce7e8 routing guide: a "photo" resource has by convention paths under "photos", in plural 2010-07-22 01:28:31 +02:00
Wincent Colaiuta
198975ecee doc: form_for does return output rather than merely evaluate its block 2010-07-22 01:28:31 +02:00
Jeroen van Dijk
ab62aa1c43 Mention that ActionMailer::Base.default_url_options is now deprecated 2010-07-22 01:28:31 +02:00
Jaime Iniesta
6f7402d32b non-singleton true and false should go on regular font 2010-07-22 01:28:31 +02:00
Jaime Iniesta
402aaa56f5 Active Record Validations and Callbacks guide: Fixed typos and rephrased some paragraphs for clarity 2010-07-22 01:28:30 +02:00
Neeraj Singh
5c137939a7 expanded comment for update_attribute method 2010-07-22 01:28:30 +02:00
Mislav Marohnić
efdfcf1325 correct typos in Routing examples 2010-07-22 01:28:30 +02:00
Neeraj Singh
aa2235be7b replacing around with for in the comments for callbacks 2010-07-22 01:28:30 +02:00
Santiago Pastorino
6cbd085f69 Test Hash#to_param escapes keys and values 
[#5175]
 2010-07-22 06:29:59 +08:00
Santiago Pastorino
5c85822008 Hash#to_param is doesn't use sort anymore, some tests added for Hash#to_param 2010-07-22 06:23:13 +08:00
Subba Rao Pasupuleti
b0c7dee4f2 removing unused models from tests 
[#5153 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-21 22:08:07 +02:00
Brian Rose
622092d33e Fixed a globbed route issue where slashes were being escaped, causing assert_routing to fail. [#5135 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-21 22:07:40 +02:00
Santiago Pastorino
d16c5cc99b Change some missing README -> README.rdoc 2010-07-22 01:47:06 +08:00
Andrew Kaspick
a1a41a3939 remote_function patch with more detailed test 
Signed-off-by: wycats <wycats@gmail.com>
 2010-07-21 10:04:55 -07:00
Santiago Pastorino
ef5ae60a07 Make use of tap to return a previously used var 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-21 17:17:23 +02:00
Santiago Pastorino
e107c208f0 Make config.generators accept string namespaces, you can do now config.generators.test_framework 'rspec' for instance 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-21 17:17:23 +02:00
Santiago Pastorino
79d6f314c6 We are doing the same in this conditions 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-21 17:17:22 +02:00
Neeraj Singh
659e3b02ab renaming tests by removing proxy_options from names 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-21 15:25:39 +02:00
José Valim
e13e8dcf44 Use capture instead of yield in link_to_unless. 
[#5162 state:resolved]
 2010-07-21 15:23:14 +02:00
José Valim
9dfe9fa693 Ensure insert_before in middleware stack raises a meaningful error message [#3679 state:resolved] 2010-07-21 15:17:04 +02:00
José Valim
7131244313 Ensure default_scope can be overwriten by association conditions. 2010-07-21 15:06:23 +02:00
Subba Rao Pasupuleti
d77c3b669c eagerly loaded association records should respect default_scope [#2931 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-21 15:01:40 +02:00
Neeraj Singh
992711a86b update_attribute should not update readonly attributes 
[#5106 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-21 14:55:57 +02:00
Thiago Pradi
c96a505391 rake db:seed should check if the database have pending migrations [#5163 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-21 14:55:26 +02:00
José Valim
f3e42292a5 Ensure all join table attributes will be in the same timestamp. 2010-07-21 14:51:15 +02:00
Neeraj Singh
8bb3b634c0 Timestamp columns of HABTM join table should record timestamps 
[#5161 state:resolved]
 2010-07-21 14:45:36 +02:00
José Valim
01add55d6a Revert "save on parent should not cascade to child unless child changed [#3353 state:open]" 
Please check Lighthouse for more information.

This reverts commit 4a0d7c1a43.
 2010-07-21 14:44:46 +02:00
Subba Rao Pasupuleti
96b2516c3c Strengthening the test for nested_attribute 
Loading the associate target in nested_attributes
should load most recent attributes for child
records marked for destruction

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-21 14:25:34 +02:00
Szetobo
0057d2df71 association load target shouldn't replace records 
from db if it is already loaded by nested attributes assignment

[#5053 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-21 14:25:27 +02:00
Subba Rao Pasupuleti
c0bfa0bfc1 In nested_attributes when association is not loaded and association 
record is saved and then in memory record attributes should be saved

[#5053 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-21 14:25:19 +02:00
Neeraj Singh
6ba7d5e654 - without the id test is passing even if I change :allow_destroy from 'false' - adding more tests to strengthen the test suite 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-21 14:25:13 +02:00
José Valim
0a729b0a91 Fix failing railties tests. 2010-07-21 14:16:37 +02:00
José Valim
53310614d7 Reuse already existing classes for ActiveModel tests. 2010-07-21 13:00:56 +02:00