github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
17,451 Commits 34 Branches 105 Tags
7113f207c34e41ffcbbd0b3570f3fe41bbfbbcaf
Commit Graph

4839 Commits

Author SHA1 Message Date
Santiago Pastorino
a1e795f554 options could be of any kind of Hash (Hash, HashWithIndifferentAccess or OrderedHash) this way we keep the properties of the options passed as an argument 2010-07-21 17:34:02 -07:00
Wincent Colaiuta
198975ecee doc: form_for does return output rather than merely evaluate its block 2010-07-22 01:28:31 +02:00
Mislav Marohnić
efdfcf1325 correct typos in Routing examples 2010-07-22 01:28:30 +02:00
Brian Rose
622092d33e Fixed a globbed route issue where slashes were being escaped, causing assert_routing to fail. [#5135 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-21 22:07:40 +02:00
Andrew Kaspick
a1a41a3939 remote_function patch with more detailed test 
Signed-off-by: wycats <wycats@gmail.com>
 2010-07-21 10:04:55 -07:00
José Valim
e13e8dcf44 Use capture instead of yield in link_to_unless. 
[#5162 state:resolved]
 2010-07-21 15:23:14 +02:00
José Valim
9dfe9fa693 Ensure insert_before in middleware stack raises a meaningful error message [#3679 state:resolved] 2010-07-21 15:17:04 +02:00
José Valim
0a729b0a91 Fix failing railties tests. 2010-07-21 14:16:37 +02:00
José Valim
c565f0060a No need to delegate. Simply include the whole RecordIdentifier module. 2010-07-21 11:46:38 +02:00
Piotr Sarnacki
6807b08099 Moved a few methods from RecordIdentifier to ActiveModel::Naming 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-21 11:29:58 +02:00
Piotr Sarnacki
a63566dda8 Moved PolymorphicRoutes to ActionDispatch::Routing 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-20 23:12:46 +02:00
José Valim
9df9c4bac0 Add a test for elapsed and require missing benchmark file. 2010-07-20 17:07:18 +02:00
José Valim
51d2db0a63 Add missing require to metal/streaming.rb 2010-07-20 09:56:16 +02:00
Bryan Helmkamp
e466354edb Extract ParameterFilter class from FilterParameters mixin 
Signed-off-by: wycats <wycats@gmail.com>
 2010-07-19 13:44:43 -07:00
José Valim
c3c349ec3e Remove assert_valid. It was already deprecated on Rails 2.3. 2010-07-19 22:35:17 +02:00
Santiago Pastorino
17600eb435 Remove unused orig_handler and unneeded parentheses 2010-07-20 04:32:08 +08:00
José Valim
70f7ba3e3b There is absolutely no need to use __send__ here. 2010-07-19 14:56:09 +02:00
José Valim
ab6ff85906 No need to create a new module in the previous commit. 2010-07-19 14:50:38 +02:00
Neeraj Singh
33c5689e2d Exceptions from views should be rescued based on the original exception. If a handler for original exception is missing then apply ActiveView::TemplateError 
[#2034 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-19 14:50:38 +02:00
José Valim
291adcd588 Set session options id to nil is respected and cancels lazy loading. 2010-07-18 12:51:03 +02:00
Ivan Torres
cdfa11409c select :include_blank or :prompt should return escaped string [#5099 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-18 11:32:00 +02:00
Neeraj Singh
1f499e6d4c fixing the ternary operation where the logic is very confusing. 
[#5136 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-18 11:31:54 +02:00
José Valim
e210895ba9 Avoid uneeded queries in session stores if sid is not given. 2010-07-18 11:02:08 +02:00
Nick Quaranto
7aec9f9c02 Removing ActionDispatch::Http::FilterParameters#fitered_parameters alias 2010-07-18 06:04:55 +08:00
Xavier Noria
631b9564d2 Merge remote branch 'docrails/master' 2010-07-17 20:00:48 +02:00
Carlos Antonio da Silva
c09cd192aa Small fix in cookie docs and trailing whitespaces 2010-07-15 18:41:29 -03:00
Santiago Pastorino
3952268929 Bump up to rack-mount 0.6.9 and rack-mount-0.6.6.pre removed from action_dispatch vendor 2010-07-15 13:18:44 -07:00
Xavier Noria
6d2e4ee96c Merge remote branch 'docrails/master' 2010-07-13 18:41:09 +02:00
Benjamin Quorning
7e075e6247 Fixed many references to the old config/environment.rb and Rails::Initializer 2010-07-13 13:00:21 +02:00
Miles Egan
d2fae5f78e remove size attribute from tag generated by file_field helper [#5084 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-13 08:30:08 +02:00
Santiago Pastorino
d030f830cf Fixes a regression caused by having mapping options controller and action as blank 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-12 19:47:28 +02:00
José Valim
3d7e411953 Routes should respect namespace even if action is a regexp and just controller is given to to. 2010-07-12 15:11:53 +02:00
Steven Hancock
1a35b6215f Removed deprecated |map| block argument from routing docs since it is no longer generated in edge Rails config/routes.rb 
Didn't touch plugins guide since I'm not too clear on how routes work in plugins.
 2010-07-11 23:57:26 -07:00
Xavier Noria
2f04c87855 Merge remote branch 'docrails/master' 2010-07-09 22:08:24 +02:00
Rohit Arondekar
dc364fdc59 API Docs: Fixes to the Routing docs 2010-07-07 22:15:15 -07:00
Jeremy Kemper
81f398b804 Fix setting helpers_path to a string or pathname 2010-07-07 12:03:08 -07:00
Xavier Noria
64c75d6618 Merge remote branch 'docrails/master' 2010-07-07 12:58:46 +02:00
Andrew White
b802a0d4c7 When a dynamic :controller segment is present in the path add a Regexp constraint that allow matching on multiple path segments. 
Using a namespace block isn't compatible with dynamic routes so we
raise an ArgumentError if we detect a :module present in the scope.

[#5052 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-07 00:11:13 +02:00
Andrew White
f4be0041c6 Refactor handling of :only and :except options. The rules are: 
1. Don't inherit when specified as an option on a resource
2. Don't push into scope when specified as an option on a resource
2. Resources pull in :only or :except options from scope
3. Either :only or :except in nested scope overwrites parent scope

[#5048 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-06 20:46:20 +02:00
José Valim
8079484b11 Recognize should also work with route is wrapped in a constraint. 2010-07-06 00:39:13 +02:00
José Valim
6671d9cdc1 RouteSet should also handle anonymous classes. 2010-07-05 21:44:49 +02:00
José Valim
a5dda97602 Define a convention for descendants and subclasses. 
The former should be symmetric with ancestors and include all children. However, it should not include self since ancestors + descendants should not have duplicated. The latter is symmetric to superclass in the sense it only includes direct children.

By adopting a convention, we expect to have less conflict with other frameworks, as Datamapper. For this moment, to ensure ActiveModel::Validations can be used with Datamapper, we should always call ActiveSupport::DescendantsTracker.descendants(self) internally instead of self.descendants avoiding conflicts.
 2010-07-05 13:01:27 +02:00
Andrew White
c6843e2337 Refactor resource options and scoping. Resource classes are now only responsible for controlling how they are named. All other options passed to resources are pushed out to the scope. 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-04 13:20:48 +02:00
Wincent Colaiuta
75b32a69a1 Fixes for "router" and "routes" terminology 
Commit f7ba614c2d improved the internal consistency of the different
means of accessing routes, but it introduced some problems at the level
of code comments and user-visible strings.

This commit applies fixes on three levels:

Firstly, we remove or replace grammatically invalid constructs such as
"a routes" or "a particular routes".

Secondly, we make sure that we always use "the router DSL" or "the
router syntax", because this has always been the official terminology.

Finally, we make sure that we only use "routes" when referring to the
application-specific set of routes that are defined in the
"config/routes.rb" file, we use "router" when referring on a more
abstract level to "the code in Rails used to handle routing", and we use
"routing" when we need an adjective to apply to nouns such as
"url_helpers. Again this is consistent with historical practice and
other places in the documentation.

Note that this is not a sweep over the entire codebase to ensure
consistent usage of language; it is just a revision of the changes
introduced in commit f7ba614c2d.

Signed-off-by: Wincent Colaiuta <win@wincent.com>
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-03 22:42:31 +02:00
Andrew White
54250a5bfe Refactor recall parameter normalization [#5021 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-03 10:06:07 +02:00
José Valim
9e6e648732 Fix routes with :controller segment when namespaced [#5034 state:resolved] 2010-07-02 19:13:00 +02:00
Piotr Sarnacki
f7ba614c2d Unify routes naming by renaming router to routes 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-02 01:51:03 +02:00
Aaron Patterson
f8720a04d1 porting session.clear fix to master branch. [#5030 state:resolved] 
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-07-01 15:17:19 -07:00
Rizwan Reza
a6913bf7eb Added documentation for usage of associative resources with form_for 2010-07-01 23:07:24 +04:30
José Valim
53b34e8476 Avoid calls to Rails::Application since this is not the official API. 
Your application should *always* reference your application const (as Blog::Application) and Rails.application should be used just internally.
 2010-07-01 18:43:44 +02:00