Santiago Pastorino
7113f207c3
This is a VARCHAR not a TEXT
2010-07-22 15:48:57 -03:00
Santiago Pastorino
1b8cd5fb53
MySQL can't index a TEXT column
2010-07-22 15:48:55 -03:00
Aaron Patterson
97f3c7387e
refactor to use instance methods and be kind to subclasses
2010-07-22 09:38:56 -07:00
Aaron Patterson
38734aff20
adding a test for session save
2010-07-22 09:35:50 -07:00
Aaron Patterson
a78547a9c6
testing loaded? method and reducing funcalls
2010-07-21 16:59:23 -07:00
Aaron Patterson
87a319cd0c
testing new_record? and converting to an attribute
2010-07-21 16:55:04 -07:00
Aaron Patterson
f5de56f537
reducing function calls in the session store
2010-07-21 16:52:15 -07:00
Aaron Patterson
4e6cf429a1
readability is hip
2010-07-21 16:45:38 -07:00
Aaron Patterson
ba0d2a9ce3
starting sql bypass test, fixing create_table and drop_table!
2010-07-21 16:36:28 -07:00
Aaron Patterson
bdbe390a98
initializing instance variables
2010-07-21 16:36:28 -07:00
Aaron Patterson
1f8edb996b
adding tests for sessions and clearing up warnings
2010-07-21 16:36:28 -07:00
Neeraj Singh
5c137939a7
expanded comment for update_attribute method
2010-07-22 01:28:30 +02:00
Subba Rao Pasupuleti
b0c7dee4f2
removing unused models from tests
...
[#5153 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-21 22:08:07 +02:00
Santiago Pastorino
d16c5cc99b
Change some missing README -> README.rdoc
2010-07-22 01:47:06 +08:00
Santiago Pastorino
ef5ae60a07
Make use of tap to return a previously used var
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-21 17:17:23 +02:00
Neeraj Singh
659e3b02ab
renaming tests by removing proxy_options from names
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-21 15:25:39 +02:00
José Valim
7131244313
Ensure default_scope can be overwriten by association conditions.
2010-07-21 15:06:23 +02:00
Subba Rao Pasupuleti
d77c3b669c
eagerly loaded association records should respect default_scope [ #2931 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-21 15:01:40 +02:00
Neeraj Singh
992711a86b
update_attribute should not update readonly attributes
...
[#5106 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-21 14:55:57 +02:00
Thiago Pradi
c96a505391
rake db:seed should check if the database have pending migrations [ #5163 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-21 14:55:26 +02:00
José Valim
f3e42292a5
Ensure all join table attributes will be in the same timestamp.
2010-07-21 14:51:15 +02:00
Neeraj Singh
8bb3b634c0
Timestamp columns of HABTM join table should record timestamps
...
[#5161 state:resolved]
2010-07-21 14:45:36 +02:00
José Valim
01add55d6a
Revert "save on parent should not cascade to child unless child changed [ #3353 state:open]"
...
Please check Lighthouse for more information.
This reverts commit 4a0d7c1a43
2010-07-21 14:44:46 +02:00
Subba Rao Pasupuleti
96b2516c3c
Strengthening the test for nested_attribute
...
Loading the associate target in nested_attributes
should load most recent attributes for child
records marked for destruction
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-21 14:25:34 +02:00
Szetobo
0057d2df71
association load target shouldn't replace records
...
from db if it is already loaded by nested attributes assignment
[#5053 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-21 14:25:27 +02:00
Subba Rao Pasupuleti
c0bfa0bfc1
In nested_attributes when association is not loaded and association
...
record is saved and then in memory record attributes should be saved
[#5053 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-21 14:25:19 +02:00
Neeraj Singh
6ba7d5e654
- without the id test is passing even if I change :allow_destroy from 'false' - adding more tests to strengthen the test suite
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-21 14:25:13 +02:00
José Valim
508fba9e07
Add .rdoc extension to README files.
2010-07-21 12:51:14 +02:00
José Valim
f1082bd51e
Remove old install.rb files.
2010-07-21 11:56:28 +02:00
Santiago Pastorino
fa8b290496
id is a public method
2010-07-21 08:19:53 +08:00
Neeraj Singh
f576d7cf84
Ensure that primary_keys of HABTM records is not double quoted
...
[#5152 state:reslved]
2010-07-20 16:45:42 -07:00
Santiago Pastorino
978c49ea6a
Make use of severity levels
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-20 23:10:59 +02:00
José Valim
d4151d7f0a
Fix a failing test in Railtie and properly define all severity levels in MockLogger for LogSubscriber.
2010-07-20 21:21:14 +02:00
Aaron Patterson
e1df4b9568
adding a reader for loaded, initializing @loaded to false
2010-07-20 09:15:09 -07:00
Aaron Patterson
202fb79e86
reusing the time instrumentation from the instrumenter rather than Benchmark. [ #5098 state:open]
2010-07-19 13:44:11 -07:00
Santiago Pastorino
d39c3b179c
Test added, we shouldn't log sql calls when logger is not on debug? mode
2010-07-20 04:32:08 +08:00
Aaron Patterson
1b26c66ce4
mocking out debing? call in the MockLogger
2010-07-19 13:19:28 -07:00
Daniel Guettler
38f0161aab
Minor performance improvment in notifications/fanout and active_record/log_subscriber [ #5098 state:open]
2010-07-19 11:45:50 -07:00
Aaron Patterson
ad4ef4226f
avoid const lookup. we know what these constants are in advance
2010-07-19 10:31:24 -07:00
Łukasz Strzałkowski
bd4b3d8b2f
Added missing require of remove_method
2010-07-19 23:44:50 +08:00
Łukasz Strzałkowski
661fd98aad
Make use of redefine_method, removed some more redefining warnings
2010-07-19 23:44:50 +08:00
Łukasz Strzałkowski
7637b7184a
Test for behaviour of befeore_type_cast when operating on datetime colmun
2010-07-19 23:44:49 +08:00
Łukasz Strzałkowski
010eda2eb5
Removed warnings about method redefining
2010-07-19 23:44:48 +08:00
Łukasz Strzałkowski
247886e1b4
Removed warnings when a variable is shadowed
2010-07-19 23:44:45 +08:00
José Valim
b22c11fa53
Add missing entries and tidy up CHANGELOG.
2010-07-19 15:14:26 +02:00
Neeraj Singh
0fce4ae57f
expected value should come first in assert_equal
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-18 15:13:38 +02:00
Neeraj Singh
6caf943ace
primary_keys_test reads better than pk_test
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-18 15:13:29 +02:00
Neeraj Singh
b58e1c52f7
fixing typo
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-18 15:13:21 +02:00
Neeraj Singh
df6aa8e246
removing extra whitespaces
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-18 15:13:14 +02:00
Subba Rao Pasupuleti
4a0d7c1a43
save on parent should not cascade to child unless child changed [ #3353 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-07-18 11:31:29 +02:00
