github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
17,451 Commits 34 Branches 105 Tags
7113f207c34e41ffcbbd0b3570f3fe41bbfbbcaf
Commit Graph

2122 Commits

Author SHA1 Message Date
Aaron Patterson
38734aff20 adding a test for session save 2010-07-22 09:35:50 -07:00
Aaron Patterson
a78547a9c6 testing loaded? method and reducing funcalls 2010-07-21 16:59:23 -07:00
Aaron Patterson
87a319cd0c testing new_record? and converting to an attribute 2010-07-21 16:55:04 -07:00
Aaron Patterson
ba0d2a9ce3 starting sql bypass test, fixing create_table and drop_table! 2010-07-21 16:36:28 -07:00
Aaron Patterson
bdbe390a98 initializing instance variables 2010-07-21 16:36:28 -07:00
Subba Rao Pasupuleti
b0c7dee4f2 removing unused models from tests 
[#5153 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-21 22:08:07 +02:00
Neeraj Singh
659e3b02ab renaming tests by removing proxy_options from names 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-21 15:25:39 +02:00
José Valim
7131244313 Ensure default_scope can be overwriten by association conditions. 2010-07-21 15:06:23 +02:00
Subba Rao Pasupuleti
d77c3b669c eagerly loaded association records should respect default_scope [#2931 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-21 15:01:40 +02:00
Neeraj Singh
992711a86b update_attribute should not update readonly attributes 
[#5106 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-21 14:55:57 +02:00
Neeraj Singh
8bb3b634c0 Timestamp columns of HABTM join table should record timestamps 
[#5161 state:resolved]
 2010-07-21 14:45:36 +02:00
José Valim
01add55d6a Revert "save on parent should not cascade to child unless child changed [#3353 state:open]" 
Please check Lighthouse for more information.

This reverts commit 4a0d7c1a43.
 2010-07-21 14:44:46 +02:00
Subba Rao Pasupuleti
96b2516c3c Strengthening the test for nested_attribute 
Loading the associate target in nested_attributes
should load most recent attributes for child
records marked for destruction

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-21 14:25:34 +02:00
Szetobo
0057d2df71 association load target shouldn't replace records 
from db if it is already loaded by nested attributes assignment

[#5053 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-21 14:25:27 +02:00
Subba Rao Pasupuleti
c0bfa0bfc1 In nested_attributes when association is not loaded and association 
record is saved and then in memory record attributes should be saved

[#5053 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-21 14:25:19 +02:00
Neeraj Singh
6ba7d5e654 - without the id test is passing even if I change :allow_destroy from 'false' - adding more tests to strengthen the test suite 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-21 14:25:13 +02:00
Neeraj Singh
f576d7cf84 Ensure that primary_keys of HABTM records is not double quoted 
[#5152 state:reslved]
 2010-07-20 16:45:42 -07:00
Santiago Pastorino
978c49ea6a Make use of severity levels 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-20 23:10:59 +02:00
José Valim
d4151d7f0a Fix a failing test in Railtie and properly define all severity levels in MockLogger for LogSubscriber. 2010-07-20 21:21:14 +02:00
Santiago Pastorino
d39c3b179c Test added, we shouldn't log sql calls when logger is not on debug? mode 2010-07-20 04:32:08 +08:00
Aaron Patterson
1b26c66ce4 mocking out debing? call in the MockLogger 2010-07-19 13:19:28 -07:00
Łukasz Strzałkowski
661fd98aad Make use of redefine_method, removed some more redefining warnings 2010-07-19 23:44:50 +08:00
Łukasz Strzałkowski
7637b7184a Test for behaviour of befeore_type_cast when operating on datetime colmun 2010-07-19 23:44:49 +08:00
Łukasz Strzałkowski
247886e1b4 Removed warnings when a variable is shadowed 2010-07-19 23:44:45 +08:00
Neeraj Singh
0fce4ae57f expected value should come first in assert_equal 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-18 15:13:38 +02:00
Neeraj Singh
6caf943ace primary_keys_test reads better than pk_test 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-18 15:13:29 +02:00
Neeraj Singh
b58e1c52f7 fixing typo 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-18 15:13:21 +02:00
Neeraj Singh
df6aa8e246 removing extra whitespaces 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-18 15:13:14 +02:00
Subba Rao Pasupuleti
4a0d7c1a43 save on parent should not cascade to child unless child changed [#3353 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-18 11:31:29 +02:00
Aaron Patterson
8d17f53318 adding a test for clearing stale connections 2010-07-16 14:39:40 -07:00
Aaron Patterson
7ba54ff711 fixing test file name 2010-07-16 13:54:14 -07:00
Aaron Patterson
2244bb0013 fixing whitespace errors 2010-07-16 13:50:58 -07:00
Santiago Pastorino
79d9e0f155 Makes this test don't trust on the speed of execution 2010-07-17 02:39:26 +08:00
Aaron Patterson
1b2824b659 fixing typeo. thanks bamnet! 2010-07-16 09:13:51 -07:00
Neeraj Singh
1f2a5199cb moving persistence related tests to a new file 
Before refactoring test result from AR:
2291 tests, 7180 assertions, 0 failures, 0 errors

After the refactoring test result from AR:
2291 tests, 7180 assertions, 0 failures, 0 errors

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-16 17:26:06 +02:00
David Genord II
1fcf4e8ecb JoinDependency#graft does not properly set parent join [#5124 state:resolved] 
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
 2010-07-16 08:28:49 +01:00
Pratik Naik
0c2c893434 Revert "Style fixes" 
This reverts commit 3c300b3121.
 2010-07-15 13:17:35 +01:00
wycats
3c300b3121 Style fixes 2010-07-14 17:33:07 -07:00
Aaron Patterson
1db8ed0f4b activerecord tests should inherit from ActiveRecord::TestCase 2010-07-14 16:35:52 -07:00
Aaron Patterson
36150c902b Let's initialize instance variables in the postgres adapter. 2010-07-14 15:04:14 -07:00
Pratik Naik
d5921cdb7a Remove unintentional API changes. [#1108] 2010-07-14 18:32:28 +01:00
Pratik Naik
4a06489525 Style fixes 2010-07-14 16:50:26 +01:00
Jacob Lewallen
d10ecfefb8 Set destroyed=true in opt locking's destroy [#5058 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-14 08:02:17 +02:00
Neeraj Singh
edb5401039 count method should not take options if it is operated on has_many association which has finder_sql or counter_sql 
[#2395 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-13 22:03:35 +02:00
Neeraj Singh
f4fbc2c1f9 update_attributes and update_attributes! are now wrapped in a transaction 
[#922 state:resovled]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-13 22:02:00 +02:00
Vitalii Khustochka
b75fca9e57 Added reorder delegation for ActiveRecord::Base(to be able to overwrite the default_scope ordering in the named scope [#5093 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-13 08:31:55 +02:00
Will St. Clair + Neeraj Singh
b520d602ff string IDs are now quoted correctly [#5064 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-13 08:14:52 +02:00
Subba Rao Pasupuleti
44e7fba59e renaming test name to fix accidently override 
[#5076 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-13 08:09:57 +02:00
Mislav Marohnić
571cb1ddc6 enable AS::JSON.encode to encode AR::Relation by providing as_json method 
[#5073 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-13 08:09:28 +02:00
Neeraj Singh
1d45ea0814 with this fix touch method - does not call validations - doest not call callbacks - updates updated_at/on along with attribute if attribute is provided - marks udpated_at/on and attribute as NOT changed 
[#2520 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-13 07:03:42 +02:00