Commit Graph

1051 Commits

Author SHA1 Message Date
David Heinemeier Hansson
71bdf13b60 Removed the default order by id on has_and_belongs_to_many queries as it could kill performance on large sets (you can still specify by hand with :order)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1162 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-13 17:51:43 +00:00
David Heinemeier Hansson
54cc595dff Improved address header processing
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1161 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-13 17:49:24 +00:00
David Heinemeier Hansson
f3e5e07982 Added submit_to_remote that allows you to trigger an Ajax form submition at the click of the submission button, which allows for multiple targets in a single form through the use of multiple submit buttons #930 [yrashk@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1160 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-13 05:44:43 +00:00
David Heinemeier Hansson
ad24c6d756 Fixed pagination to work with joins #1034 [scott@sigkill.org]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1159 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-13 05:40:22 +00:00
David Heinemeier Hansson
7f558cbd05 Fixed that *rest parameter in map.connect couldn't accept an empty list #1037 [Dee.Zsombor@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1158 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-13 05:35:51 +00:00
David Heinemeier Hansson
ecf82d127b Added Rake target clear_logs that'll truncate all the *.log files in log/ to zero #1079 [Lucas Carlson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1157 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-13 05:32:21 +00:00
David Heinemeier Hansson
2ad8dc6a1f Added :confirm option to link_to_remote just like link_to has #1082 [yrashk@fp.org.ua]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1156 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-13 05:21:37 +00:00
David Heinemeier Hansson
908e9a17d8 Fixed that Base.silence should restore the old logger level when done, not just set it to DEBUG #1084 [yon@milliped.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1155 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-13 05:16:52 +00:00
David Heinemeier Hansson
c29db9f210 Added minute_step as an option to select_minute (and the helpers that use it) to jump in larger increments than just 1 minute. At 15, it would return 0, 15, 30, 45 options #1085 [ordwaye@evergreen.edu]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1154 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-13 05:15:41 +00:00
David Heinemeier Hansson
e0a2dab816 Added KLOC counter for AR and AP. Combined theyre at ~9KLOC
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1153 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-13 05:06:40 +00:00
David Heinemeier Hansson
bf1bcff2bd Fixed that an exception would be thrown when an empty form was submitted #1090 [jan@ulbrich-boerwang.de]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1152 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-13 04:50:54 +00:00
David Heinemeier Hansson
988dc1e862 Improved tests for NumberHelper
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1151 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-13 04:49:01 +00:00
David Heinemeier Hansson
5fe0ecce0a Fixed boolean saving on Oracle #1093 [mparrish@pearware.org]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1150 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-13 04:46:59 +00:00
David Heinemeier Hansson
d5cadfc110 Address parsing failed when the "to" (or "cc", or whatever) was an array. It was also too restrictive in the formats of the addresses #1097 [Jamis]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1149 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-13 04:44:58 +00:00
David Heinemeier Hansson
6f5fcc4469 Made error_messages_for take a symbol as object_name
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1148 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-12 17:44:28 +00:00
David Heinemeier Hansson
7140f65355 Moved TextHelper#human_size to NumberHelper#number_to_human_size, but kept an deprecated alias to the old method name
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1147 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-12 08:04:38 +00:00
David Heinemeier Hansson
3b9e90a4da Moved build_association and create_association for has_one and belongs_to out of deprecation as they work when the association is nil unlike association.build and association.create, which require the association to be already in place #864
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1146 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-12 05:34:10 +00:00
David Heinemeier Hansson
b59619600f No conditions relevant here
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1145 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-11 15:13:43 +00:00
David Heinemeier Hansson
a67beac9d0 Dont quote the body
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1144 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-11 11:46:12 +00:00
David Heinemeier Hansson
256e800a01 Fixed quoting for all address headers, not just to #955 [Jamis Buck] Added that quoting to UTF-8 only happens if the characters used are in that range #955 [Jamis Buck]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1142 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-11 10:29:15 +00:00
David Heinemeier Hansson
ea803aa4e3 Doc changes
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1141 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-10 17:47:04 +00:00
David Heinemeier Hansson
1cad24f6fd Doc fix
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1140 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-10 17:43:12 +00:00
David Heinemeier Hansson
a0403bd732 Fixed #1030
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1139 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-10 17:42:17 +00:00
David Heinemeier Hansson
5cd021393c Tests for AS
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1138 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-10 17:37:20 +00:00
David Heinemeier Hansson
9a97cb25eb Added lazy typing for generate, such that ./script/generate cn == ./script/generate controller and the likes #1051 [k@v2studio.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1137 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-10 17:36:57 +00:00
David Heinemeier Hansson
a677da209b Added rollbacks of transactions if they're active as the dispatcher is killed gracefully (TERM signal) #1054 [Leon Bredt]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1136 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-10 17:34:29 +00:00
David Heinemeier Hansson
1ee780b3bb Fixed that ownership is brought over in pg_dump during tests for PostgreSQL #1060 [pburleson@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1135 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-10 17:32:03 +00:00
David Heinemeier Hansson
5cd815addf Fixed spelling of delimiter #1058
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1134 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-10 17:30:38 +00:00
David Heinemeier Hansson
2daf2c846d Fixed db schema
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1133 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-10 17:29:14 +00:00
David Heinemeier Hansson
057cf4918b Added support for has_and_belongs_to_many associations in eager loading #1064 [Dan Peterson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1132 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-10 17:24:56 +00:00
David Heinemeier Hansson
fdd268138a Made eager loading work with inheritance hierarchies #1065 [Ryan Carver]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1131 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-10 15:49:49 +00:00
David Heinemeier Hansson
2119e0699a Fixed that the content-type for some browsers could include an additional \r which made wonky things happen #1067 [Thomas Fuchs]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1130 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-10 15:22:32 +00:00
David Heinemeier Hansson
023b6855eb Updated docs #1068
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1129 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-10 15:13:44 +00:00
David Heinemeier Hansson
e819da27f4 Updated docs #1070
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1128 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-10 15:13:05 +00:00
David Heinemeier Hansson
ac4b4701c0 Fixed that radio buttons shouldn't have a default size attribute #1074 [hendrik@mans.de] Added ActionView::Helpers::InstanceTag::DEFAULT_RADIO_OPTIONS that contains a hash of default options for radio buttons #1074 [hendrik@mans.de]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1127 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-10 15:11:15 +00:00
David Heinemeier Hansson
25d27b39ea Fixed a few tests
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1126 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-10 15:07:52 +00:00
David Heinemeier Hansson
87bed3af47 Fixed that in some circumstances controllers outside of modules may have hidden ones inside modules. For example, admin/content might have been hidden by /content. #1075 [Nicholas Seckar]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1125 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-10 15:01:35 +00:00
Leon Breedt
a04fc268b7 add missing public API change
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1124 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-10 03:36:19 +00:00
David Heinemeier Hansson
90720a26f6 Fixed syntax error
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1112 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-07 08:37:26 +00:00
David Heinemeier Hansson
4bdb25da18 Update to the helper to abstract delimeting a number #1015
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1111 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-07 06:56:49 +00:00
David Heinemeier Hansson
7ad57c4f02 Added quoting of column names for fixtures #997 [jcfischer@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1110 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-07 06:54:25 +00:00
David Heinemeier Hansson
8afc284e2c Fixed check_box with postgresql booleans is more work now again #995
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1109 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-07 06:44:33 +00:00
David Heinemeier Hansson
1a22fb59c9 Added JavascriptHelper#periodically_call_remote in order to create areas of a page that update automatically at a set interval #945 [Jon Tirsen]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1108 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-07 06:43:21 +00:00
David Heinemeier Hansson
1752583531 generate --quiet documentation #715
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1107 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-07 06:37:02 +00:00
David Heinemeier Hansson
aefb36a688 Fixed Cache#expire_matched_fragments that couldn't recognize the difference between string and url_for options #1030 [skaes@web.de]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1106 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-07 06:35:27 +00:00
David Heinemeier Hansson
affe7c0f67 Fixed unquoting of emails that doesn't have an explicit charset #1036 [wolfgang@stufenlos.net]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1105 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-07 06:30:59 +00:00
David Heinemeier Hansson
7b37c779d8 Fixed counter_sql when no records exist in database for PostgreSQL (would give error, not 0) #1039 [Caleb Tennis]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1104 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-07 06:29:31 +00:00
David Heinemeier Hansson
4ab40059b7 Added simulation of @request.request_uri in functional tests #1038 [Jamis Buck]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1103 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-07 06:22:19 +00:00
David Heinemeier Hansson
bd9a81ca2d Moved to new server
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1102 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-07 06:20:54 +00:00
David Heinemeier Hansson
38a0b5b427 Fixed inflection of perspectives and similar words #1045 [thijs@vandervossen.net]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1101 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-07 06:19:10 +00:00