github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
17,486 Commits 34 Branches 105 Tags
751f89b8b28634cb237d1e47f33ddefaa13829dc
Commit Graph

17486 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Carlos Antonio da Silva
751f89b8b2 Add assertion to link_to_function test with block and capture, and more expressive test name [#5179 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-25 23:00:15 +02:00
Xavier Noria
92669b8320 application generation: --skip-testunit and --skip-activerecord renamed to --skip-test-unit and --skip-active-record respectively 
Reason is their proper spellings are "Test::Unit" and "Active Record".
Option names and descriptions have been revised, as well as some method
names and minor details here and there.
 2010-07-25 22:55:38 +02:00
José Valim
331df84cc9 Cache connection access. 2010-07-25 21:01:49 +02:00
José Valim
304c49b146 Move runtime back to connection. 2010-07-25 20:59:37 +02:00
José Valim
ff0d842454 Revert the previous three commits. 
* AS::Notifications#instrument should not measure anything, it is not its responsibility;

* Adding another argument to AS::Notifications#instrument API needs to be properly discussed;
 2010-07-25 20:46:42 +02:00
Aaron Patterson
0d0e793983 look up connection once 2010-07-25 11:16:13 -07:00
Aaron Patterson
fc088d4e8f cache the instrumentor for a speed gain 2010-07-25 11:11:51 -07:00
Aaron Patterson
b7e0408ca9 use a hash to collect optional statistics about the instrumentation 2010-07-25 11:11:23 -07:00
José Valim
d02f2d2fb2 runtime should be properly initialized. 2010-07-25 18:26:42 +02:00
José Valim
82c7ef837d Move runtime to log subscriber. 2010-07-25 16:42:05 +02:00
Santiago Pastorino
b1cfcedc8f Change returning with tap 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-25 16:33:04 +02:00
Sebastian A. Espindola
8d5b792e7d Fixed output_buffer encoding problem [#5179] 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-25 16:33:04 +02:00
Santiago Pastorino
749948a264 Removing one AS/lib ruby and rake adds to $LOAD_PATH 2010-07-25 08:27:00 +08:00
José Valim
834bd23a07 Get rid of instrumenter.elapsed. 2010-07-24 10:22:22 +02:00
Santiago Pastorino
85980852a0 make a throwaway value equals to _ to avoid warnings 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-24 01:19:55 +02:00
Santiago Pastorino
8289661903 Make this test, test again 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-24 01:19:47 +02:00
Santiago Pastorino
e1d4e78b15 Removes unused vars 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-24 01:19:44 +02:00
Santiago Pastorino
80cf6559ed Makes restore previosly saved warnings_on_first_load value and avoid warning 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-24 01:19:43 +02:00
José Valim
7a7cbab1f4 Merge branch 'master' of github.com:rails/rails 2010-07-24 00:49:16 +02:00
José Valim
76b6136b00 Clean up AM and AC railties. 2010-07-24 00:48:12 +02:00
José Valim
2af8fd2829 Also move asset_path to AbstractController. 2010-07-24 00:47:48 +02:00
Xavier Noria
728ba209e7 include the root README.rdoc as main page 2010-07-24 00:35:22 +02:00
Jeroen van Dijk and Josh Kalderimis
affeb51569 Move config_accessor :asset_host from ActionController::Base to AbstractController which fixes issues with asset_host in ActionMailer 
Including:
  - Moved mailer objects in separate directory
  - Added two tests for asset_host configuration option
 2010-07-24 00:27:25 +02:00
Aaron Patterson
b50635a59f update Rakefiles for RDoc 2.5 2010-07-23 21:11:29 +02:00
Aaron Patterson
5ebc1d88d3 testing sqlbypass destroy. caching connection during destroy 2010-07-23 08:36:58 -07:00
Aaron Patterson
9b48a94c0a brrrrr! freeze is not needed 2010-07-23 08:30:14 -07:00
Aaron Patterson
5e6382e607 fixing space error 2010-07-22 23:45:07 -07:00
Aaron Patterson
34ff74f448 refactoring more methods to a class methods module 2010-07-22 23:44:58 -07:00
Aaron Patterson
da37716c35 refactoring class methods to a module 2010-07-22 23:40:39 -07:00
Santiago Pastorino
b378b19430 Makes Rakefile activate rdoc >= 2.5.9 
Signed-off-by: Xavier Noria <fxn@hashref.com>
 2010-07-23 00:04:06 +02:00
Xavier Noria
2944a79452 bump required RDoc to >= 2.5.9, and replace the 2.2 horo.rb with Aaron's gem 2010-07-22 23:19:01 +02:00
Santiago Pastorino
227680f415 session_id is a VARCHAR 2010-07-22 13:34:27 -07:00
Jeremy Kemper
3ec6759552 Session data will exceed 255 bytes. Use TEXT. 2010-07-22 13:34:07 -07:00
José Valim
64ca80e523 Merge remote branch 'spastorino/master' 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-07-22 21:46:01 +02:00
Santiago Pastorino
24f303b677 Makes current adapter decide the syntax of PRIMARY KEY column definition 2010-07-22 15:49:05 -03:00
Santiago Pastorino
7113f207c3 This is a VARCHAR not a TEXT 2010-07-22 15:48:57 -03:00
Santiago Pastorino
1b8cd5fb53 MySQL can't index a TEXT column 2010-07-22 15:48:55 -03:00
Santiago Pastorino
21c4b0942f Don't shadow outer local variables 2010-07-22 15:48:52 -03:00
Carlhuda
ba8d89c4c8 Performance optimizations to handle cases of instrumentors that are not listened to. Also, fix a possible concurrency issue. 2010-07-22 11:36:16 -07:00
Aaron Patterson
97f3c7387e refactor to use instance methods and be kind to subclasses 2010-07-22 09:38:56 -07:00
Aaron Patterson
38734aff20 adding a test for session save 2010-07-22 09:35:50 -07:00
Santiago Pastorino
30df88ae06 These tests are trusting in the order of the elements so use OrderedHash instead of Hash 2010-07-21 17:34:43 -07:00
Santiago Pastorino
a1e795f554 options could be of any kind of Hash (Hash, HashWithIndifferentAccess or OrderedHash) this way we keep the properties of the options passed as an argument 2010-07-21 17:34:02 -07:00
Aaron Patterson
a78547a9c6 testing loaded? method and reducing funcalls 2010-07-21 16:59:23 -07:00
Aaron Patterson
87a319cd0c testing new_record? and converting to an attribute 2010-07-21 16:55:04 -07:00
Aaron Patterson
f5de56f537 reducing function calls in the session store 2010-07-21 16:52:15 -07:00
Aaron Patterson
4e6cf429a1 readability is hip 2010-07-21 16:45:38 -07:00
Aaron Patterson
ba0d2a9ce3 starting sql bypass test, fixing create_table and drop_table! 2010-07-21 16:36:28 -07:00
Aaron Patterson
bdbe390a98 initializing instance variables 2010-07-21 16:36:28 -07:00
Aaron Patterson
1f8edb996b adding tests for sessions and clearing up warnings 2010-07-21 16:36:28 -07:00