github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-02-01 01:34:57 -05:00
Code Issues Packages Projects Releases Wiki Activity
4,848 Commits 34 Branches 105 Tags
7722e2bf6c8bc0e81e61a47809cdbbf52b33ce6b
Commit Graph

4848 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Tobias Lütke
7722e2bf6c Introduce RELATIVE_RAILS_ROOT and changed spawner script to use it. Prior to this change spawner would assume the non symlinked deploy directory which made reaper reload the wrong code after further deployments. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6531 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-04-16 21:55:59 +00:00
Rick Olson
39ccb5e807 Tweak template format rules so that the ACCEPT header is only used if it's text/javascript. This is so ajax actions without a :format param get recognized as Mime::JS. [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6522 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-04-15 18:01:40 +00:00
David Heinemeier Hansson
c2f4681ab4 Added yielding of Builder instance for ActiveRecord::Base#to_xml calls [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6519 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-04-13 01:26:17 +00:00
Rick Olson
596112dcf8 remove useless mock test 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6518 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-04-12 20:26:42 +00:00
Rick Olson
6351e0a541 The default respond_to blocks don't set a specific extension anymore, so that both 'show.rjs' and 'show.js.rjs' will work. [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6517 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-04-12 20:25:32 +00:00
Rick Olson
f5b8fc0335 Allow layouts with extension of .html.erb. Closes #8032 [Josh Knowles] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6516 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-04-12 17:11:48 +00:00
Jeremy Kemper
d699084f7a script/console quotes RAILS_ROOT in irb command line so it works with spaces in the path. Closes #7955. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6512 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-04-09 17:34:24 +00:00
Tobias Lütke
01c35c8175 Removed ill faded xml_node class from codebase. Use XmlSimple instead 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6511 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-04-09 15:33:38 +00:00
Rick Olson
4b08caf330 Only load ActionController::UrlWriter if ActionController is present [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6510 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-04-08 21:24:48 +00:00
Rick Olson
ec4d407d4f add #view_paths attr_accessor for ActionView::Base 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6509 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-04-08 18:29:57 +00:00
Rick Olson
da336c1cad add tip on keeping backwards compatibility 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6508 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-04-08 17:18:10 +00:00
Rick Olson
e0f8342676 Change default respond_to templates for xml and rjs formats. [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6507 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-04-08 17:16:36 +00:00
Rick Olson
bdb1fcc3b8 Fix WSOD due to modification of a formatted template extension so that requests to templates like 'foo.html.erb' fail on the second hit. [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6506 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-04-08 16:53:37 +00:00
Rick Olson
142b074e91 Fix WSOD when template compilation fails [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6505 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-04-08 02:32:25 +00:00
Rick Olson
da6f5a1cb4 Change ActionView template defaults. Look for templates using the request format first, such as show.html.erb or show.xml.builder, before looking for the old defaults like show.erb or show.builder [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6499 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-04-02 00:02:11 +00:00
Rick Olson
cf865196fe add ActionView::Base#find_template_extension_for tests 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6498 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-04-01 22:29:19 +00:00
Jeremy Kemper
67d5a1abed Highlight helper highlights one or many terms in a single pass. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6493 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-30 01:19:01 +00:00
Jeremy Kemper
29d63a04ac Canonicalize configuration.root_path and replace RAILS_ROOT. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6488 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-29 05:44:44 +00:00
David Heinemeier Hansson
0cac2806a6 Dropped the use of ; as a separator of non-crud actions on resources and went back to the vanilla slash. It was a neat idea, but lots of the non-crud actions turned out not to be RPC (as the ; was primarily intended to discourage), but legitimate sub-resources, like /parties/recent, which didn't deserve the uglification of /parties;recent. Further more, the semicolon caused issues with caching and HTTP authentication in Safari. Just Not Worth It [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6485 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-28 21:55:40 +00:00
Tobias Lütke
df3ee41126 Improved the handling of broken accept headers 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6484 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-28 16:42:21 +00:00
David Heinemeier Hansson
0228975a4e Added that FormTagHelper#submit_tag will return to its original state if the submit fails and you're using :disable_with [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6480 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-27 19:42:54 +00:00
Rick Olson
2a305949d7 documentation project patches, closes #7342, #7319, #7316, #7190 [jeremymcanally] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6470 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-27 14:04:06 +00:00
Rick Olson
4b78a2a245 Add helpful debugging info to the ActiveRecord::StatementInvalid exception in ActiveRecord::ConnectionAdapters::SqliteAdapter#table_structure. Closes #7925. [court3nay] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6469 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-27 06:57:53 +00:00
Jamis Buck
777deb9d15 Make sure the expiry hash is built by comparing the to_param-ized values of each hash 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6465 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-26 19:02:19 +00:00
Jeremy Kemper
b0685e9684 Fix PStore typo. Closes #7900. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6455 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-23 16:53:57 +00:00
Rick Olson
c6d7260841 Allow configuration of the default action cache path for #caches_action calls. [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6453 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-22 10:12:34 +00:00
Tobias Lütke
f39fe3091f Fix nil error for requests with empty PATH_INFO header such as those which are send by the ScanAlert spider 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6451 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-19 18:02:24 +00:00
Jeremy Kemper
b5e01f3e4a SQLite: binary escaping works with ='u'. Closes #7862. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6449 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-19 12:49:23 +00:00
Jeremy Kemper
65704aeacd Never return nil from CGI#read_query for compatibility with plain CGI query params parser. Closes #7581. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6446 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-18 13:39:58 +00:00
Jeremy Kemper
2632664f64 Deprecation: remove components from controller paths. Canonicalize RAILS_ROOT by using File.expand_path on Windows, which doesn't have to worry about symlinks, and Pathname#realpath elsewhere, which respects symlinks in relative paths but is incompatible with Windows. Closes #6755. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6445 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-18 13:35:16 +00:00
Jeremy Kemper
27ba5edef1 Hash#to_xml supports YAML attributes; ActiveRecord::Base#to_xml support serialized attributes. Closes #7502. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6444 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-18 07:30:09 +00:00
Sam Stephenson
3202fbabe6 Refactor ActiveSupport::JSON to be less obtuse. Add support for JSON decoding by way of Syck with ActiveSupport::JSON.decode(json_string). Prevent hash keys that are JavaScript reserved words from being unquoted during encoding. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6443 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-18 07:05:58 +00:00
Jeremy Kemper
3d5c947155 Fix method visibility bug uncovered by #7854. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6442 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-18 03:32:48 +00:00
Jeremy Kemper
46f092097b alias_method_chain preserves the original method's visibility. Closes #7854. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6441 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-18 03:16:53 +00:00
Jeremy Kemper
a38f28fff1 Base.update_all :order and :limit options. Useful for MySQL updates that must be ordered to avoid violating unique constraints. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6440 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-17 15:48:47 +00:00
Michael Koziarski
f87db851c6 Remove deprecated object transactions. People relying on this functionality should install the object_transactions plugin at http://code.bitsweat.net/svn/object_transactions. Closes #5637 [Koz, Jeremy Kemper] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6439 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-16 22:39:01 +00:00
Michael Koziarski
16b4739e1e Remove special cases for BigDecimal and SQLite, tests pass without them and fail with them. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6437 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-16 21:41:09 +00:00
Jeremy Kemper
c593721e7c Revert [6430] since the test is faulty. References #7837, closes #7842. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6435 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-16 13:55:36 +00:00
Jeremy Kemper
bcff10adec Fix typo in migration test. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6434 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-16 08:26:45 +00:00
Jeremy Kemper
db69c9c12a PostgreSQL: remove DateTime -> Time downcast. Bypass the DateTime migration test on 64-bit platforms since it may be a Time. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6433 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-16 08:25:37 +00:00
Jeremy Kemper
814dd007e5 Performance: patch cgi/session/pstore to require digest/md5 once rather than per #initialize. Closes #7583. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6431 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-16 05:52:12 +00:00
Jeremy Kemper
f596dda0bb Undeprecate redirect_to with Hash argument and additional url_for parameters. Closes #7837. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6430 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-16 05:21:19 +00:00
Nicholas Seckar
8a9496cb4e Add environment variable RAILS_DEFAULT_DATABASE, which allows the builtin default of 'mysql' to be overridden. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6429 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-14 23:45:17 +00:00
Nicholas Seckar
d16aa4e039 Fix changelog line 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6427 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-14 23:30:08 +00:00
Nicholas Seckar
4eec5f4fbb Update Dependencies to ignore constants inherited from ancestors. Closes #6951. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6426 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-14 23:27:28 +00:00
Jeremy Kemper
bbcfb9b625 Cookie session store: ensure that new sessions doesn't reuse data from a deleted session in the same request. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6424 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-14 11:33:10 +00:00
Jeremy Kemper
1f02271048 Deprecation: verification with :redirect_to => :named_route shouldn't be deprecated. Closes #7525. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6422 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-14 01:38:41 +00:00
Jeremy Kemper
14cc8d2faf find_or_create_by_* takes a hash so you can create with more attributes than are in the method name. Closes #7368. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6420 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-14 01:08:45 +00:00
Jeremy Kemper
5219aa9008 Cookie session store: raise ArgumentError when :session_key is blank. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6415 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-13 20:44:16 +00:00
Michael Koziarski
5bd116ccf4 Make sure with_scope takes both :select and :joins into account when setting :readonly. Allows you to save records you retrieve using finders on a has_many :through associations. [Koz] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@6413 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-03-13 09:45:09 +00:00