Commit Graph

13346 Commits

Author SHA1 Message Date
José Valim
7d4d97e22a Actually, revert previous commit. Having a lot of information is better than having no information at all. 2010-03-05 15:49:36 +01:00
José Valim
80715cee73 Define to_s method in ActionView::Resolver, so I'm not required to write it in inherited classes. 2010-03-05 15:40:06 +01:00
Carl Lerche
57cf1c578a Remove the ability to set the mountpoint when initializing a route set. 2010-03-04 22:17:25 -08:00
Carl Lerche
9a17416d8b Tweak out url_for uses :script_name and add some tests 2010-03-04 22:00:30 -08:00
Carl Lerche
48672cd199 Have ActionDispatch::Routing::RouteSet.new ready to receive routes as is. 2010-03-04 21:40:26 -08:00
Bryan Helmkamp
deb00bcb8c Read Rails version from a file instead of modifying the load path and doing requires
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2010-03-04 21:25:52 -08:00
Carlhuda
46bf2f04a8 Fixed a broken AM test. I'm unsure how this passed before. 2010-03-04 17:44:16 -08:00
Carlhuda
900a2d304a Get rid of relative_url_path in favor of respecting SCRIPT_NAME. Also added a way to specify a default SCRIPT_NAME when generating URLs out of the context of a request. 2010-03-04 17:43:46 -08:00
Carlhuda
3438373f03 Use AS::Concern for caching modules 2010-03-04 16:59:54 -08:00
Carlhuda
ff29606c06 Refactor cache_store to use ActionController config 2010-03-04 16:50:57 -08:00
Carlhuda
c8e1cc8657 remove_method is private 2010-03-04 16:35:05 -08:00
Carlhuda
ecf84b239f Change generated code to replace faulty comment 2010-03-04 16:12:34 -08:00
Carlhuda
e311622e7b Deprecated ActionController::Base.session_options= and ActionController::Base.session_store= in favor of a config.session_store method (which takes params) and a config.cookie_secret variable, which is used in various secret scenarios. The old AC::Base options will continue to work with deprecation warnings. 2010-03-04 16:05:52 -08:00
Carlhuda
48bb3b3904 Move stuff from compatibility.rb to deprecated.rb 2010-03-04 16:05:52 -08:00
Jeremy Kemper
5e3e5ac12b Clarify cookie jar test 2010-03-04 15:31:28 -08:00
wycats
7c785592ec Safely cleans up a test to avoid relying on a particular test order 2010-03-04 15:07:26 -08:00
wycats
70916f6a9c Fixes test ordering bug (ht: evan) 2010-03-04 12:21:12 -08:00
Carlhuda
9795bf0e74 Fix Sam Ruby's tests and deprecation warnings 2010-03-04 12:12:04 -08:00
Carlhuda
1776969627 Move session and session_store onto ActionDispatch and add deprecation warnings 2010-03-04 11:58:30 -08:00
Carl Lerche
c0c1599fb1 Update CI to the latest bundler 2010-03-04 11:24:38 -08:00
Carl Lerche
cc789ddc89 No need for a module if it's only being included once into an empty class. 2010-03-04 09:56:40 -08:00
Carl Lerche
0de3b9ec93 Somehow this fixes the AR tests when ran with rake. I should probably figure out why. 2010-03-04 02:20:01 -08:00
Carl Lerche
05b9382e29 Update the ActionMailer tests to run off of the latest ActionController config refactor 2010-03-04 01:12:16 -08:00
Carl Lerche
ad2e6ee4ec Fix a bunch of failing AP / AM specs created from the previous AbstractController configuration refactor. 2010-03-04 01:01:21 -08:00
Carl Lerche
9eddc85444 Add a method for configuring abstract controllers 2010-03-04 00:52:10 -08:00
Carl Lerche
5ce25aecee Merge branch 'configuration_refactor' 2010-03-03 22:35:43 -08:00
Carl Lerche
13a932cddc Modifying configurations on the instance of a controller should not affect the class 2010-03-03 21:32:05 -08:00
Carl Lerche
7dbf5c820b Tweak how ActionPack handles InheritableOptions 2010-03-03 21:29:26 -08:00
Carl Lerche
15b3b74624 Fix all the broken tests due to the AC configuration refactor 2010-03-03 21:24:27 -08:00
Carl Lerche
1f0f05b10c Move the original config method onto AbstractController 2010-03-03 21:24:27 -08:00
Carlhuda
b160663bd1 Start refactoring the method of configuring ActionView 2010-03-03 21:24:01 -08:00
Carlhuda
54302ef55b Add caller to deprecation notices 2010-03-03 21:24:00 -08:00
Carlhuda
786724107c Deprecate IP spoofing settings that are directly on the controller in favor of configuring a middleware 2010-03-03 21:24:00 -08:00
Carlhuda
52efbdcdef Add caller to request_uri deprecation notice 2010-03-03 21:24:00 -08:00
Carlhuda
93422af5d5 Move remote_ip to a middleware:
* ActionController::Base.ip_spoofing_check deprecated => config.action_dispatch.ip_spoofing_check
  * ActionController::Base.trusted_proxies deprecated => config.action_dispatch.trusted_proxies
2010-03-03 21:24:00 -08:00
Carl Lerche
9a9caf646d Add a BlockUntrustedIps middleware 2010-03-03 21:24:00 -08:00
Carl Lerche
902d5a4f05 Indicate that ActionController::Base.resource_action_separator is deprecated and only has an effect with the deprecated router DSL. 2010-03-03 21:24:00 -08:00
Carl Lerche
18bcce596e ActionController::Base.use_accept_header is not actually used anymore, so let's deprecate it. 2010-03-03 21:24:00 -08:00
Carl Lerche
fb14b8c6fd ActionDispatch::Request deprecates #request_uri
* Refactored ActionPatch to use fullpath instead
2010-03-03 21:24:00 -08:00
Carl Lerche
eb49bd6949 Fix tests for the request refactor 2010-03-03 21:24:00 -08:00
Carl Lerche
c92d598abf Rack::Request actually defines #query_string 2010-03-03 21:23:59 -08:00
Carlhuda
5e0a05b8cb Tweak the semantic of various URL related methods of ActionDispatch::Request 2010-03-03 21:23:34 -08:00
Yehuda Katz
2a60cc6822 don't depend on the order of cookies (Hash ordering bug) 2010-03-03 16:07:23 -08:00
Carlhuda
bcfb77782b Work on deprecating ActionController::Base.relative_url_root 2010-03-03 15:49:52 -08:00
Carlhuda
6640903481 Move InheritableOptions into ActiveSupport 2010-03-03 15:49:52 -08:00
Carlhuda
bf9913f8f4 Move session_store and session_options to the AC configuration object 2010-03-03 15:49:52 -08:00
Carlhuda
9731c5213b Don't rely on Rails.application global state in Config 2010-03-03 15:49:24 -08:00
Carlhuda
29158d4158 Remove a failed attempt at refactoring AC configuration 2010-03-03 15:49:24 -08:00
Carl Lerche
7979da2fa8 Revert "In app_generator, fix hardcoded bundle call to derive the bundle executable name from Thor::Util.ruby_command."
This reverts commit 6f4c45199b.

This breaks the tests. Please investigate.
2010-03-03 15:38:22 -08:00
Caio Chassot
6f4c45199b In app_generator, fix hardcoded bundle call to derive the bundle executable name from Thor::Util.ruby_command.
This ensures that eg. when `rails` is called from `ruby1.9`, `bundle1.9` is called.

Signed-off-by: José Valim <jose.valim@gmail.com>
2010-03-03 10:12:42 +01:00