Simon Jefford
7fae0aa4ac
Add configuration option for tld length
2010-09-09 18:26:35 -07:00
Brian Cardarella
5949e705f4
Let YARD document the railties gem
2010-09-09 18:24:34 -07:00
wycats
74b49e87bb
Simplify form_for by removing *args and extract_options! (at asakusa.rb)
2010-09-09 18:24:33 -07:00
Jeremy Kemper
e0e3adff03
Cheaper attribute reads and respond_to?. Add underscore-prefixed method aliased to the attribute name so it can be overridden but still called internally.
2010-09-09 14:39:43 -07:00
Jeremy Kemper
d79b1aa0ba
Fewer object allocations
2010-09-09 14:37:58 -07:00
Jeremy Kemper
cb67d16629
Cheaper attribute_method_matchers
2010-09-09 14:37:58 -07:00
Jeremy Kemper
4b7b8d9e19
Cache unserialized attributes
2010-09-09 14:37:57 -07:00
Jeremy Kemper
cc81b04ae5
AR perf test: switch to mysql2, bundle faker and rbench
2010-09-09 14:34:47 -07:00
Jeremy Kemper
82ea5db030
Fix require for class_attribute
2010-09-09 14:34:29 -07:00
Emilio Tagua
53a90436cf
Refactor finder conditions look up and assigment for apply_finder_conditions.
2010-09-09 13:45:49 -07:00
Emilio Tagua
90c114de67
Refactor Relation#only. No need to go through every option and test it.
2010-09-09 15:30:44 -03:00
Emilio Tagua
e3246ef5b5
Add tests for Relation#only.
2010-09-09 15:27:10 -03:00
Emilio Tagua
33412b6e16
No need to go through every option and test it, just don't add skipped ones.
2010-09-09 15:16:45 -03:00
Neeraj Singh
632120deb4
return is not needed here
2010-09-09 10:34:20 -07:00
Neeraj Singh
2f66b9a76c
remove unnecessary call
...
if operation is count then column_name will never be blank
2010-09-09 10:33:52 -07:00
Aaron Patterson
be07d7b107
creating a new array is required. who knew? :-(
2010-09-09 10:33:22 -07:00
Aaron Patterson
a505c82d2f
no need for Array.wrap, also avoid array creation
2010-09-09 09:44:01 -07:00
Neeraj Singh
d5c57f7c9f
make apply_modules run faster
2010-09-09 09:35:40 -07:00
Mikel Lindsaar
d73b47fc22
Fixing up rails application init command - Rails Guides ticket 32
2010-09-09 23:08:01 +10:00
Mikel Lindsaar
1a8d77d825
Adding linkage to redirect_to from Base and adding status code option reference
2010-09-09 14:05:06 +10:00
Aaron Patterson
03377c755f
eliminate present? for fewer method calls
2010-09-08 16:56:13 -07:00
Aaron Patterson
b4fdfcf6ad
returning arrays lets us avoid Array.wrap
2010-09-08 16:53:17 -07:00
Aaron Patterson
588db0fa8f
removing unnecessary conditional test
2010-09-08 16:38:54 -07:00
Aaron Patterson
0db345a39d
switch to blank? to avoid method calls
2010-09-08 16:33:16 -07:00
Aaron Patterson
cb1f80591e
refactor to use faster empty?
2010-09-08 16:06:48 -07:00
Aaron Patterson
4ccf491ec2
drying up joins()
2010-09-08 15:34:03 -07:00
Aaron Patterson
86384b3c4b
reduce method calls, use reject + blank? instead of select + present?
2010-09-08 15:15:06 -07:00
Aaron Patterson
2faa8bbe11
refactor a couple injects to map + Hash[]
2010-09-08 14:02:47 -07:00
Aaron Patterson
c0c8a04efc
avoid an inject in favor of dup
2010-09-08 13:55:30 -07:00
Aaron Patterson
a5d894ce56
attributes should be constructed with table objects
2010-09-07 16:47:10 -07:00
Aaron Patterson
0c7a4daaa1
attributes should be associated with tables
2010-09-07 16:38:49 -07:00
Aaron Patterson
c6015cbcd8
serialized attributes should be serialized before validation [ #5525 state:resolved]
2010-09-07 13:39:27 -07:00
Aaron Patterson
c8a2dd3cac
no need to freeze this string
2010-09-07 13:13:13 -07:00
Jakub Suder
2524cf404c
fixed some issues with JSON encoding
...
- as_json in ActiveModel should return a hash
and handle :only/:except/:methods options
- Array and Hash should call as_json on their elements
- json methods should not modify options argument
[#5374 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net >
2010-09-07 11:33:10 -07:00
Aaron Patterson
2e8a3d0f43
removing useless code, cleaning variable names
2010-09-07 11:28:01 -07:00
Aaron Patterson
604281221c
select should raise error when no block or no parameter is passed
2010-09-07 10:48:14 -07:00
Aaron Patterson
d00f1c18eb
select does not need a *args
2010-09-07 10:33:20 -07:00
ISHIKAWA Takayuki
816ea74c8e
revision of typo: crytographically [ #5566 state:resolved]
...
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com >
2010-09-07 11:03:37 -03:00
Santiago Pastorino
e8c7f1af0f
unscoped has nothing so merging with a relation just returns the relation
2010-09-07 03:33:06 -03:00
Aaron Patterson
b541a963bd
cleaning up confusing logic
2010-09-06 18:56:16 -07:00
Piotr Sarnacki
32157a2dd2
Add documentation on serving assets from engine strategies
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-09-06 17:09:31 +02:00
Piotr Sarnacki
7c78cc3cca
Use railties:copy_migrations instead of db:copy_migrations
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-09-06 14:38:45 +02:00
Piotr Sarnacki
ec6fa6d3ef
Modified changelog for 3.1.0
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-09-06 14:38:41 +02:00
Piotr Sarnacki
24d2d6726e
Added task for creating symlinks to engines' public directories
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-09-06 14:38:36 +02:00
Carlos Antonio da Silva
c915ddd386
Start cleanup of deprecations in ActionView
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-09-06 13:42:46 +02:00
Carlos Antonio da Silva
022fd876bb
Cleanup Action Dispatch assertions tests
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-09-06 13:42:11 +02:00
Carlos Antonio da Silva
9532d746a9
Cleanup deprecations in Action Dispatch
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-09-06 13:41:12 +02:00
Carlos Antonio da Silva
11fccc5f06
Cleanup deprecation warnings in Action Controller
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-09-06 13:40:45 +02:00
Carlos Antonio da Silva
ed2650646e
Refactor AR validations a bit
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-09-06 13:40:06 +02:00
Carlos Antonio da Silva
9b610049bb
Cleanup deprecation warnings in active record
...
Signed-off-by: José Valim <jose.valim@gmail.com >
2010-09-06 13:39:55 +02:00
