github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-01-30 16:58:15 -05:00
Code Issues Packages Projects Releases Wiki Activity
4,495 Commits 34 Branches 105 Tags
8219db5ee25342ae53bfdcc511b00058121ebb42
Commit Graph

4495 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Rick Olson
8219db5ee2 rollback [5833] and [5835] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5838 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-04 21:43:24 +00:00
Rick Olson
1023bc6e86 Allow ActionController::Base.session_store and #fragment_cache_store to lazily load the session class to allow for custom session store plugins. [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5835 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-04 21:31:18 +00:00
Rick Olson
05aa57bc84 Allow ActionController::Base.session_store to lazily load the session class to allow for custom session store plugins. [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5833 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-04 21:18:13 +00:00
Rick Olson
1af2022cc3 Rollback #new_record? and #id values for created records that rollback in an after_save callback. Closes #6910 [Ben Curren] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5830 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-02 05:36:30 +00:00
Jamis Buck
b75f28edb4 Make sure html_document is reset between integration test requests (closes #6834) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5828 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-01 03:03:13 +00:00
Jeremy Kemper
a0b1ac2ef8 Fix date helper test when run on 31st day of the month! Closes #6907. [mutru] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5826 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-01 01:36:18 +00:00
Jeremy Kemper
e03cd53a7a use stringify_keys 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5824 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-01 01:32:24 +00:00
Jeremy Kemper
fe7995f718 Merge [5822] from 1.2 (oops, wrong order). 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5823 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-01 01:30:28 +00:00
Jeremy Kemper
0f048a5c98 Set session to an empty hash if :new_session => false and no session cookie or param is present. CGI::Session was raising an unrescued ArgumentError. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5820 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-01 01:13:09 +00:00
Jeremy Kemper
0a06ffc08e tighten test_load_once_paths_should_behave_when_recursively_loading 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5816 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2007-01-01 00:25:30 +00:00
Jeremy Kemper
cbe0c3c54f Check for nil name also. Closes #6561. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5814 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-31 23:53:05 +00:00
David Heinemeier Hansson
7ed7930769 Make RDoc not spew errors on install because of HTML comments in code comments 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5813 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-31 19:28:28 +00:00
Nicholas Seckar
91b71ed30c Fix Dependencies.autoloaded? to ignore anonymous modules. Closes #6561. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5811 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-31 18:53:58 +00:00
Jeremy Kemper
54e56ddb60 Validating save returns boolean; update and create return responses. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5810 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-29 22:28:30 +00:00
Jeremy Kemper
73101af6ab prefix_parameters pulls /:path/:params from the URI prefix 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5809 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-29 22:16:04 +00:00
Jamis Buck
6a5388b654 try to appease the angry Oracle 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5808 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-29 19:05:53 +00:00
Jamis Buck
0bfabaa048 make sure query attributes on custom fields works as it used to 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5807 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-29 17:24:35 +00:00
Jeremy Kemper
a8d7215060 doh typo in commit from the hip 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5806 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-29 01:38:39 +00:00
Jeremy Kemper
ee1c6c2a7c generate prefix parameters if undefined 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5805 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-29 01:37:38 +00:00
Jeremy Kemper
4e57ac3544 Query string support. Closes #6855. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5804 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-29 01:18:09 +00:00
Jeremy Kemper
f9f84d9f6d Routing uses URI escaping for path components and CGI escaping for query parameters. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5803 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-28 21:04:44 +00:00
Rick Olson
5cf118b138 Ensure plugins are in the Dependencies.load_once_paths collection by default. [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5801 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-27 22:18:38 +00:00
Michael Koziarski
810d0ade2b Make error_message_on handle nil objects. [dan] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5799 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-27 20:46:12 +00:00
Michael Koziarski
3b4450bb80 Docs fix for columns_hash [bradediger] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5797 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-27 20:41:55 +00:00
Michael Koziarski
58edaaad0b Ensure dynamic finders are anchored to the beginning of the method name to prevent 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5795 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-27 20:35:19 +00:00
David Heinemeier Hansson
014fdde93a Attempt at fixing the preparation_callbacks, nzkoz will double check 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5794 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-27 00:43:27 +00:00
David Heinemeier Hansson
d88e83f211 False is a reasonable default 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5793 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-27 00:42:31 +00:00
Michael Koziarski
c6d47806bf Allow config.to_prepare to work, make the dispatcher safe to 're require'. [Koz, Nicholas Seckar] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5792 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-26 23:56:00 +00:00
Rick Olson
29ec023add Fix scaffold_resource generator so it respects the --pretend argument when creating the routes file. Closes #6852 [fearoffish] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5790 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-26 19:39:30 +00:00
Rick Olson
ef1232c478 forgot to save CHANGELOG 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5786 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-25 09:35:20 +00:00
Rick Olson
64799454a2 Fix assert_redirected_to bug where redirecting from a nested to to a top-level controller incorrectly added the current controller's nesting. Closes #6128. [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5785 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-25 09:34:01 +00:00
Rick Olson
c6b4c8d240 Fix Webrick Daemon dispatching bug regarding a bad current working directory. Closes #4899 [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5784 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-25 09:01:41 +00:00
Nicholas Seckar
e2acd16810 Update load once paths to prevent nested once constants from being detected and claimed by an external non-once load. References #6720 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5782 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-24 14:53:35 +00:00
Nicholas Seckar
1e170da30d Checkin failing test case related to load once paths 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5781 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-24 14:41:29 +00:00
Jeremy Kemper
c172154054 Base#==, eql?, and hash methods. == returns true if its argument is identical to self or if it's an instance of the same class, is not new?, and has the same id. eql? is an alias for ==. hash delegates to id. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5773 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-22 21:42:52 +00:00
Jeremy Kemper
68d2926ab0 Singleton resources: POST /singleton => create, GET /singleton/new => new 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5772 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-22 03:16:50 +00:00
Jeremy Kemper
a1ca37ec86 Use 400 Bad Request status for unrescued ActiveRecord::RecordInvalid exceptions. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5771 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-22 00:27:39 +00:00
Jeremy Kemper
bc3d150386 test that element name includes module nesting 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5770 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-21 23:34:52 +00:00
Jeremy Kemper
4cf8bf7312 Pushing a record on an association collection doesn't unnecessarily load all the associated records. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5769 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-21 23:28:12 +00:00
Jeremy Kemper
8cb6cb58a2 HttpMock InvalidRequestError inspects the mismatched request 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5768 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-21 22:18:58 +00:00
Jeremy Kemper
e6988ef2ce Subclasses share superclass site until explicitly set. This way you can set Superclass.site = ... after subclasses have been defined. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5767 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-21 22:12:21 +00:00
Jeremy Kemper
93c816f0c2 move http_mock to lib so others can use it in their Ares tests 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5766 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-21 20:26:30 +00:00
Jeremy Kemper
01452feff1 DeprecatedInstanceVariable#inspect doesn't warn since test/unit, error logs, and others use it for diagnostics. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5763 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-20 21:28:31 +00:00
Jeremy Kemper
a8b53f1dbb Oracle: fix connection reset failure. Closes #6846. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5761 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-20 21:14:41 +00:00
Jeremy Kemper
7f32a85464 Fix date helper :include_blank regression. Closes #3811. [mhw] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5759 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-20 18:39:41 +00:00
Jeremy Kemper
9a27b29755 Silence log_error deprecation warnings from inspecting deprecated instance variables. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5757 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-19 23:16:10 +00:00
Jeremy Kemper
e56bd3a121 Only cache GET requests with a 200 OK response. Closes #6514, #6743. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5755 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-19 20:25:52 +00:00
Jeremy Kemper
7277c51891 Partially revert [5660] - makes more trouble than it resolves. References #5704, closes #6766. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5753 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-19 19:47:21 +00:00
Jeremy Kemper
8732ce291b Subclass instantiation doesn't try to explicitly require the corresponding subclass. Closes #6840. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5751 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-19 19:23:56 +00:00
Jeremy Kemper
55d248ba72 use RAILS_DEFAULT_LOGGER in debug mode so we can log Dependencies activity 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5750 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-19 18:44:04 +00:00