github/rails
1
1
Fork 0
mirror of https://github.com/github/rails.git synced 2026-04-26 03:00:59 -04:00
Code Issues Packages Projects Releases Wiki Activity
18,433 Commits 34 Branches 105 Tags
83ecd03e7d3472c16decbf1b9939da53347b36a3
Commit Graph

18433 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Stevie Graham
83ecd03e7d use instance_eval, reduce method calls. 
execution time in seconds for `rake test_sqlite3`:

ruby 1.9.2p0 (2010-08-18 revision 29036) [x86_64-darwin10.4.0]
  - before: 52.771426, 52.159505, 52.937056
  - after: 51.452584, 51.897017, 51.584431

rubinius 1.0.1 (1.8.7 release 2010-06-03 JI) [x86_64-apple-darwin10.4.0]
  - before: 284.334076
  - after: 285.753028

ruby 1.8.7 (2009-06-12 patchlevel 174) [universal-darwin10.0]
  - before: 75.811548, 75.533153, 75.353122
  - after: 75.244243, 75.19226, 75.256925
 2010-09-21 01:44:29 +08:00
Piotr Sarnacki
dfac9b1404 Strengthen documantation on engine's migrations and seed data 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-09-20 10:41:12 +02:00
Piotr Sarnacki
d475de7e25 Add helper for loading seed data for engine and application 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-09-20 10:41:05 +02:00
Santiago Pastorino
0523b55ab9 file_field propagates up multipart property even inside of fields_for 2010-09-20 01:11:55 -07:00
Thiago Pradi
800bab79b3 Updating error message on ruby_version_check.rb 
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-09-19 22:32:23 -07:00
rohit
fd53bc85e7 Send 'rails runner' help message to stdout instead of stderr. 
[#5661 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-09-19 16:45:29 -07:00
Santiago Pastorino
88a82bcb2d application.js should be the last file on javascript_include_tag(:all) 2010-09-19 14:41:32 -07:00
Thiago Pradi
3c9bf6e1dc Exception handling more readable 
[#5601 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-09-19 12:18:51 -07:00
Prem Sichanugrist
af6757a1ca Use Time.current to maintain consistency with AS::Duration 
In [32b82e4c6f], the committer has switch
methods in AS::Duration to use `Time.current` to return the correct
duration based on the `Time.default_zone` instead of using `Time.now`.

[#5607 state:committed]

Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
 2010-09-19 11:26:20 -07:00
Piotr Sarnacki
e3d38e7da2 Fix running engine_test in isolation 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-09-19 17:10:43 +02:00
Piotr Sarnacki
ceca0c34fa Remove unnecessary puts 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-09-19 17:10:41 +02:00
Xavier Noria
2b6c2e947b adds to the API guidelines the proper spelling of Arel 2010-09-19 00:05:05 +02:00
Aaron Patterson
2d65ff5af7 removing some warnings 2010-09-18 14:14:46 -07:00
Aaron Patterson
6b50bfb0f0 freeze is not necessary 2010-09-18 14:03:29 -07:00
Aaron Patterson
38f6533792 argument error is done for us 2010-09-18 14:00:00 -07:00
Prem Sichanugrist
1f6b0a554b [CI] Remove RailTies temporary directory on every run 
There was an error on CI regarding unable to require `arel` gem from source when testing application build for a while ago. It seems to me like there's a permission problem on the process of cloning the application and removing Gemfile. This would make sure that the temporary application got removed every time the build is run.

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-09-18 21:59:29 +02:00
Santiago Pastorino
b17b980a15 file_field makes the enclosing form multipart 2010-09-18 12:31:00 -07:00
David Trasbo
e808224652 Remove existing migration when using 'rails generate model' with --force [#5526 state:committed] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-09-18 21:22:29 +02:00
Maxim Chernyak
20685d07ab Fix header capitalization by explicitly upcasing first letter of every word, and avoiding capitalize. [#5636 state:resolved] 2010-09-18 20:49:51 +02:00
Mike Abner
154081f0f7 make sure a Content-Length header exists and that the response.body is not nil before trying to call methods on it. Rack does not allow HTTP 204 responses to have a content-length header set. [#5038 state:resolved] 2010-09-18 20:49:45 +02:00
Neeraj Singh
39debfc854 test for #5038 2010-09-18 20:49:41 +02:00
Krekoten' Marjan
d4fa120671 Move capture to Kernel. [#5641 state:resolved] 2010-09-18 20:49:36 +02:00
rohit
76266a8184 Fix output of 'rails runner --help' [#4249 state:open] 2010-09-18 20:49:33 +02:00
Tim Connor
37de59eacf Fix issue with remove_index and add unit test [#5645 state:resolved] 2010-09-18 20:49:31 +02:00
Tim Connor
55d0d57bfc Raise errors when index creation fails 2010-09-18 20:49:28 +02:00
Neeraj Singh
9401fa0b9c expanding the test to include both type of order declaration 
while declaring default_scope

Also added test for unscoped using block style with four different
combinations

Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-09-18 20:49:19 +02:00
Neeraj Singh
8ae913664f remove irrelevant comments 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-09-18 20:33:40 +02:00
Andrew White
0bffd7d933 Raise ArgumentError instead of normalizing controller name when there is a leading slash [#5651 state:resolved] 2010-09-18 17:49:46 +01:00
Andrew White
013ed1c050 Remove leading slash from controller [#5651 state:resolved] 2010-09-18 13:32:54 +01:00
Carl Lerche
5ff2b73b48 Small tweak the ConditionalGet documentation 
Time#utc does not need to be called when passing the object to :last_modified 	since it is called internally to Rails.
 2010-09-17 14:20:35 -07:00
Carl Lerche
117daba18a Update Rails' built in routes to use RouteSet#append 2010-09-17 12:27:48 -07:00
Carl Lerche
7418a44096 Add RouteSet#append 
Allows specifying blocks to the routeset that will get 	appended after the RouteSet is drawn.
 2010-09-17 12:05:40 -07:00
Emilio Tagua
f2765a1cb3 Refactor setup methods by extracting them in abstract_unit, remove TODO. 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-09-17 17:03:58 +02:00
Emilio Tagua
a521a3c05a Remove TODO and support all expected attributes. 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-09-17 17:03:51 +02:00
Aaron Patterson
3480551e67 removing nonsensical tests, limit now actually adds a limit 2010-09-15 14:18:16 -07:00
Aaron Patterson
55736ef125 @join_values is passed in, so we should use the parameter 2010-09-15 14:18:15 -07:00
Sparky
eeb3246991 Only add Rack::Cache to the middleware stack if config.action_controller.perform_caching is set. 2010-09-15 12:58:49 -07:00
Xavier Noria
dd6efe98b6 Merge remote branch 'docrails/master' 2010-09-14 20:07:29 +02:00
Carl Lerche
9362ef6e21 Require lazy_load_hooks.rb with the correct path. 2010-09-14 10:40:05 -07:00
Jack Dempsey
a427876606 require i18n in transliterate so it can run in isolated situations 2010-09-14 10:25:33 -07:00
rohit
b59a8d42c3 Application settings are specified in application.rb and not environment.rb 2010-09-14 10:07:34 +05:30
Xavier Noria
0207bc7cc9 get csrf_meta_tag back to the generated layout in deference to existing printed material, chomp also the generated HTML to be faithful to the output before the refactor 2010-09-14 01:35:44 +02:00
Carlhuda
d8d8334a0b Update changelog 2010-09-13 16:06:40 -07:00
Carlhuda
0fe99e87c0 Add tests for Rack::Cache 2010-09-13 16:06:03 -07:00
wycats
254ab7d916 First pass at Rack::Cache 2010-09-13 16:06:03 -07:00
W. Andrew Loe III
9cd094b8da Only send secure cookies over SSL. 2010-09-13 15:11:46 -07:00
Xavier Noria
0522b26cdf reviews 02656ac 2010-09-13 23:10:43 +02:00
Xavier Noria
2eb5476d22 copy-edits 4eb8987 2010-09-13 22:54:42 +02:00
Marcelo Giorgi
d5ef502d2a Reference watch_namespaces in comments instead of watch_modules 2010-09-13 17:53:39 -03:00
Carl Lerche
84d0c30cea Allow view helper's #initialize method to be called. [#5061 state:resolved] 2010-09-13 12:51:42 -07:00